DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>,
	 Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: remove device-specific comments from VLAN API
Date: Wed, 5 Aug 2020 11:19:42 +0200
Message-ID: <CAJFAV8ws54WWc3vknwRW-29zutBL21-tnphTX9i-zaGofdkUWw@mail.gmail.com> (raw)
In-Reply-To: <20200804094808.3339810-1-thomas@monjalon.net>

On Tue, Aug 4, 2020 at 11:48 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> Some confusing comments were still present from old days,
> when most drivers were from Intel.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2: remove i40e comment for pvid field
> ---
>  lib/librte_ethdev/rte_ethdev.h | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
> index 57e4a6ca58..d29930fd84 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -924,7 +924,6 @@ struct rte_eth_txmode {
>          */
>         uint64_t offloads;
>
> -       /* For i40e specifically */
>         uint16_t pvid;
>         __extension__
>         uint8_t hw_vlan_reject_tagged : 1,
> @@ -2846,7 +2845,6 @@ int rte_eth_dev_vlan_filter(uint16_t port_id, uint16_t vlan_id, int on);
>
>  /**
>   * Enable/Disable hardware VLAN Strip by a rx queue of an Ethernet device.
> - * 82599/X540/X550 can support VLAN stripping at the rx queue level
>   *
>   * @param port_id
>   *   The port identifier of the Ethernet device.
> @@ -2868,8 +2866,7 @@ int rte_eth_dev_set_vlan_strip_on_queue(uint16_t port_id, uint16_t rx_queue_id,
>
>  /**
>   * Set the Outer VLAN Ether Type by an Ethernet device, it can be inserted to
> - * the VLAN Header. This is a register setup available on some Intel NIC, not
> - * but all, please check the data sheet for availability.
> + * the VLAN header.
>   *
>   * @param port_id
>   *   The port identifier of the Ethernet device.
> @@ -2888,12 +2885,7 @@ int rte_eth_dev_set_vlan_ether_type(uint16_t port_id,
>                                     uint16_t tag_type);
>
>  /**
> - * Set VLAN offload configuration on an Ethernet device
> - * Enable/Disable Extended VLAN by an Ethernet device, This is a register setup
> - * available on some Intel NIC, not but all, please check the data sheet for
> - * availability.
> - * Enable/Disable VLAN Strip can be done on rx queue for certain NIC, but here
> - * the configuration is applied on the port level.
> + * Set VLAN offload configuration on an Ethernet device.
>   *
>   * @param port_id
>   *   The port identifier of the Ethernet device.

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


  reply	other threads:[~2020-08-05  9:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04  9:41 [dpdk-dev] [PATCH] " Thomas Monjalon
2020-08-04  9:48 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-08-05  9:19   ` David Marchand [this message]
2020-08-05 11:27   ` Andrew Rybchenko
2020-08-05 16:57     ` Ferruh Yigit
2020-08-05 18:02       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8ws54WWc3vknwRW-29zutBL21-tnphTX9i-zaGofdkUWw@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git