DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] test/ring: remove unused code
@ 2020-11-02 19:56 Honnappa Nagarahalli
  2020-11-15 15:57 ` David Marchand
  0 siblings, 1 reply; 2+ messages in thread
From: Honnappa Nagarahalli @ 2020-11-02 19:56 UTC (permalink / raw)
  To: dev, honnappa.nagarahalli, konstantin.ananyev
  Cc: feifei.wang, ruifeng.wang, nd, feifei.wang2

Remove unused assignment statement as the assigned variable is
not used in the code further.

Coverity issue: 363690
Fixes: 6c583103a2d1 ("test/ring: factorize object checks")
Cc: feifei.wang2@arm.com

Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Feifei Wang <feifei.wang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 app/test/test_ring.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/app/test/test_ring.c b/app/test/test_ring.c
index 5b7fdfa45..fb8532a40 100644
--- a/app/test/test_ring.c
+++ b/app/test/test_ring.c
@@ -725,7 +725,6 @@ test_ring_burst_bulk_tests2(unsigned int test_idx)
 		ret = test_ring_enq_impl(r, cur_src, esize[i], MAX_BULK,
 						test_idx);
 		TEST_RING_VERIFY(ret == MAX_BULK, r, goto fail);
-		cur_src = test_ring_inc_ptr(cur_src, esize[i], MAX_BULK);
 
 		printf("dequeue 1 obj\n");
 		ret = test_ring_deq_impl(r, cur_dst, esize[i], 1, test_idx);
@@ -1050,7 +1049,6 @@ test_ring_basic_ex(void)
 		ret = test_ring_enqueue(rp, cur_src, esize[i], 2,
 				TEST_RING_THREAD_DEF | TEST_RING_ELEM_BULK);
 		TEST_RING_VERIFY(ret == 2, rp, goto fail_test);
-		cur_src = test_ring_inc_ptr(cur_src, esize[i], 2);
 
 		ret = test_ring_dequeue(rp, cur_dst, esize[i], 2,
 				TEST_RING_THREAD_DEF | TEST_RING_ELEM_BULK);
@@ -1157,7 +1155,6 @@ test_ring_with_exact_size(void)
 		ret = test_ring_enqueue(exact_sz_r, cur_src, esize[i], 1,
 				TEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE);
 		TEST_RING_VERIFY(ret != -ENOBUFS, exact_sz_r, goto test_fail);
-		cur_src = test_ring_inc_ptr(cur_src, esize[i], 1);
 
 		/* check that dequeue returns the expected number of elements */
 		ret = test_ring_dequeue(exact_sz_r, cur_dst, esize[i], ring_sz,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] test/ring: remove unused code
  2020-11-02 19:56 [dpdk-dev] [PATCH] test/ring: remove unused code Honnappa Nagarahalli
@ 2020-11-15 15:57 ` David Marchand
  0 siblings, 0 replies; 2+ messages in thread
From: David Marchand @ 2020-11-15 15:57 UTC (permalink / raw)
  To: Honnappa Nagarahalli
  Cc: dev, Ananyev, Konstantin, feifei.wang,
	Ruifeng Wang (Arm Technology China),
	nd, Feifei Wang

On Mon, Nov 2, 2020 at 8:57 PM Honnappa Nagarahalli
<honnappa.nagarahalli@arm.com> wrote:
>
> Remove unused assignment statement as the assigned variable is
> not used in the code further.
>
> Coverity issue: 363690
> Fixes: 6c583103a2d1 ("test/ring: factorize object checks")
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Feifei Wang <feifei.wang@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-15 15:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-02 19:56 [dpdk-dev] [PATCH] test/ring: remove unused code Honnappa Nagarahalli
2020-11-15 15:57 ` David Marchand

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git