From: David Marchand <david.marchand@redhat.com>
To: christian.ehrhardt@canonical.com
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] build: riscv is not a valid -march value
Date: Wed, 22 Nov 2023 17:39:35 +0100 [thread overview]
Message-ID: <CAJFAV8x-9ALyHs6yh_x_LLqURVbE_+TefprJbjXOpcz0-VjpFw@mail.gmail.com> (raw)
In-Reply-To: <20231121164903.3982163-1-christian.ehrhardt@canonical.com>
On Tue, Nov 21, 2023 at 5:49 PM <christian.ehrhardt@canonical.com> wrote:
>
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
>
> If building riscv natively with -Dplatform=generic config/meson.build
> will select cpu_instruction_set=riscv.
>
> That was fine because config/riscv/meson.build did override it to valid
> values later, but since b7676fcccab4 ("config: verify machine arch
> flag") it will break the build as it tries to test -march=riscv which
> is not a value value.
>
> The generic setting used in most cases is rv64gc, set this here
> as well.
>
> Fixes: b7676fcccab4 ("config: verify machine arch flag")
> Fixes: f22e705ebf12 ("eal/riscv: support RISC-V architecture")
>
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Acked-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2023-11-22 16:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 16:49 christian.ehrhardt
2023-11-22 13:27 ` Tummala, Sivaprasad
2023-11-22 16:02 ` David Marchand
2023-11-22 16:17 ` Bruce Richardson
2023-11-22 16:41 ` David Marchand
2024-01-05 15:50 ` Stanisław Kardach
2023-11-22 16:39 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8x-9ALyHs6yh_x_LLqURVbE_+TefprJbjXOpcz0-VjpFw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).