DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>,
	dpdk-dev <dev@dpdk.org>,  Jerin Jacob <jerinj@marvell.com>,
	Pavan Nikhilesh <pbhagavatula@marvell.com>,
	 Liang Ma <liang.j.ma@intel.com>,
	Peter Mccarthy <peter.mccarthy@intel.com>,
	 Harry van Haaren <harry.van.haaren@intel.com>,
	Ray Kinsella <mdr@ashroe.eu>,
	 Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH 7/8] event: switch sequence number to dynamic field
Date: Wed, 28 Oct 2020 09:55:01 +0100
Message-ID: <CAJFAV8x2RvN8AoMOHGaGfPBwzowkbOwXdkh3io+hRbe_cSb=cw@mail.gmail.com> (raw)
In-Reply-To: <CALBAE1MBLSg31JjYsMDtzNAj1SmvYtyfGhZ5PiSStmL9wCMuaQ@mail.gmail.com>

On Wed, Oct 28, 2020 at 8:27 AM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> > diff --git a/app/test-eventdev/test_order_common.h b/app/test-eventdev/test_order_common.h
> > index 9e3415e421..d4ad31da46 100644
> > --- a/app/test-eventdev/test_order_common.h
> > +++ b/app/test-eventdev/test_order_common.h
> > @@ -89,9 +89,10 @@ order_process_stage_1(struct test_order *const t,
> >  {
> >         const uint32_t flow = (uintptr_t)ev->mbuf % nb_flows;
> >         /* compare the seqn against expected value */
> > -       if (ev->mbuf->seqn != expected_flow_seq[flow]) {
> > +       if (*rte_event_test_seqn(ev->mbuf) != expected_flow_seq[flow]) {
> >                 evt_err("flow=%x seqn mismatch got=%x expected=%x",
> > -                       flow, ev->mbuf->seqn, expected_flow_seq[flow]);
> > +                       flow, *rte_event_test_seqn(ev->mbuf),
> > +                       expected_flow_seq[flow]);
> >                 t->err = true;
> >                 rte_smp_wmb();
> >         }
>
> # Since rte_event_test_seqn_dynfield_register() is the public API, I
> would like to limit the scope
> only to self test so that  rte_event_test_seqn_dynfield_register()
> need not be exposed.
> Could you have a separate application-specific dynamic field here?
> # Also this patch used in fastpath, better to have offset stored in
> fastpath cache line.
> see http://mails.dpdk.org/archives/dev/2020-October/189588.html

Ack for a test app dynamic field.
On the second comment, I'll wait for Thomas respin.


> > diff --git a/lib/librte_eventdev/version.map b/lib/librte_eventdev/version.map
> > index 8ae8420f9b..e49382ba99 100644
> > --- a/lib/librte_eventdev/version.map
> > +++ b/lib/librte_eventdev/version.map
> > @@ -138,4 +138,6 @@ EXPERIMENTAL {
> >         __rte_eventdev_trace_port_setup;
> >         # added in 20.11
> >         rte_event_pmd_pci_probe_named;
> > +       rte_event_test_seqn_dynfield_offset;
> > +       rte_event_test_seqn_dynfield_register;
>
> Could you change symbol name to rte_event_dev_selftest_seqn_dynfield_offset()
> to limit the scope only to self test. also, it is not required to expose
> rte_event_test_seqn_dynfield_register() in that case.

How about moving this to rte_eventdev_pmd.h and make it a pmd only API?
=> rte_event_pmd_ prefix

I would mark it rte_internal too.


-- 
David Marchand


  reply	other threads:[~2020-10-28  8:55 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 22:13 [dpdk-dev] [PATCH 0/8] remove mbuf seqn David Marchand
2020-10-27 22:13 ` [dpdk-dev] [PATCH 1/8] event/dpaa2: remove dead code David Marchand
2020-10-27 22:13 ` [dpdk-dev] [PATCH 2/8] crypto/scheduler: remove unused internal seqn David Marchand
2020-10-27 22:13 ` [dpdk-dev] [PATCH 3/8] net/ark: remove use of seqn for debug David Marchand
2020-10-28 12:19   ` Ed Czeck
2020-10-27 22:13 ` [dpdk-dev] [PATCH 4/8] reorder: switch sequence number to dynamic mbuf field David Marchand
2020-10-27 22:13 ` [dpdk-dev] [PATCH 5/8] dpaa: switch sequence number to dynamic field David Marchand
2020-10-27 22:13 ` [dpdk-dev] [PATCH 6/8] fslmc: " David Marchand
2020-10-27 22:13 ` [dpdk-dev] [PATCH 7/8] event: " David Marchand
2020-10-27 22:18   ` David Marchand
2020-10-28  7:27   ` Jerin Jacob
2020-10-28  8:55     ` David Marchand [this message]
2020-10-28  9:09       ` Jerin Jacob
2020-10-27 22:13 ` [dpdk-dev] [PATCH 8/8] mbuf: remove seqn field David Marchand
2020-10-28 10:27   ` Andrew Rybchenko
2020-10-28 12:20 ` [dpdk-dev] [PATCH v2 0/9] remove mbuf seqn David Marchand
2020-10-28 12:20   ` [dpdk-dev] [PATCH v2 1/9] event/dpaa2: remove dead code David Marchand
2020-10-31 18:28     ` Nipun Gupta
2020-10-28 12:20   ` [dpdk-dev] [PATCH v2 2/9] crypto/scheduler: remove unused internal seqn David Marchand
2020-10-28 12:20   ` [dpdk-dev] [PATCH v2 3/9] net/ark: remove use of seqn for debug David Marchand
2020-10-28 12:20   ` [dpdk-dev] [PATCH v2 4/9] reorder: switch sequence number to dynamic mbuf field David Marchand
2020-10-28 12:54     ` Andrew Rybchenko
2020-10-28 12:20   ` [dpdk-dev] [PATCH v2 5/9] dpaa: " David Marchand
2020-10-28 12:20   ` [dpdk-dev] [PATCH v2 6/9] fslmc: " David Marchand
2020-10-28 12:20   ` [dpdk-dev] [PATCH v2 7/9] eventdev: " David Marchand
2020-10-28 12:20   ` [dpdk-dev] [PATCH v2 8/9] app/eventdev: " David Marchand
2020-10-28 12:20   ` [dpdk-dev] [PATCH v2 9/9] mbuf: remove seqn field David Marchand
2020-10-31 21:09     ` Thomas Monjalon
2020-10-31 21:11   ` [dpdk-dev] [PATCH v2 0/9] remove mbuf seqn Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8x2RvN8AoMOHGaGfPBwzowkbOwXdkh3io+hRbe_cSb=cw@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=jerinj@marvell.com \
    --cc=jerinjacobk@gmail.com \
    --cc=liang.j.ma@intel.com \
    --cc=mdr@ashroe.eu \
    --cc=nhorman@tuxdriver.com \
    --cc=pbhagavatula@marvell.com \
    --cc=peter.mccarthy@intel.com \
    --cc=timothy.mcdaniel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git