From: David Marchand <david.marchand@redhat.com>
To: Pawel Wodkowski <pawelwod@gmail.com>
Cc: dev <dev@dpdk.org>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] tracepoint: fix compilation with C++
Date: Wed, 5 Aug 2020 10:00:07 +0200 [thread overview]
Message-ID: <CAJFAV8x6TS9rgOLtYz4Ph0mEO7pY9HFkB5rUB9m699Zw45+G6g@mail.gmail.com> (raw)
In-Reply-To: <20200804175138.18543-1-pawelwod@gmail.com>
Hello Pawel,
Thanks for contributing to DPDK.
On Tue, Aug 4, 2020 at 7:52 PM Pawel Wodkowski <pawelwod@gmail.com> wrote:
>
> trace_mem is declared as 'void *' which triggers following error:
> '...invalid conversion from ‘void*’ to ‘__rte_trace_header*’
> [-fpermissive]...'
>
> Fix this by changing void to struct __rte_trace_header
I Cc'd trace maintainers.
For subsequent revisions, you can do directly Cc them by calling the
get-maintainer.sh script like this:
$ git send-email --to dev@dpdk.org --cc-cmd devtools/get-maintainer.sh $patch
On the form of the patch, this patch is missing a signed-off tag,
please have a look at the contribution guidelines:
https://doc.dpdk.org/guides/contributing/patches.html
Do not forget to chain replies using the --in-reply-to option for git
send-email.
This is a fix, so we expect a Fixes: tag in the commitlog.
This tag should point at the original commit that introduced the issue.
Looking at the CI report
http://mails.dpdk.org/archives/test-report/2020-August/147927.html,
you will see that the windows part is missing an update.
$ git grep -wl trace_mem
lib/librte_eal/common/eal_common_trace.c
lib/librte_eal/include/rte_trace_point.h
lib/librte_eal/windows/eal.c
--
David Marchand
next prev parent reply other threads:[~2020-08-05 8:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 17:51 Pawel Wodkowski
2020-08-05 8:00 ` David Marchand [this message]
2020-08-05 9:26 ` Pawel Wodkowski
2020-08-06 6:44 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-08-06 18:44 ` Pawel Wodkowski
2020-08-07 5:54 ` Sunil Kumar Kori
2020-08-10 20:36 ` [dpdk-dev] [PATCH v2] " Pawel Wodkowski
2020-08-11 9:29 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-08-11 13:34 ` Pawel Wodkowski
2020-08-12 6:51 ` Sunil Kumar Kori
2020-08-12 9:51 ` [dpdk-dev] [PATCH v3] trace: " skori
2020-09-11 20:33 ` Chautru, Nicolas
2020-09-17 8:16 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8x6TS9rgOLtYz4Ph0mEO7pY9HFkB5rUB9m699Zw45+G6g@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pawelwod@gmail.com \
--cc=skori@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).