DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: "Johan Källström" <johan.kallstrom@ericsson.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
	 "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: fix ctrl thread affinity with --lcores
Date: Tue, 30 Jul 2019 21:21:38 +0200	[thread overview]
Message-ID: <CAJFAV8x=W2VbHchb40tQ8X2kZzebtTg6sEVJs4fEwfpZAtFPqw@mail.gmail.com> (raw)
In-Reply-To: <HE1PR0701MB2153B6E5EEAD04BE6217794D98DC0@HE1PR0701MB2153.eurprd07.prod.outlook.com>

On Tue, Jul 30, 2019 at 6:32 PM Johan Källström
<johan.kallstrom@ericsson.com> wrote:
>
> Hi, for the online check I referred to the check of "default_set" via the initial thread affinity.
>
> I see that pthread_getaffinity_np returns an already and:ed mask, was under the impression that pthread_getaffinity_np would return the same mask as was set using pthread_setaffinity_np.
> Looking on the implementation I see that it has been implemented on this line (https://github.com/torvalds/linux/blob/master/kernel/sched/core.c#L5242) for the last decade. Don’t know how this is implemented on FreeBSD or Windows.

Afaics on FreeBSD, trying to set an unknown core is rejected with the
cpuset tool.
Not sure at which level the refusal is (cpuset, libc, kernel).


> Below is some example runs without the online cpu check running inside the exclusive cpuset 1-3,19,79 with cpu 79 offline.
> Added a print statements after each consecutive calculation just to verify what the different steps.
>
> Nice that you were able to reproduce the bug, the fix looks good otherwise :) .

Ok, I understand your concern now, but afaiu you confirm that there is
no issue with this patch.

We are really close to -rc3.
Can you send a review or test tag?


Thanks.

--
David Marchand

  reply	other threads:[~2019-07-30 19:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30  9:35 David Marchand
2019-07-30  9:45 ` Jerin Jacob Kollanukkaran
2019-07-30  9:46   ` David Marchand
2019-07-30 11:38 ` Johan Källström
2019-07-30 13:47   ` David Marchand
2019-07-30 16:32     ` Johan Källström
2019-07-30 19:21       ` David Marchand [this message]
2019-07-31  8:12         ` Johan Källström
2019-07-30 15:05 ` [dpdk-dev] [PATCH v2] " David Marchand
2019-07-30 21:12   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8x=W2VbHchb40tQ8X2kZzebtTg6sEVJs4fEwfpZAtFPqw@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=johan.kallstrom@ericsson.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).