DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	 "johan.kallstrom@ericsson.com" <johan.kallstrom@ericsson.com>,
	 "anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
	 "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: fix ctrl thread affinity with --lcores
Date: Tue, 30 Jul 2019 11:46:48 +0200	[thread overview]
Message-ID: <CAJFAV8xLtPkYz+VETjB3E3JeBsMJ=BOqSm9Dq9DDCGFbmWyNbA@mail.gmail.com> (raw)
In-Reply-To: <BYAPR18MB2424E36D06A3BD4DB7F22D5BC8DC0@BYAPR18MB2424.namprd18.prod.outlook.com>

On Tue, Jul 30, 2019 at 11:45 AM Jerin Jacob Kollanukkaran
<jerinj@marvell.com> wrote:
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of David Marchand
> > Sent: Tuesday, July 30, 2019 3:06 PM
> > To: dev@dpdk.org
> > Cc: johan.kallstrom@ericsson.com; anatoly.burakov@intel.com;
> > olivier.matz@6wind.com; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] eal: fix ctrl thread affinity with --lcores
> >
> > When using -l/-c options, each lcore is mapped to a physical cpu in a
> > 1:1 fashion.
> > On the contrary, when using --lcores, each lcore has its own cpuset on which the
> > associated EAL thread runs.
> >
> > To handle those two situations, rely on the per lcore cpuset.
> >
> > Introduced macros to manipulate cpusets in both Linux and FreeBSD.
> >
> > Examples in a 4 cores FreeBSD vm:
> >
> > $ ./build/app/testpmd --master-lcore 1 --lcores '0@(1,3),1@2' \  --no-huge --no-
> > pci -m 512 -- -i --total-num-mbufs=2048
> >
> >   PID    TID COMM                TDNAME              CPU CSID CPU MASK
> > 31733 100155 testpmd             -                     2    1 2
> > 31733 100286 testpmd             eal-intr-thread       0    1 0
> > 31733 100287 testpmd             rte_mp_handle         0    1 0
> > 31733 100288 testpmd             lcore-slave-0         3    1 1,3
> >
> > $ cpuset -l 1,2,3 \
> >  ./build/app/testpmd --master-lcore 1 --lcores '0@(1,3),1@2' \  --no-huge --no-
> > pci -m 512 -- -i --total-num-mbufs=2048
> >
> >   PID    TID COMM                TDNAME              CPU CSID CPU MASK
> > 31757 100139 testpmd             -                     2    2 2
> > 31757 100292 testpmd             eal-intr-thread       2    2 2
> > 31757 100293 testpmd             rte_mp_handle         2    2 2
> > 31757 100294 testpmd             lcore-slave-0         3    2 1,3
> >
> > $ cpuset -l 1,2,3 \
> >  ./build/app/testpmd --master-lcore 1 --lcores '0@1,1@2' \  --no-huge --no-pci -
> > m 512 -- -i --total-num-mbufs=2048
> >
> >   PID    TID COMM                TDNAME              CPU CSID CPU MASK
> > 31776 100166 testpmd             -                     2    2 2
> > 31776 100295 testpmd             eal-intr-thread       3    2 3
> > 31776 100296 testpmd             rte_mp_handle         3    2 3
> > 31776 100297 testpmd             lcore-slave-0         1    2 1
> >
> > Bugzilla ID: 322
> > Fixes: c3568ea37670 ("eal: restrict control threads to startup CPU affinity")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > @@ -25,6 +25,19 @@ extern "C" {
> >  #if defined(__linux__)
>
> [snip]
>
> >  #elif defined(__FreeBSD__)
> >  #include <pthread_np.h>
> >  typedef cpuset_t rte_cpuset_t;
> > @@ -35,6 +48,21 @@ typedef cpuset_t rte_cpuset_t;
> >       CPU_AND(&tmp, src2); \
> >       CPU_COPY(&tmp, dst); \
> >  } while (0)
> > +#define RTE_CPU_OR(dst, src1, src2) do \ { \
> > +     cpuset_t tmp; \
> > +     CPU_COPY(src1, &tmp); \
> > +     CPU_OR(&tmp, src2); \
> > +     CPU_COPY(&tmp, dst); \
> > +} while (0)
> > +#define RTE_CPU_FILL(set) CPU_FILL(set) #define RTE_CPU_NOT(dst, src)
> > +do \ { \
> > +     cpuset_t tmp; \
> > +     CPU_FILL(&tmp); \
> > +     CPU_NAND(&tmp, src); \
> > +     CPU_COPY(&tmp, dst); \
> > +} while (0)
>
> Considering windows eal or a new eal in mind, IMO, it is better
> to move to lib/librte_eal/freebsd/eal/include/rte_os.h
> and it will avoid #ifdef clutter in common code too.
>
>
>


This patch will get backported in 18.11.
I would prefer we do this cleanup later when the windows port needs it.


-- 
David Marchand

  reply	other threads:[~2019-07-30  9:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30  9:35 David Marchand
2019-07-30  9:45 ` Jerin Jacob Kollanukkaran
2019-07-30  9:46   ` David Marchand [this message]
2019-07-30 11:38 ` Johan Källström
2019-07-30 13:47   ` David Marchand
2019-07-30 16:32     ` Johan Källström
2019-07-30 19:21       ` David Marchand
2019-07-31  8:12         ` Johan Källström
2019-07-30 15:05 ` [dpdk-dev] [PATCH v2] " David Marchand
2019-07-30 21:12   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8xLtPkYz+VETjB3E3JeBsMJ=BOqSm9Dq9DDCGFbmWyNbA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=johan.kallstrom@ericsson.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).