DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: roretzla@linux.microsoft.com
Cc: dev@dpdk.org, Ruifeng Wang <ruifeng.wang@arm.com>,
	 David Christensen <drc@linux.vnet.ibm.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	 Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Subject: Re: [PATCH] remove wrappers for GCC < 4.8
Date: Thu, 24 Aug 2023 10:52:04 +0200	[thread overview]
Message-ID: <CAJFAV8xY+2Fv3kViAGLw_5uzGDMhH1TSXaOR9i4DfQcDVNZS3A@mail.gmail.com> (raw)
In-Reply-To: <20230824083034.806773-1-david.marchand@redhat.com>

Hello Tyler,

On Thu, Aug 24, 2023 at 10:30 AM David Marchand
<david.marchand@redhat.com> wrote:
> diff --git a/lib/eal/include/rte_debug.h b/lib/eal/include/rte_debug.h
> index 2c4b94a7c9..74593cd4d4 100644
> --- a/lib/eal/include/rte_debug.h
> +++ b/lib/eal/include/rte_debug.h
> @@ -60,11 +60,7 @@ void rte_dump_stack(void);
>   * documentation.
>   */
>  void __rte_panic(const char *funcname , const char *format, ...)
> -#ifdef __GNUC__
> -#if (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ > 2))
>         __rte_cold
> -#endif
> -#endif

I don't see some wrapping around __rte_cold for MSVC in your series.
Would this patch break MSVC buidlds?

>         __rte_noreturn
>         __rte_format_printf(2, 3);
>


-- 
David Marchand


  reply	other threads:[~2023-08-24  8:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24  8:30 David Marchand
2023-08-24  8:52 ` David Marchand [this message]
2023-08-25 16:14   ` Tyler Retzlaff
2023-08-26  8:33     ` David Marchand
2023-08-24  9:00 ` Bruce Richardson
2023-08-24  9:33 ` [PATCH v2] remove compatibility " David Marchand
2023-08-25  8:37   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8xY+2Fv3kViAGLw_5uzGDMhH1TSXaOR9i4DfQcDVNZS3A@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=drc@linux.vnet.ibm.com \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=roretzla@linux.microsoft.com \
    --cc=ruifeng.wang@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).