From: David Marchand <david.marchand@redhat.com> To: Flavio Leitner <fbl@sysclose.org>, Olivier Matz <olivier.matz@6wind.com> Cc: dev <dev@dpdk.org>, Maxime Coquelin <maxime.coquelin@redhat.com>, Ilya Maximets <i.maximets@ovn.org>, Chenbo Xia <chenbo.xia@intel.com> Subject: Re: [dpdk-dev] [PATCH v2 4/4] vhost: fix offload flags in Rx path Date: Thu, 29 Apr 2021 21:18:17 +0200 Message-ID: <CAJFAV8xZ5etciYaSVMeMzw_529A-i+d4NiOqORGR5WdMyEaKyA@mail.gmail.com> (raw) In-Reply-To: <YIr9Y/AQaj5a7a3/@p50.lan> On Thu, Apr 29, 2021 at 8:39 PM Flavio Leitner <fbl@sysclose.org> wrote: > > - if (l4_hdr && hdr->gso_type != VIRTIO_NET_HDR_GSO_NONE) { > > + /* GSO request, save required information in mbuf */ > > + if (hdr->gso_type != VIRTIO_NET_HDR_GSO_NONE) { > > + /* Check unsupported modes */ > > + if (hdr->gso_size == 0) > > + return -EINVAL; > > + > > switch (hdr->gso_type & ~VIRTIO_NET_HDR_GSO_ECN) { > > case VIRTIO_NET_HDR_GSO_TCPV4: > > case VIRTIO_NET_HDR_GSO_TCPV6: > > - tcp_hdr = l4_hdr; > > - m->ol_flags |= PKT_TX_TCP_SEG; > > - m->tso_segsz = hdr->gso_size; > > - m->l4_len = (tcp_hdr->data_off & 0xf0) >> 2; > > - break; > > case VIRTIO_NET_HDR_GSO_UDP: > > - m->ol_flags |= PKT_TX_UDP_SEG; > > + m->ol_flags |= PKT_RX_LRO | PKT_RX_L4_CKSUM_NONE; > > My understanding of the virtio 1.1 spec is that GSO can be > used independently of CSUM. There is nothing preventing to > send a fully checksummed TSO packet. This forces a superfluous cksum in such a situation. It can be fixed later if needed. The virtio pmd rx side has the same behavior. > Anyways, that's unusual and not the goal of this patch. > > Acked-by: Flavio Leitner <fbl@sysclose.org> Thanks! -- David Marchand
next prev parent reply other threads:[~2021-04-29 19:18 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-01 9:52 [dpdk-dev] [PATCH 0/5] Offload flags fixes David Marchand 2021-04-01 9:52 ` [dpdk-dev] [PATCH 1/5] mbuf: mark old offload flag as deprecated David Marchand 2021-04-07 20:14 ` Flavio Leitner 2021-04-08 7:23 ` Olivier Matz 2021-04-08 8:41 ` David Marchand 2021-04-01 9:52 ` [dpdk-dev] [PATCH 2/5] net/tap: do not touch Tx offload flags David Marchand 2021-04-07 20:15 ` Flavio Leitner 2021-04-08 7:41 ` Olivier Matz 2021-04-08 11:21 ` Flavio Leitner 2021-04-08 12:05 ` Olivier Matz 2021-04-08 12:58 ` Flavio Leitner 2021-04-09 13:30 ` Olivier Matz 2021-04-09 16:55 ` Flavio Leitner 2021-04-28 12:17 ` David Marchand 2021-04-08 12:16 ` Ananyev, Konstantin 2021-04-08 7:53 ` Olivier Matz 2021-04-28 12:12 ` David Marchand 2021-04-01 9:52 ` [dpdk-dev] [PATCH 3/5] net/virtio: " David Marchand 2021-04-13 14:17 ` Maxime Coquelin 2021-04-01 9:52 ` [dpdk-dev] [PATCH 4/5] net/virtio: refactor Tx offload helper David Marchand 2021-04-08 13:05 ` Flavio Leitner 2021-04-09 2:31 ` Ruifeng Wang 2021-04-01 9:52 ` [dpdk-dev] [PATCH 5/5] vhost: fix offload flags in Rx path David Marchand 2021-04-08 8:28 ` Olivier Matz 2021-04-08 18:38 ` Flavio Leitner 2021-04-13 15:27 ` Maxime Coquelin 2021-04-27 17:09 ` David Marchand 2021-04-27 17:19 ` David Marchand 2021-04-29 8:04 ` [dpdk-dev] [PATCH v2 0/4] Offload flags fixes David Marchand 2021-04-29 8:04 ` [dpdk-dev] [PATCH v2 1/4] mbuf: mark old offload flag as deprecated David Marchand 2021-04-29 12:14 ` Lance Richardson 2021-04-29 16:45 ` Ajit Khaparde 2021-04-29 8:04 ` [dpdk-dev] [PATCH v2 2/4] net/virtio: do not touch Tx offload flags David Marchand 2021-04-29 13:51 ` Flavio Leitner 2021-04-29 8:04 ` [dpdk-dev] [PATCH v2 3/4] net/virtio: refactor Tx offload helper David Marchand 2021-04-29 12:59 ` Maxime Coquelin 2021-04-29 8:04 ` [dpdk-dev] [PATCH v2 4/4] vhost: fix offload flags in Rx path David Marchand 2021-04-29 13:30 ` Maxime Coquelin 2021-04-29 13:31 ` Maxime Coquelin 2021-04-29 20:21 ` David Marchand 2021-04-30 8:38 ` Maxime Coquelin 2021-04-29 20:09 ` David Marchand 2021-04-29 18:39 ` Flavio Leitner 2021-04-29 19:18 ` David Marchand [this message] 2021-05-03 13:26 ` [dpdk-dev] [PATCH v3 0/4] Offload flags fixes David Marchand 2021-05-03 13:26 ` [dpdk-dev] [PATCH v3 1/4] mbuf: mark old offload flag as deprecated David Marchand 2021-05-03 14:02 ` Maxime Coquelin 2021-05-03 14:12 ` David Marchand 2021-05-03 13:26 ` [dpdk-dev] [PATCH v3 2/4] net/virtio: do not touch Tx offload flags David Marchand 2021-05-03 13:26 ` [dpdk-dev] [PATCH v3 3/4] net/virtio: refactor Tx offload helper David Marchand 2021-05-03 13:26 ` [dpdk-dev] [PATCH v3 4/4] vhost: fix offload flags in Rx path David Marchand 2021-05-03 15:24 ` [dpdk-dev] [PATCH v3 0/4] Offload flags fixes Maxime Coquelin 2021-05-03 16:21 ` David Marchand 2021-05-03 16:43 ` [dpdk-dev] [PATCH v4 0/3] " David Marchand 2021-05-03 16:43 ` [dpdk-dev] [PATCH v4 1/3] net/virtio: do not touch Tx offload flags David Marchand 2021-05-03 16:43 ` [dpdk-dev] [PATCH v4 2/3] net/virtio: refactor Tx offload helper David Marchand 2021-05-03 16:43 ` [dpdk-dev] [PATCH v4 3/3] vhost: fix offload flags in Rx path David Marchand 2021-05-04 11:07 ` Flavio Leitner 2021-05-08 6:24 ` Wang, Yinan 2021-05-12 3:29 ` Wang, Yinan 2021-05-12 15:20 ` David Marchand 2021-05-13 6:34 ` Wang, Yinan 2021-05-04 8:29 ` [dpdk-dev] [PATCH v4 0/3] Offload flags fixes Maxime Coquelin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJFAV8xZ5etciYaSVMeMzw_529A-i+d4NiOqORGR5WdMyEaKyA@mail.gmail.com \ --to=david.marchand@redhat.com \ --cc=chenbo.xia@intel.com \ --cc=dev@dpdk.org \ --cc=fbl@sysclose.org \ --cc=i.maximets@ovn.org \ --cc=maxime.coquelin@redhat.com \ --cc=olivier.matz@6wind.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git