Re: [dpdk-dev] [PATCH v4 1/1] eal/interrupts: add synchronous wrapper around unregister

[David Marchand <david.marchand@redhat.com>]

On Thu, Feb 18, 2021 at 10:28 PM Renata Saiakhova
<Renata.Saiakhova@ekinops.com> wrote:
>
> Avoid race with unregister interrupt handler if interrupt
> source has some active callbacks at the moment, use wrapper
> around rte_intr_callback_unregister() to check for -EAGAIN
> return value and to loop until rte_intr_callback_unregister()
> succeeds.
>
> Signed-off-by: Renata Saiakhova <Renata.Saiakhova@ekinops.com>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>  drivers/bus/pci/linux/pci_vfio.c        |  2 +-
>  lib/librte_eal/freebsd/eal_interrupts.c | 12 ++++++++++++
>  lib/librte_eal/include/rte_interrupts.h | 25 +++++++++++++++++++++++++
>  lib/librte_eal/linux/eal_interrupts.c   | 12 ++++++++++++
>  lib/librte_eal/version.map              |  1 +
>  5 files changed, 51 insertions(+), 1 deletion(-)

Seeing the description of this function, I'd expect it to be the same
on all OS implementations.
Please, could you respin with Windows update?

[snip]

> diff --git a/lib/librte_eal/version.map b/lib/librte_eal/version.map
> index fce90a112..56caa9cc9 100644
> --- a/lib/librte_eal/version.map
> +++ b/lib/librte_eal/version.map
> @@ -318,6 +318,7 @@ EXPERIMENTAL {
>         rte_fbarray_find_rev_biggest_free;
>         rte_fbarray_find_rev_biggest_used;
>         rte_intr_callback_unregister_pending;
> +       rte_intr_callback_unregister_sync;
>         rte_realloc_socket;
>
>         # added in 19.08
> --
> 2.17.2
>

The new symbol should be with other 21.05 additions.
Thanks.


-- 
David Marchand