From: David Marchand <david.marchand@redhat.com>
To: dev <dev@dpdk.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
David Christensen <drc@linux.vnet.ibm.com>
Subject: Re: [dpdk-dev] [PATCH] config/ppc: fix build with GCC >= 10
Date: Wed, 15 Sep 2021 17:10:12 +0200 [thread overview]
Message-ID: <CAJFAV8yE-kM84u=Ae5p1Lov=Kg-9xqQVqTgWkPxTxeKtyFmEZg@mail.gmail.com> (raw)
In-Reply-To: <YUG4Hv5hXy9NIbq2@bricha3-MOBL.ger.corp.intel.com>
On Wed, Sep 15, 2021 at 11:08 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> On Wed, Sep 15, 2021 at 09:14:34AM +0100, Ferruh Yigit wrote:
> > On 9/15/2021 6:08 AM, David Marchand wrote:
> > > Like for python, multiline statements in meson must either use a
> > > backslash character (explicit continuation) or be enclosed in ()
> > > (implicit continuation).
> > >
> > > python PEP8 recommends the latter [1], and it looks like meson had
> > > an issue with backslash before 0.50 [2].
> > >
> > > 1: https://www.python.org/dev/peps/pep-0008/#multiline-if-statements
> > > 2: https://github.com/mesonbuild/meson/commit/90c9b868b20b
> > >
> > > Fixes: 394407f50c90 ("config/ppc: ignore GCC 11 psabi warnings")
> > >
> > > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2021-09-15 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 5:08 David Marchand
2021-09-15 8:14 ` Ferruh Yigit
2021-09-15 9:08 ` Bruce Richardson
2021-09-15 15:10 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yE-kM84u=Ae5p1Lov=Kg-9xqQVqTgWkPxTxeKtyFmEZg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).