From: David Marchand <david.marchand@redhat.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Wang, YuanX" <yuanx.wang@intel.com>,
"Ding, Xuan" <xuan.ding@intel.com>,
"ferruh.yigit@xilinx.com" <ferruh.yigit@xilinx.com>
Subject: Re: [PATCH 2/4] vhost: restore device information in log messages
Date: Wed, 29 Jun 2022 15:45:02 +0200 [thread overview]
Message-ID: <CAJFAV8yJ6Qt2+7eo7NA+O0v8zx=iTQ08hBv1r9HPeKaqYQJ=SA@mail.gmail.com> (raw)
In-Reply-To: <SN6PR11MB3504B2AC2AEB435C151CFB1A9CBB9@SN6PR11MB3504.namprd11.prod.outlook.com>
On Wed, Jun 29, 2022 at 3:34 PM Xia, Chenbo <chenbo.xia@intel.com> wrote:
>
> Hi David,
>
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Monday, June 27, 2022 5:27 PM
> > To: dev@dpdk.org
> > Cc: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>; Wang,
> > YuanX <yuanx.wang@intel.com>; Ding, Xuan <xuan.ding@intel.com>
> > Subject: [PATCH 2/4] vhost: restore device information in log messages
> >
> > device information in the log messages was dropped.
> >
> > Fixes: 52ade97e3641 ("vhost: fix physical address mapping")
>
> Should we add cc-stable tag in this case as it's 22.03 commit?
> Last time when I asked Ferruh, he said although now we don't maintain
> non-LTS release, we should still add this tag. Not sure this changed
> or not.
No objection for leaks and other important fixes.
Here, this patch is only fixing some log messages, so I did not see the need.
In any case, I am fine with both options and this can be added when
the patch is applied by sub-tree maintainer.
>
> For the patch:
>
> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
Thanks Chenbo!
--
David Marchand
next prev parent reply other threads:[~2022-06-29 13:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 9:27 [PATCH 0/4] Vhost logs fixes and improvement David Marchand
2022-06-27 9:27 ` [PATCH 1/4] vhost: add some trailing newline in log messages David Marchand
2022-06-29 13:28 ` Xia, Chenbo
2022-06-27 9:27 ` [PATCH 2/4] vhost: restore device information " David Marchand
2022-06-29 13:34 ` Xia, Chenbo
2022-06-29 13:45 ` David Marchand [this message]
2022-06-29 13:49 ` Xia, Chenbo
2022-06-27 9:27 ` [PATCH 3/4] vhost: improve some datapath " David Marchand
2022-06-30 16:07 ` Maxime Coquelin
2022-06-27 9:27 ` [PATCH 4/4] vhost: prefix logs with context David Marchand
2022-06-30 16:13 ` Maxime Coquelin
2022-07-01 7:13 ` David Marchand
2022-07-01 7:56 ` Maxime Coquelin
2022-07-01 7:55 ` [PATCH v2 0/4] Vhost logs fixes and improvement David Marchand
2022-07-01 7:55 ` [PATCH v2 1/4] vhost: add some trailing newline in log messages David Marchand
2022-07-01 7:55 ` [PATCH v2 2/4] vhost: restore device information " David Marchand
2022-07-01 7:55 ` [PATCH v2 3/4] vhost: improve some datapath " David Marchand
2022-07-01 7:55 ` [PATCH v2 4/4] vhost: prefix logs with context David Marchand
2022-07-01 8:00 ` Maxime Coquelin
2022-07-01 13:20 ` [PATCH v3] " David Marchand
2022-07-01 14:00 ` Maxime Coquelin
2022-07-01 14:00 ` [PATCH v2 0/4] Vhost logs fixes and improvement Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yJ6Qt2+7eo7NA+O0v8zx=iTQ08hBv1r9HPeKaqYQJ=SA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=maxime.coquelin@redhat.com \
--cc=xuan.ding@intel.com \
--cc=yuanx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).