DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Harjot Singh <Harjot.Singh@arm.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	Yipeng Wang <yipeng1.wang@intel.com>,
	Sameh Gobriel <sameh.gobriel@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	 Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
	dev@dpdk.org, nd@arm.com,  Nathan Brown <nathan.brown@arm.com>,
	Feifei Wang <feifei.wang2@arm.com>,
	 Jieqiang Wang <jieqiang.wang@arm.com>,
	Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Subject: Re: [PATCH 1/1] hash: add SVE support for bulk key lookup
Date: Fri, 29 Sep 2023 17:36:46 +0200	[thread overview]
Message-ID: <CAJFAV8yP2A8cAsdbEJHhPE9Qe5YnZdM564rkFA19aka+1p_YbQ@mail.gmail.com> (raw)
In-Reply-To: <20230817212417.3637080-2-Harjot.Singh@arm.com>

On Thu, Aug 17, 2023 at 11:24 PM Harjot Singh <Harjot.Singh@arm.com> wrote:
>
> From: Harjot Singh <harjot.singh@arm.com>
>
> - Implemented Vector Length Agnostic SVE code for comparing signatures
> in bulk lookup.
> - Added Defines in code for SVE code support.
> - New Optimised SVE code is 1-2 CPU cycle slower than NEON for N2
> processor.
>
> Performance Numbers from hash_perf_autotest :
>
> Elements in Primary or Secondary Location
>
> Results (in CPU cycles/operation)
> -----------------------------------
>  Operations without data
>
> Without pre-computed hash values
>
> Keysize     Add/Lookup/Lookup_bulk
>             Neon         SVE
> 4           93/71/26     93/71/27
> 8           93/70/26     93/70/27
> 9           94/74/27     94/74/28
> 13          100/80/31    100/79/32
> 16          100/78/30    100/78/31
> 32          109/110/38   108/110/39
>
> With pre-computed hash values
>
> Keysize     Add/Lookup/Lookup_bulk
>             Neon         SVE
> 4           83/58/27     83/58/29
> 8           83/57/27     83/57/28
> 9           83/60/28     83/60/29
> 13          84/60/28     83/60/29
> 16          83/58/27     83/58/29
> 32          84/68/31     84/68/32
>
> Signed-off-by: Harjot Singh <harjot.singh@arm.com>
> Reviewed-by: Nathan Brown <nathan.brown@arm.com>
> Reviewed-by: Feifei Wang <feifei.wang2@arm.com>
> Reviewed-by: Jieqiang Wang <jieqiang.wang@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Thanks for the patch, please update the release notes.


-- 
David Marchand


      reply	other threads:[~2023-09-29 15:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17 21:24 [PATCH 0/1] " Harjot Singh
2023-08-17 21:24 ` [PATCH 1/1] " Harjot Singh
2023-09-29 15:36   ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8yP2A8cAsdbEJHhPE9Qe5YnZdM564rkFA19aka+1p_YbQ@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=Harjot.Singh@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=feifei.wang2@arm.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=jieqiang.wang@arm.com \
    --cc=nathan.brown@arm.com \
    --cc=nd@arm.com \
    --cc=sameh.gobriel@intel.com \
    --cc=thomas@monjalon.net \
    --cc=vladimir.medvedkin@intel.com \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).