Re: [PATCH 1/1] build: increase minimum meson version to 0.53

[David Marchand <david.marchand@redhat.com>]

On Fri, Oct 7, 2022 at 5:34 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Fri, Oct 07, 2022 at 05:26:05PM +0200, David Marchand wrote:
> > On Fri, Oct 7, 2022 at 4:11 PM Bruce Richardson
> > <bruce.richardson@intel.com> wrote:
> > > > - We have an issue with mingw cross compilation.
> > > > https://github.com/ovsrobot/dpdk/actions/runs/3039251235/jobs/4893964186
> > > >
> > > > + meson build --werror --cross-file config/x86/cross-mingw
> > > > -Dexamples=helloworld -Dplatform=generic --default-library=static
> > > > --buildtype=debugoptimized -Dcheck_includes=true
> > > > The Meson build system
> > > > Version: 0.53.0
> > > > Source dir: /home/runner/work/dpdk/dpdk
> > > > Build dir: /home/runner/work/dpdk/dpdk/build
> > > > Build type: cross build
> > > > Program cat found: YES (/usr/bin/cat)
> > > > Project name: DPDK
> > > > Project version: 22.11.0-rc0
> > > > C compiler for the build machine: ccache gcc (gcc 9.4.0 "gcc (Ubuntu
> > > > 9.4.0-1ubuntu1~20.04.1) 9.4.0")
> > > > C linker for the build machine: gcc GNU ld.bfd 2.34
> > > >
> > > > meson.build:4:0: ERROR: Unable to determine dynamic linker
> > > >
> > > >
> > > > - I reproduced locally, it looks like meson is trying to pass some
> > > > -fuse-ld option that is not understood.
> > > > 4577  write(2, "x86_64-w64-mingw32-gcc: error: unrecognized command
> > > > line option \342\200\230-fuse-ld=x86_64-w64-mingw32-ld\342\200\231\n",
> > > > 101) = 101
> > > >
> > > >
> > > > - Upgrading to 0.53.1, I don't see the issue anymore for mingw, so I
> > > > pushed a branch in GHA to get a status for other targets.
> > > > https://github.com/david-marchand/dpdk/actions/runs/3205007946
> > > >
> > > So minimum should be 0.53.1 rather than 0.53 then?
> > >
> >
> > - That's what my test shows.
> > Fyi, 0.53.2 works too.
> >
> As latest point release of 0.53 that is probably better choice.
>
> >
> > - With 0.53, it seems the meaning of the ld variable (in meson config
> > file) changed.
> > I am unclear though if our current configs still make sense.
> >
> Do you want more time to examine this, or shall I respin this patch with
> 0.53.2 as minimum version?

https://github.com/mesonbuild/meson/issues/6442
https://github.com/mesonbuild/meson/pull/6457/commits/8e7a7c36b579c11dd389fcb1152a4e8ead8b8782

I understand that the ld variable meaning has been restored, so
nothing to change for us.

Please respin to 0.53.2, with a note about this issue for posterity.

Thanks.


-- 
David Marchand