From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix compiler warning for incorrect include
Date: Tue, 23 Jul 2019 20:53:01 +0200 [thread overview]
Message-ID: <CAJFAV8ys8qC5d-f8qrvs3N5AiBWnEhyfyMRXiB2hAbBYXjmqFw@mail.gmail.com> (raw)
In-Reply-To: <20190723162648.15217-1-bruce.richardson@intel.com>
On Tue, Jul 23, 2019 at 6:27 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> Some builds with clang report an error because '<>' rather than '""' were
> used for including the ioat spec header file.
>
> Target: x86_64-native-bsdapp-clang
> 22:10: error: 'rte_ioat_spec.h' file not found with <angled> include; use "quotes" instead
> #include <rte_ioat_spec.h>
> ^~~~~~~~~~~~~~~~~
> "rte_ioat_spec.h"
> 1 error generated.
>
> Since this file should always be in the same directory as the main header,
> we can safely change the include line to fix this error.
>
> Fixes: abff4333ec20 ("raw/ioat: create device on probe and destroy on release")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Still a bit skeptical at why we did not see this on linux..
But this can't hurt and hopefully it fixes the issue :-)
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
prev parent reply other threads:[~2019-07-23 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 16:26 Bruce Richardson
2019-07-23 18:51 ` Thomas Monjalon
2019-07-23 18:53 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8ys8qC5d-f8qrvs3N5AiBWnEhyfyMRXiB2hAbBYXjmqFw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).