[dpdk-dev] [PATCH] raw/ioat: fix compiler warning for incorrect include

[dpdk-dev] [PATCH] raw/ioat: fix compiler warning for incorrect include

[Bruce Richardson]

Some builds with clang report an error because '<>' rather than '""' were
used for including the ioat spec header file.

  Target: x86_64-native-bsdapp-clang
  22:10: error: 'rte_ioat_spec.h' file not found with <angled> include; use "quotes" instead
  #include <rte_ioat_spec.h>
           ^~~~~~~~~~~~~~~~~
           "rte_ioat_spec.h"
  1 error generated.

Since this file should always be in the same directory as the main header,
we can safely change the include line to fix this error.

Fixes: abff4333ec20 ("raw/ioat: create device on probe and destroy on release")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/raw/ioat/rte_ioat_rawdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/raw/ioat/rte_ioat_rawdev.h b/drivers/raw/ioat/rte_ioat_rawdev.h
index 7a89632e7..4b271f174 100644
--- a/drivers/raw/ioat/rte_ioat_rawdev.h
+++ b/drivers/raw/ioat/rte_ioat_rawdev.h
@@ -19,7 +19,7 @@
 #include <rte_memory.h>
 #include <rte_memzone.h>
 #include <rte_prefetch.h>
-#include <rte_ioat_spec.h>
+#include "rte_ioat_spec.h"
 
 /** Name of the device driver */
 #define IOAT_PMD_RAWDEV_NAME rawdev_ioat
-- 
2.21.0

Re: [dpdk-dev] [PATCH] raw/ioat: fix compiler warning for incorrect include

[Thomas Monjalon]

23/07/2019 18:26, Bruce Richardson:
> Some builds with clang report an error because '<>' rather than '""' were
> used for including the ioat spec header file.
> 
>   Target: x86_64-native-bsdapp-clang
>   22:10: error: 'rte_ioat_spec.h' file not found with <angled> include; use "quotes" instead
>   #include <rte_ioat_spec.h>
>            ^~~~~~~~~~~~~~~~~
>            "rte_ioat_spec.h"
>   1 error generated.
> 
> Since this file should always be in the same directory as the main header,
> we can safely change the include line to fix this error.
> 
> Fixes: abff4333ec20 ("raw/ioat: create device on probe and destroy on release")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

Re: [dpdk-dev] [PATCH] raw/ioat: fix compiler warning for incorrect include

[David Marchand]

On Tue, Jul 23, 2019 at 6:27 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> Some builds with clang report an error because '<>' rather than '""' were
> used for including the ioat spec header file.
>
>   Target: x86_64-native-bsdapp-clang
>   22:10: error: 'rte_ioat_spec.h' file not found with <angled> include; use "quotes" instead
>   #include <rte_ioat_spec.h>
>            ^~~~~~~~~~~~~~~~~
>            "rte_ioat_spec.h"
>   1 error generated.
>
> Since this file should always be in the same directory as the main header,
> we can safely change the include line to fix this error.
>
> Fixes: abff4333ec20 ("raw/ioat: create device on probe and destroy on release")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Still a bit skeptical at why we did not see this on linux..
But this can't hurt and hopefully it fixes the issue :-)

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand