From: David Marchand <david.marchand@redhat.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
Cc: dev@dpdk.org, reshma.pattan@intel.com, "Yigit,
Ferruh" <ferruh.yigit@intel.com>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: fix core number validation
Date: Fri, 21 Dec 2018 10:28:27 +0100 [thread overview]
Message-ID: <CAJFAV8yt_m=G=paKxCrAU3HkCScY4fRm1oigqn=cgw-2q-4kKQ@mail.gmail.com> (raw)
In-Reply-To: <36ca3933-842c-8e74-ab36-c3f6809beaaa@intel.com>
On Fri, Dec 21, 2018 at 10:19 AM Burakov, Anatoly <anatoly.burakov@intel.com>
wrote:
> On 21-Dec-18 8:27 AM, David Marchand wrote:
> > Since you have identified a potential crash, can you give an example of
> > such a crash ?
> > Besides, we have tests that check arguments, so an update of the test
> would
> > be nice.
>
> I believe these lcore numbers are used to index the lcore list later,
> which would cause out-of-bounds access, which may or may not cause a
> crash, depending on how lucky you get.
>
Sure, that and the fact that my testpmd was doing nothing with them :-).
Anyway, the unit tests missed this case, so we need an update.
And the more I look at those string parsing, the more I think that the
service cores parsing has the same issue (copy/paste yay ;-)).
--
David Marchand
next prev parent reply other threads:[~2018-12-21 9:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 10:00 Hari Kumar Vemula
2018-12-21 8:27 ` David Marchand
2018-12-21 9:19 ` Burakov, Anatoly
2018-12-21 9:28 ` David Marchand [this message]
2019-01-02 12:47 ` Vemula, Hari KumarX
2019-01-02 14:23 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yt_m=G=paKxCrAU3HkCScY4fRm1oigqn=cgw-2q-4kKQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hari.kumarx.vemula@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).