DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>, Harman Kalra <hkalra@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2] eal/interrupts: add function to allow interruptible epoll
Date: Mon, 14 Sep 2020 10:56:33 +0200	[thread overview]
Message-ID: <CAJFAV8ywa3V6uSPY-NduMngQCt7v6w8am4iRByXkVN1N=Gg8Yw@mail.gmail.com> (raw)
In-Reply-To: <20200903232822.19167-1-stephen@networkplumber.org>

On Fri, Sep 4, 2020 at 1:28 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The existing definition of rte_epoll_wait retries if interrupted
> by a signal. This behavior makes it hard to use rte_epoll_wait
> for applications that want to use signals do do things like
> exit polling loop and shutdown.
>
> Since changing existing semantic might break applications, add
> a new rte_epoll_wait_interruptible() function that does the
> same thing as rte_epoll_wait but will return -1 and errno of EINTR
> if it receives a signal.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Reviewed-by: Harman Kalra <hkalra@marvell.com>

You will certainly argue that the existing function had no unit test
but we want to fix this at some point.
Can a unit test be added?


Thanks.

-- 
David Marchand


  reply	other threads:[~2020-09-14  8:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24 17:20 [dpdk-dev] [PATCH] " Stephen Hemminger
2020-07-14  5:41 ` Stephen Hemminger
2020-07-15 15:39   ` Harman Kalra
2020-07-14 19:50 ` Honnappa Nagarahalli
2020-09-03 23:28 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2020-09-14  8:56   ` David Marchand [this message]
2020-09-14 16:39     ` Stephen Hemminger
2020-10-19 10:15   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8ywa3V6uSPY-NduMngQCt7v6w8am4iRByXkVN1N=Gg8Yw@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).