From: David Marchand <david.marchand@redhat.com>
To: "Wu, WenxuanX" <wenxuanx.wu@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"stable@dpdk.org" <stable@dpdk.org>,
Ferruh Yigit <ferruh.yigit@xilinx.com>
Subject: Re: [PATCH] ice/base: fix gcc 12 warning stringop-overflow
Date: Thu, 23 Jun 2022 09:42:56 +0200 [thread overview]
Message-ID: <CAJFAV8zuF9iL1OD9BcP_riERY0OTrTZs9ePZs7gTzN1Wq4EtSg@mail.gmail.com> (raw)
In-Reply-To: <MW3PR11MB4665424AD328FAE5C3685D4DE5B09@MW3PR11MB4665.namprd11.prod.outlook.com>
On Mon, Jun 20, 2022 at 7:06 AM Wu, WenxuanX <wenxuanx.wu@intel.com> wrote:
> > > > diff --git a/drivers/net/ice/base/ice_protocol_type.h
> > > > b/drivers/net/ice/base/ice_protocol_type.h
> > > > index 0e6e5990be..cfe3b62630 100644
> > > > --- a/drivers/net/ice/base/ice_protocol_type.h
> > > > +++ b/drivers/net/ice/base/ice_protocol_type.h
> > > > @@ -421,7 +421,7 @@ struct ice_recp_grp_entry { #define
> > > > ICE_INVAL_CHAIN_IND 0xFF
> > > > u16 rid;
> > > > u8 chain_idx;
> > > > - u16 fv_idx[ICE_NUM_WORDS_RECIPE];
> > > > + u8 fv_idx[ICE_NUM_WORDS_RECIPE];
> > >
> > > If you change the data type from u16 to u8 for the FV index, you'd
> > > better also change the type of all the symbols to store the same
> > > thing. e.g. the parameter "fv_idx" of ice_find_prot_off.
> > > So, what's exactly the issue that GCC 12 reported? can we fix it from
> > > the other side without changing a type in the base code?
> change from u8 lkup_indx[5] to u16 lkup_indx[5] can also resolve this issue.
Any update?
Thanks.
--
David Marchand
next prev parent reply other threads:[~2022-06-23 7:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 10:33 wenxuanx.wu
2022-06-16 14:29 ` David Marchand
2022-06-17 1:29 ` Wu, WenxuanX
2022-06-17 5:04 ` David Marchand
2022-06-19 12:34 ` Zhang, Qi Z
2022-06-20 1:38 ` Wu, WenxuanX
2022-06-20 5:06 ` Wu, WenxuanX
2022-06-23 7:42 ` David Marchand [this message]
2022-06-23 9:01 ` [PATCH v2] net/ice/base: " wenxuanx.wu
2022-06-23 9:21 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zuF9iL1OD9BcP_riERY0OTrTZs9ePZs7gTzN1Wq4EtSg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=wenxuanx.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).