* Re: [dpdk-dev] [PATCH 1/1] ena: fix SIGFPE with 0 rx queues [not found] <20180625134046.12448-1-daria.kolistratova@intel.com> @ 2018-06-26 7:29 ` Michał Krawczyk 2018-06-26 17:38 ` [dpdk-dev] [PATCH v2 " Ferruh Yigit 1 sibling, 0 replies; 6+ messages in thread From: Michał Krawczyk @ 2018-06-26 7:29 UTC (permalink / raw) To: Daria Kolistratova Cc: Ferruh Yigit, Marcin Wojtas, Tzalik, Guy, Schmeilin, Evgeny, dev Hi Daria, please see my comments below and answer on them or apply fix and send 2nd version of the patch. You can do that by adding -v2 flag to git format-patch command. Please also sent the new version in response to this email. You can do that by adding --in-reply-to 'msgid' to git send-email. The message ID can be read from the raw version of the email. Thanks, Michal 2018-06-25 15:40 GMT+02:00 Daria Kolistratova <daria.kolistratova@intel.com>: > When he number of rx queues is 0 Please fix the typo (' he' -> 'the'). Please also add information that it happens when the application is also requesting ETH_MQ_RX_RSS_FLAG in the rte_dev->data->dev_conf.rxmode.mq_mode. > (what can be when application does not receive) > failed with SIGFPE. > Fixed adding zero check before division. > > Signed-off-by: Daria Kolistratova <daria.kolistratova@intel.com> > --- > drivers/net/ena/ena_ethdev.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > mode change 100644 => 100755 drivers/net/ena/ena_ethdev.c > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > old mode 100644 > new mode 100755 > index 9ae73e331..89004c903 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -684,7 +684,11 @@ static int ena_rss_init_default(struct ena_adapter *adapter) > } > > for (i = 0; i < ENA_RX_RSS_TABLE_SIZE; i++) { > - val = i % nb_rx_queues; > + if (nb_rx_queues != 0) > + val = i % nb_rx_queues; > + else > + val = 0; > + This change is not needed if you are adding the below change. This function should not be called if the nb_rx_queues == 0, so there is no need to perform additional check. > rc = ena_com_indirect_table_fill_entry(ena_dev, i, > ENA_IO_RXQ_IDX(val)); > if (unlikely(rc && (rc != ENA_COM_UNSUPPORTED))) { > @@ -1052,7 +1056,7 @@ static int ena_start(struct rte_eth_dev *dev) > return rc; > > if (adapter->rte_dev->data->dev_conf.rxmode.mq_mode & > - ETH_MQ_RX_RSS_FLAG) { > + ETH_MQ_RX_RSS_FLAG && adapter->rte_dev->data->nb_rx_queues > 0) { > rc = ena_rss_init_default(adapter); > if (rc) > return rc; > -- > 2.14.4 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2 1/1] ena: fix SIGFPE with 0 rx queues [not found] <20180625134046.12448-1-daria.kolistratova@intel.com> 2018-06-26 7:29 ` [dpdk-dev] [PATCH 1/1] ena: fix SIGFPE with 0 rx queues Michał Krawczyk @ 2018-06-26 17:38 ` Ferruh Yigit 2018-06-26 11:15 ` Michał Krawczyk 2018-06-26 16:53 ` Ferruh Yigit 1 sibling, 2 replies; 6+ messages in thread From: Ferruh Yigit @ 2018-06-26 17:38 UTC (permalink / raw) To: ferruh.yigit, mk, mw, gtzalik, evgenys; +Cc: Daria Kolistratova, dev From: Daria Kolistratova <daria.kolistratova@intel.com> When the number of rx queues is 0 (what can be when application does not receive) failed with SIGFPE. It happens when the application is also requesting ETH_MQ_RX_RSS_FLAG in the rte_dev->data->dev_conf.rxmode.mq_mode. Fixed adding zero rx queues check. Signed-off-by: Daria Kolistratova <daria.kolistratova@intel.com> --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 9ae73e331..3249b9d92 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1052,7 +1052,7 @@ static int ena_start(struct rte_eth_dev *dev) return rc; if (adapter->rte_dev->data->dev_conf.rxmode.mq_mode & - ETH_MQ_RX_RSS_FLAG) { + ETH_MQ_RX_RSS_FLAG && adapter->rte_dev->data->nb_rx_queues > 0) { rc = ena_rss_init_default(adapter); if (rc) return rc; -- 2.14.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/1] ena: fix SIGFPE with 0 rx queues 2018-06-26 17:38 ` [dpdk-dev] [PATCH v2 " Ferruh Yigit @ 2018-06-26 11:15 ` Michał Krawczyk 2018-06-26 16:53 ` Ferruh Yigit 1 sibling, 0 replies; 6+ messages in thread From: Michał Krawczyk @ 2018-06-26 11:15 UTC (permalink / raw) To: Daria Kolistratova Cc: Ferruh Yigit, Marcin Wojtas, Tzalik, Guy, Schmeilin, Evgeny, dev 2018-06-26 13:07 GMT+02:00 Daria Kolistratova <daria.kolistratova@intel.com>: > When the number of rx queues is 0 > (what can be when application does not receive) > failed with SIGFPE. It happens when the application > is also requesting ETH_MQ_RX_RSS_FLAG in the > rte_dev->data->dev_conf.rxmode.mq_mode. > Fixed adding zero rx queues check. > > Signed-off-by: Daria Kolistratova <daria.kolistratova@intel.com> Acked-by: Michal Krawczyk <mk@semihalf.com> > --- > drivers/net/ena/ena_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 9ae73e331..3249b9d92 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -1052,7 +1052,7 @@ static int ena_start(struct rte_eth_dev *dev) > return rc; > > if (adapter->rte_dev->data->dev_conf.rxmode.mq_mode & > - ETH_MQ_RX_RSS_FLAG) { > + ETH_MQ_RX_RSS_FLAG && adapter->rte_dev->data->nb_rx_queues > 0) { > rc = ena_rss_init_default(adapter); > if (rc) > return rc; > -- > 2.14.4 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/1] ena: fix SIGFPE with 0 rx queues 2018-06-26 17:38 ` [dpdk-dev] [PATCH v2 " Ferruh Yigit 2018-06-26 11:15 ` Michał Krawczyk @ 2018-06-26 16:53 ` Ferruh Yigit 2018-06-27 8:36 ` Michał Krawczyk 1 sibling, 1 reply; 6+ messages in thread From: Ferruh Yigit @ 2018-06-26 16:53 UTC (permalink / raw) To: mk, mw, gtzalik, evgenys; +Cc: Daria Kolistratova, dev On 6/26/2018 6:38 PM, Ferruh Yigit wrote: > From: Daria Kolistratova <daria.kolistratova@intel.com> I re-send the Daria's patch, somehow it didn't appeared in mail list and patchwork. > > When the number of rx queues is 0 > (what can be when application does not receive) > failed with SIGFPE. It happens when the application > is also requesting ETH_MQ_RX_RSS_FLAG in the > rte_dev->data->dev_conf.rxmode.mq_mode. > Fixed adding zero rx queues check. > > Signed-off-by: Daria Kolistratova <daria.kolistratova@intel.com> > --- > drivers/net/ena/ena_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 9ae73e331..3249b9d92 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -1052,7 +1052,7 @@ static int ena_start(struct rte_eth_dev *dev) > return rc; > > if (adapter->rte_dev->data->dev_conf.rxmode.mq_mode & > - ETH_MQ_RX_RSS_FLAG) { > + ETH_MQ_RX_RSS_FLAG && adapter->rte_dev->data->nb_rx_queues > 0) { > rc = ena_rss_init_default(adapter); > if (rc) > return rc; > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/1] ena: fix SIGFPE with 0 rx queues 2018-06-26 16:53 ` Ferruh Yigit @ 2018-06-27 8:36 ` Michał Krawczyk 2018-06-27 13:22 ` Ferruh Yigit 0 siblings, 1 reply; 6+ messages in thread From: Michał Krawczyk @ 2018-06-27 8:36 UTC (permalink / raw) To: Ferruh Yigit Cc: Marcin Wojtas, Tzalik, Guy, Schmeilin, Evgeny, Daria Kolistratova, dev 2018-06-26 18:53 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>: > On 6/26/2018 6:38 PM, Ferruh Yigit wrote: >> From: Daria Kolistratova <daria.kolistratova@intel.com> > > I re-send the Daria's patch, somehow it didn't appeared in mail list and patchwork. > >> >> When the number of rx queues is 0 >> (what can be when application does not receive) >> failed with SIGFPE. It happens when the application >> is also requesting ETH_MQ_RX_RSS_FLAG in the >> rte_dev->data->dev_conf.rxmode.mq_mode. >> Fixed adding zero rx queues check. >> >> Signed-off-by: Daria Kolistratova <daria.kolistratova@intel.com> Acked-by: Michal Krawczyk <mk@semihalf.com> >> --- >> drivers/net/ena/ena_ethdev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c >> index 9ae73e331..3249b9d92 100644 >> --- a/drivers/net/ena/ena_ethdev.c >> +++ b/drivers/net/ena/ena_ethdev.c >> @@ -1052,7 +1052,7 @@ static int ena_start(struct rte_eth_dev *dev) >> return rc; >> >> if (adapter->rte_dev->data->dev_conf.rxmode.mq_mode & >> - ETH_MQ_RX_RSS_FLAG) { >> + ETH_MQ_RX_RSS_FLAG && adapter->rte_dev->data->nb_rx_queues > 0) { >> rc = ena_rss_init_default(adapter); >> if (rc) >> return rc; >> > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/1] ena: fix SIGFPE with 0 rx queues 2018-06-27 8:36 ` Michał Krawczyk @ 2018-06-27 13:22 ` Ferruh Yigit 0 siblings, 0 replies; 6+ messages in thread From: Ferruh Yigit @ 2018-06-27 13:22 UTC (permalink / raw) To: Michał Krawczyk Cc: Marcin Wojtas, Tzalik, Guy, Schmeilin, Evgeny, Daria Kolistratova, dev On 6/27/2018 9:36 AM, Michał Krawczyk wrote: > 2018-06-26 18:53 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>: >> On 6/26/2018 6:38 PM, Ferruh Yigit wrote: >>> From: Daria Kolistratova <daria.kolistratova@intel.com> >> >> I re-send the Daria's patch, somehow it didn't appeared in mail list and patchwork. >> >>> >>> When the number of rx queues is 0 >>> (what can be when application does not receive) >>> failed with SIGFPE. It happens when the application >>> is also requesting ETH_MQ_RX_RSS_FLAG in the >>> rte_dev->data->dev_conf.rxmode.mq_mode. >>> Fixed adding zero rx queues check. >>> >>> Signed-off-by: Daria Kolistratova <daria.kolistratova@intel.com> > > Acked-by: Michal Krawczyk <mk@semihalf.com> Applied to dpdk-next-net/master, thanks. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-06-27 13:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180625134046.12448-1-daria.kolistratova@intel.com>
2018-06-26 7:29 ` [dpdk-dev] [PATCH 1/1] ena: fix SIGFPE with 0 rx queues Michał Krawczyk
2018-06-26 17:38 ` [dpdk-dev] [PATCH v2 " Ferruh Yigit
2018-06-26 11:15 ` Michał Krawczyk
2018-06-26 16:53 ` Ferruh Yigit
2018-06-27 8:36 ` Michał Krawczyk
2018-06-27 13:22 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).