From: Arnon Warshavsky <arnon@qwilt.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
jerin.jacob@caviumnetworks.com,
Bruce Richardson <bruce.richardson@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Arnon Warshavsky <arnon@qwilt.com>
Subject: Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances
Date: Tue, 24 Apr 2018 09:44:35 +0300 [thread overview]
Message-ID: <CAKy9EB1c=ZU=VMurOzwuaZZWTfQQtSkVMVSSeFXUWDPFhQJRkw@mail.gmail.com> (raw)
In-Reply-To: <1524552123-31378-1-git-send-email-arnon@qwilt.com>
please ignore this patchset.
The v6 formatting is messed up. resending
Sorry for the mess
On Tue, Apr 24, 2018 at 9:41 AM, Arnon Warshavsky <arnon@qwilt.com> wrote:
> The purpose of this patch series is to cleanup the library code
> from paths that end up aborting the process,
> and move to checking error values, in order to allow the running process
> perform an orderly teardown or other mitigation of the event.
>
> This patch modifies the majority of rte_panic calls
> under lib and drivers, and replaces them with a log message
> and an error return code according to context,
> that can be propagated up the call stack.
>
> - Focus was given to the dpdk initialization path
> - Some of the panic calls within drivers were left in place where
> the call is from within an interrupt or calls that are
> on the data path,where there is no simple applicative
> route to propagate the error to temination.
> These should be handled by the driver maintainers..
> - local void functions with no api were changed to retrun a value
> where needed
> - No change took place in example and test files
> - No change took place for debug assertions calling panic
> - A new function was added to devtools/checkpatches.sh
> in order to prevent new additions of calls to rte_panic
> under lib and drivers.
>
> Keep calm and don't panic
>
> ---
>
> v2:
> - reformat error messages so that literal string are in the same line
> - fix typo in commit message
> - add new return code to doxigen of rte_memzone_free()
>
> v3:
> - submit all 13 patches changed and unchanged in the same patchset
>
> v4:
> - remove 2 patches that are no more relevant
> - fix split literal string in error message
> - change return value -1 to enum
> - split value and success code in a static function
>
> v5:
> - reword commit messages
> - revert thread related instances back to panicing
> - handle file descriptors with state to reset after eal init failure
> in case re initialization takes place
>
> v6:
> - Use pmd log macro rather than rte_log
>
>
>
> Arnon Warshavsky (11):
> crypto/dpaa: replace rte_panic instances in crypto/dpaa driver
> bond: replace rte_panic instances in bonding driver
> e1000: replace rte_panic instances in e1000 driver
> ixgbe: replace rte_panic instances in ixgbe driver
> eal: replace rte_panic instances in eventdev
> kni: replace rte_panic instances in kni
> eal: replace rte_panic instances in hugepage_info
> eal: replace rte_panic instances in interrupts thread
> eal: replace rte_panic instances in ethdev
> eal: replace rte_panic instances in init sequence
> devtools: prevent new instances of rte_panic and rte_exit
>
> devtools/checkpatches.sh | 95
> +++++++++++++++++++++-
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +-
> drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +-
> drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++++---
> drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2 +-
> drivers/net/bonding/rte_eth_bond_api.c | 22 +++--
> drivers/net/bonding/rte_eth_bond_pmd.c | 9 ++-
> drivers/net/bonding/rte_eth_bond_private.h | 2 +-
> drivers/net/e1000/e1000_ethdev.h | 2 +-
> drivers/net/e1000/igb_ethdev.c | 4 +-
> drivers/net/e1000/igb_pf.c | 15 ++--
> drivers/net/ixgbe/ixgbe_ethdev.c | 6 +-
> drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
> drivers/net/ixgbe/ixgbe_pf.c | 15 ++--
> lib/librte_eal/bsdapp/eal/eal.c | 70 +++++++++++-----
> lib/librte_eal/linuxapp/eal/eal.c | 97
> +++++++++++++++--------
> lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 ++++++---
> lib/librte_eal/linuxapp/eal/eal_interrupts.c | 25 ++++--
> lib/librte_ether/rte_ethdev.c | 42 +++++++---
> lib/librte_ether/rte_ethdev.h | 4 +-
> lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +-
> lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +-
> lib/librte_kni/rte_kni.c | 18 +++--
> lib/librte_kni/rte_kni_fifo.h | 11 ++-
> 24 files changed, 396 insertions(+), 143 deletions(-)
>
> --
> 1.8.3.1
>
>
--
*Arnon Warshavsky*
*Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | arnon@qwilt.com
<arnon@qwilt.com>*
next prev parent reply other threads:[~2018-04-24 6:44 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 6:41 Arnon Warshavsky
2018-04-24 6:41 ` [dpdk-dev] [PATCH v6 01/11] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver Arnon Warshavsky
2018-04-24 15:00 ` Stephen Hemminger
2018-04-24 19:27 ` Arnon Warshavsky
2018-04-24 6:41 ` [dpdk-dev] [PATCH v6 02/11] bond: replace rte_panic instances in bonding driver Arnon Warshavsky
2018-04-24 6:41 ` [dpdk-dev] [PATCH v6 03/11] e1000: replace rte_panic instances in e1000 driver Arnon Warshavsky
2018-04-24 6:41 ` [dpdk-dev] [PATCH v6 04/11] ixgbe: replace rte_panic instances in ixgbe driver Arnon Warshavsky
2018-04-24 6:41 ` [dpdk-dev] [PATCH v6 05/11] eal: replace rte_panic instances in eventdev Arnon Warshavsky
2018-04-24 15:04 ` Stephen Hemminger
2018-04-24 15:06 ` Stephen Hemminger
2018-04-24 19:28 ` Arnon Warshavsky
2018-04-24 6:41 ` [dpdk-dev] [PATCH v6 06/11] kni: replace rte_panic instances in kni Arnon Warshavsky
2018-04-24 6:41 ` [dpdk-dev] [PATCH v6 07/11] eal: replace rte_panic instances in hugepage_info Arnon Warshavsky
2018-04-24 6:42 ` [dpdk-dev] [PATCH v6 08/11] eal: replace rte_panic instances in interrupts thread Arnon Warshavsky
2018-04-24 6:42 ` [dpdk-dev] [PATCH v6 09/11] eal: replace rte_panic instances in ethdev Arnon Warshavsky
2018-04-24 6:42 ` [dpdk-dev] [PATCH v6 10/11] eal: replace rte_panic instances in init sequence Arnon Warshavsky
2018-04-24 6:42 ` [dpdk-dev] [PATCH v6 11/11] devtools: prevent new instances of rte_panic and rte_exit Arnon Warshavsky
2018-04-24 6:44 ` Arnon Warshavsky [this message]
2018-04-24 6:57 ` [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances Arnon Warshavsky
2019-04-18 14:50 ` Thomas Monjalon
2019-04-18 14:50 ` Thomas Monjalon
2019-04-21 19:16 ` Arnon Warshavsky
2019-04-21 19:16 ` Arnon Warshavsky
2019-04-21 21:10 ` Thomas Monjalon
2019-04-21 21:10 ` Thomas Monjalon
2019-05-08 11:15 ` Thomas Monjalon
2019-05-08 11:15 ` Thomas Monjalon
2019-05-08 14:47 ` David Marchand
2019-05-08 14:47 ` David Marchand
2019-05-09 12:05 ` Burakov, Anatoly
2019-05-09 12:05 ` Burakov, Anatoly
2019-05-09 13:16 ` Thomas Monjalon
2019-05-09 13:16 ` Thomas Monjalon
2019-05-23 11:14 ` Thomas Monjalon
2019-05-23 13:13 ` Arnon Warshavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKy9EB1c=ZU=VMurOzwuaZZWTfQQtSkVMVSSeFXUWDPFhQJRkw@mail.gmail.com' \
--to=arnon@qwilt.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).