* [PATCH] examples/l2fwd-event: fix function args of worker cleanup
@ 2022-12-12 15:48 Shijith Thotton
2022-12-13 15:13 ` Pavan Nikhilesh Bhagavatula
0 siblings, 1 reply; 3+ messages in thread
From: Shijith Thotton @ 2022-12-12 15:48 UTC (permalink / raw)
To: jerinj; +Cc: Shijith Thotton, dev, pbhagavatula
Fixed function call arguments of l2fwd worker cleanup. Number of events
enqueued and dequeued are set the opposite.
Fixes: 622ebb6b4a7d ("examples/l2fwd-event: clean up worker state before exit")
Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
examples/l2fwd-event/l2fwd_event.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/l2fwd-event/l2fwd_event.c b/examples/l2fwd-event/l2fwd_event.c
index 63450537fe..4b5a032e35 100644
--- a/examples/l2fwd-event/l2fwd_event.c
+++ b/examples/l2fwd-event/l2fwd_event.c
@@ -284,7 +284,7 @@ l2fwd_event_loop_burst(struct l2fwd_resources *rsrc,
}
}
- l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_rx, nb_tx, 0);
+ l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_tx, nb_rx, 0);
}
static __rte_always_inline void
@@ -468,7 +468,7 @@ l2fwd_event_loop_vector(struct l2fwd_resources *rsrc, const uint32_t flags)
}
}
- l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_rx, nb_tx, 1);
+ l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_tx, nb_rx, 1);
}
static void __rte_noinline
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] examples/l2fwd-event: fix function args of worker cleanup
2022-12-12 15:48 [PATCH] examples/l2fwd-event: fix function args of worker cleanup Shijith Thotton
@ 2022-12-13 15:13 ` Pavan Nikhilesh Bhagavatula
2023-01-18 10:30 ` Jerin Jacob
0 siblings, 1 reply; 3+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2022-12-13 15:13 UTC (permalink / raw)
To: Shijith Thotton, Jerin Jacob Kollanukkaran
Cc: Shijith Thotton, dev, dpdk stable
[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]
> -----Original Message-----
> From: Shijith Thotton <sthotton@marvell.com>
> Sent: Monday, December 12, 2022 9:19 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: Shijith Thotton <sthotton@marvell.com>; dev@dpdk.org; Pavan
> Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Subject: [PATCH] examples/l2fwd-event: fix function args of worker cleanup
>
> Fixed function call arguments of l2fwd worker cleanup. Number of events
> enqueued and dequeued are set the opposite.
>
> Fixes: 622ebb6b4a7d ("examples/l2fwd-event: clean up worker state before
> exit")
Cc: stable@dpdk.org
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> examples/l2fwd-event/l2fwd_event.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/l2fwd-event/l2fwd_event.c b/examples/l2fwd-
> event/l2fwd_event.c
> index 63450537fe..4b5a032e35 100644
> --- a/examples/l2fwd-event/l2fwd_event.c
> +++ b/examples/l2fwd-event/l2fwd_event.c
> @@ -284,7 +284,7 @@ l2fwd_event_loop_burst(struct l2fwd_resources
> *rsrc,
> }
> }
>
> - l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_rx,
> nb_tx, 0);
> + l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_tx,
> nb_rx, 0);
> }
>
> static __rte_always_inline void
> @@ -468,7 +468,7 @@ l2fwd_event_loop_vector(struct l2fwd_resources
> *rsrc, const uint32_t flags)
> }
> }
>
> - l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_rx,
> nb_tx, 1);
> + l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_tx,
> nb_rx, 1);
> }
>
> static void __rte_noinline
> --
> 2.25.1
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 23146 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] examples/l2fwd-event: fix function args of worker cleanup
2022-12-13 15:13 ` Pavan Nikhilesh Bhagavatula
@ 2023-01-18 10:30 ` Jerin Jacob
0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2023-01-18 10:30 UTC (permalink / raw)
To: Pavan Nikhilesh Bhagavatula
Cc: Shijith Thotton, Jerin Jacob Kollanukkaran, dev, dpdk stable
On Tue, Dec 13, 2022 at 8:43 PM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Shijith Thotton <sthotton@marvell.com>
> > Sent: Monday, December 12, 2022 9:19 PM
> > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> > Cc: Shijith Thotton <sthotton@marvell.com>; dev@dpdk.org; Pavan
> > Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> > Subject: [PATCH] examples/l2fwd-event: fix function args of worker cleanup
> >
> > Fixed function call arguments of l2fwd worker cleanup. Number of events
> > enqueued and dequeued are set the opposite.
> >
> > Fixes: 622ebb6b4a7d ("examples/l2fwd-event: clean up worker state before
> > exit")
> Cc: stable@dpdk.org
> >
> > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks
> > ---
> > examples/l2fwd-event/l2fwd_event.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/examples/l2fwd-event/l2fwd_event.c b/examples/l2fwd-
> > event/l2fwd_event.c
> > index 63450537fe..4b5a032e35 100644
> > --- a/examples/l2fwd-event/l2fwd_event.c
> > +++ b/examples/l2fwd-event/l2fwd_event.c
> > @@ -284,7 +284,7 @@ l2fwd_event_loop_burst(struct l2fwd_resources
> > *rsrc,
> > }
> > }
> >
> > - l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_rx,
> > nb_tx, 0);
> > + l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_tx,
> > nb_rx, 0);
> > }
> >
> > static __rte_always_inline void
> > @@ -468,7 +468,7 @@ l2fwd_event_loop_vector(struct l2fwd_resources
> > *rsrc, const uint32_t flags)
> > }
> > }
> >
> > - l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_rx,
> > nb_tx, 1);
> > + l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_tx,
> > nb_rx, 1);
> > }
> >
> > static void __rte_noinline
> > --
> > 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-18 10:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-12 15:48 [PATCH] examples/l2fwd-event: fix function args of worker cleanup Shijith Thotton
2022-12-13 15:13 ` Pavan Nikhilesh Bhagavatula
2023-01-18 10:30 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).