DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Cc: jerinj@marvell.com, hofors@lysator.liu.se, dev@dpdk.org,
	 Pavan Nikhilesh <pbhagavatula@marvell.com>,
	Timothy McDaniel <timothy.mcdaniel@intel.com>,
	 Hemant Agrawal <hemant.agrawal@nxp.com>,
	Sachin Saxena <sachin.saxena@oss.nxp.com>,
	 Harry van Haaren <harry.van.haaren@intel.com>,
	Liang Ma <liangma@liangbit.com>,
	Peter Mccarthy <peter.mccarthy@intel.com>
Subject: Re: [PATCH] eventdev: remove single-event enqueue operation
Date: Wed, 5 Jul 2023 13:17:39 +0530	[thread overview]
Message-ID: <CALBAE1Mb4RMrTXZK1mrz5KxXd5nsSJoiiKRLE=qPUnbNo1ZdRA@mail.gmail.com> (raw)
In-Reply-To: <20230704115307.243031-1-mattias.ronnblom@ericsson.com>

On Tue, Jul 4, 2023 at 5:29 PM Mattias Rönnblom
<mattias.ronnblom@ericsson.com> wrote:
>
> Eliminate non-burst enqueue operation from Eventdev.
>
> The effect of this change is to reduce Eventdev code complexity
> somewhat and slightly improve performance.
>
> The single-event enqueue shortcut provided a very minor performance
> advantage in some situations (e.g., with a compile time-constant burst
> size of '1'), but would in other situations cause a noticeable
> performance penalty (e.g., rte_event_enqueue_forward_burst() with run
> time-variable burst sizes varying between '1' and larger burst sizes).
>
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
>
> --
>
> PATCH: Add ABI deprecation notice.


Need to split this patch as depreciation notice only will be merged to
this release.
Example: https://patches.dpdk.org/project/dpdk/patch/20230704194445.3332847-1-gakhil@marvell.com/

I think, we need to remove the single dequeue as well. So I think, we
can write a generic deprecation notice
which says size of struct rte_event_fp_ops will be changed by removing
single enqueue, dequeue and.
Reservation fields size . Later we can analysis the performance impact
when the implementation patch is ready.
For now, let make deprecation notice for this release.

  reply	other threads:[~2023-07-05  7:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09 17:42 [RFC] " Mattias Rönnblom
2023-06-30  4:37 ` Jerin Jacob
2023-07-04 12:01   ` Mattias Rönnblom
2023-07-04 11:53 ` [PATCH] " Mattias Rönnblom
2023-07-05  7:47   ` Jerin Jacob [this message]
2023-07-05  8:41     ` Mattias Rönnblom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1Mb4RMrTXZK1mrz5KxXd5nsSJoiiKRLE=qPUnbNo1ZdRA@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=hofors@lysator.liu.se \
    --cc=jerinj@marvell.com \
    --cc=liangma@liangbit.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=pbhagavatula@marvell.com \
    --cc=peter.mccarthy@intel.com \
    --cc=sachin.saxena@oss.nxp.com \
    --cc=timothy.mcdaniel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).