Re: [dpdk-dev] [PATCH v2 4/4] app/eventdev: enable fast free offload

[Jerin Jacob <jerinjacobk@gmail.com>]

On Sun, Oct 11, 2020 at 4:03 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> On Fri, Oct 9, 2020 at 12:20 AM Harman Kalra <hkalra@marvell.com> wrote:
> >
> > Since we are not holding the mbufs or creating any references
> > in the app, hence mbuf fast free offload can be enabled.
> >
> > Signed-off-by: Harman Kalra <hkalra@marvell.com>
> > ---
> >  app/test-eventdev/test_pipeline_common.c | 5 +++++
>
> ++ eventdev maintainers
>
> Since testeventdev is not creating more than one pool and not using
> any mbuf reference feature.
> This change looks to me. Let me know if you have any different opinion if nay.
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>

Applied to dpdk-next-eventdev/for-main. Thanks.



>
>
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
> > index 17088b1b4..f0c0ffea7 100644
> > --- a/app/test-eventdev/test_pipeline_common.c
> > +++ b/app/test-eventdev/test_pipeline_common.c
> > @@ -219,6 +219,11 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt)
> >                         return ret;
> >                 }
> >
> > +               /* Enable mbuf fast free if PMD has the capability. */
> > +               if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
> > +                       local_port_conf.txmode.offloads |=
> > +                               DEV_TX_OFFLOAD_MBUF_FAST_FREE;
> > +
> >                 rx_conf = dev_info.default_rxconf;
> >                 rx_conf.offloads = port_conf.rxmode.offloads;
> >
> > --
> > 2.18.0
> >