DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Harman Kalra <hkalra@marvell.com>,
	"Van Haaren, Harry" <harry.van.haaren@intel.com>,
	 Mattias Rönnblom <mattias.ronnblom@ericsson.com>,
	 Nipun Gupta <nipun.gupta@nxp.com>,
	Pavan Nikhilesh <pbhagavatula@marvell.com>,
	 Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
	"Rao, Nikhil" <nikhil.rao@intel.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	 "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 4/4] app/eventdev: enable fast free offload
Date: Sun, 11 Oct 2020 16:03:17 +0530
Message-ID: <CALBAE1Pc83WnUmOi4q1XJDLWCwr9ofggQ+3UzFWNpUQh80iYdA@mail.gmail.com> (raw)
In-Reply-To: <1602182927-18254-4-git-send-email-hkalra@marvell.com>

On Fri, Oct 9, 2020 at 12:20 AM Harman Kalra <hkalra@marvell.com> wrote:
>
> Since we are not holding the mbufs or creating any references
> in the app, hence mbuf fast free offload can be enabled.
>
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
> ---
>  app/test-eventdev/test_pipeline_common.c | 5 +++++

++ eventdev maintainers

Since testeventdev is not creating more than one pool and not using
any mbuf reference feature.
This change looks to me. Let me know if you have any different opinion if nay.

Acked-by: Jerin Jacob <jerinj@marvell.com>


>  1 file changed, 5 insertions(+)
>
> diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
> index 17088b1b4..f0c0ffea7 100644
> --- a/app/test-eventdev/test_pipeline_common.c
> +++ b/app/test-eventdev/test_pipeline_common.c
> @@ -219,6 +219,11 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt)
>                         return ret;
>                 }
>
> +               /* Enable mbuf fast free if PMD has the capability. */
> +               if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
> +                       local_port_conf.txmode.offloads |=
> +                               DEV_TX_OFFLOAD_MBUF_FAST_FREE;
> +
>                 rx_conf = dev_info.default_rxconf;
>                 rx_conf.offloads = port_conf.rxmode.offloads;
>
> --
> 2.18.0
>

  reply	other threads:[~2020-10-11 10:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 18:56 [dpdk-dev] [PATCH 1/4] event/octeontx2: add switch tag flush op Harman Kalra
2020-09-15 18:56 ` [dpdk-dev] [PATCH 2/4] event/octeontx2: improve single flow performance Harman Kalra
2020-10-05  9:29   ` Jerin Jacob
2020-10-08 18:48     ` [dpdk-dev] [PATCH v2 1/4] event/octeontx2: add switch tag flush op Harman Kalra
2020-10-08 18:48       ` [dpdk-dev] [PATCH v2 2/4] event/octeontx2: improve single flow performance Harman Kalra
2020-10-08 18:48       ` [dpdk-dev] [PATCH v2 3/4] net/octeontx2: fix jumbo frame crash Harman Kalra
2020-10-16  4:04         ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2020-10-08 18:48       ` [dpdk-dev] [PATCH v2 4/4] app/eventdev: enable fast free offload Harman Kalra
2020-10-11 10:33         ` Jerin Jacob [this message]
2020-10-13 19:06           ` Jerin Jacob
2020-10-11 10:40       ` [dpdk-dev] [PATCH v2 1/4] event/octeontx2: add switch tag flush op Jerin Jacob
2020-09-15 18:56 ` [dpdk-dev] [PATCH 3/4] net/octeontx2: fix jumbo frame crash Harman Kalra
2020-09-15 18:56 ` [dpdk-dev] [PATCH 4/4] app/eventdev: enable fast free offload Harman Kalra
2020-10-05  9:26   ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1Pc83WnUmOi4q1XJDLWCwr9ofggQ+3UzFWNpUQh80iYdA@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=abhinandan.gujjar@intel.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=hkalra@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=nikhil.rao@intel.com \
    --cc=nipun.gupta@nxp.com \
    --cc=pbhagavatula@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git