From: Jerin Jacob <jerinjacobk@gmail.com>
To: Fady Bader <fady@mellanox.com>
Cc: dpdk-dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
tbashar@mellanox.com, Tal Shnaiderman <talshn@mellanox.com>,
yohadt@mellanox.com, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Olivier Matz <olivier.matz@6wind.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Ray Kinsella <mdr@ashroe.eu>,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH 1/5] mempool: disable tracing for Windows
Date: Sun, 31 May 2020 19:19:50 +0530 [thread overview]
Message-ID: <CALBAE1N7pN3wJiWzK-ud3zyU1ZERPXyu20wF8f1ZtNzYGE5DpA@mail.gmail.com> (raw)
In-Reply-To: <20200531124151.16848-2-fady@mellanox.com>
On Sun, May 31, 2020 at 6:12 PM Fady Bader <fady@mellanox.com> wrote:
>
> Tracing is not supported for Windows.
> Disabled all trace calls in for Windows.
What is the current major issue to enable Trace for windows?.
Trace does not need to rte_malloc support, it can work with malloc as
well incase rte_malloc is not available.
If there is not a major issue in enabling trace for windows, we should
enable trace instead of introducing
conditional compilation stuff.
>
> Signed-off-by: Fady Bader <fady@mellanox.com>
> ---
> lib/librte_mempool/mempool_trace_points.c | 4 ++++
> lib/librte_mempool/rte_mempool.c | 20 ++++++++++++++++++++
> lib/librte_mempool/rte_mempool.h | 22 ++++++++++++++++++++++
> lib/librte_mempool/rte_mempool_ops.c | 8 ++++++++
> lib/librte_mempool/rte_mempool_trace_fp.h | 3 +++
> 5 files changed, 57 insertions(+)
>
next prev parent reply other threads:[~2020-05-31 13:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 12:41 [dpdk-dev] [PATCH 0/5] build mempool on Windows Fady Bader
2020-05-31 12:41 ` [dpdk-dev] [PATCH 1/5] mempool: disable tracing for Windows Fady Bader
2020-05-31 13:02 ` Andrew Rybchenko
2020-06-01 1:54 ` Dmitry Kozlyuk
2020-05-31 13:49 ` Jerin Jacob [this message]
2020-05-31 12:41 ` [dpdk-dev] [PATCH 2/5] eal: disable function versioning on Windows Fady Bader
2020-05-31 12:41 ` [dpdk-dev] [PATCH 3/5] mempool: use generic memory management Fady Bader
2020-05-31 13:06 ` Andrew Rybchenko
2020-05-31 12:41 ` [dpdk-dev] [PATCH 4/5] eal: export needed functions for mempool Fady Bader
2020-05-31 12:41 ` [dpdk-dev] [PATCH 5/5] mempool: mempool build on Windows Fady Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1N7pN3wJiWzK-ud3zyU1ZERPXyu20wF8f1ZtNzYGE5DpA@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=fady@mellanox.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=talshn@mellanox.com \
--cc=tbashar@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yohadt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).