From: Jerin Jacob <jerinjacobk@gmail.com>
To: Naga Harish K S V <s.v.naga.harish.k@intel.com>
Cc: jerinj@marvell.com, erik.g.carrillo@intel.com,
abhinandan.gujjar@intel.com, dev@dpdk.org,
jay.jayatheerthan@intel.com
Subject: Re: [PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs
Date: Fri, 10 Feb 2023 19:35:32 +0530 [thread overview]
Message-ID: <CALBAE1NK=yRC8eUvC_dWSt50avkVi4jWNZ0nxpbygaOXYB6UeQ@mail.gmail.com> (raw)
In-Reply-To: <20230210134646.3407253-2-s.v.naga.harish.k@intel.com>
On Fri, Feb 10, 2023 at 7:17 PM Naga Harish K S V
<s.v.naga.harish.k@intel.com> wrote:
>
> The adapter runtime configuration parameters defined in the
> struct rte_event_eth_tx_adapter_runtime_params can be
> configured and retrieved using
> rte_event_eth_tx_adapter_runtime_params_set and
rte_event_eth_tx_adapter_runtime_params_set()
> rte_event_eth_tx_adapter_runtime_params_get respectively.
rte_event_eth_tx_adapter_runtime_params_get()
>
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> --- a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst
> +++ b/doc/guides/prog_guide/event_ethernet_tx_adapter.rst
> @@ -225,3 +225,12 @@ Stop function stops the adapter runtime function from enqueueing any
> packets to the associated Tx queue. This API also frees any packets that
> may have been buffered for this queue. All inflight packets destined to the
> queue are freed by the adapter runtime until the queue is started again.
> +
> +Set/Get adapter runtime configuration parameters
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +The runtime configuration parameters of adapter can be set/get using
> +``rte_event_eth_tx_adapter_runtime_params_set()`` and
> +``rte_event_eth_tx_adapter_runtime_params_get()`` respectively. The parameters
> +that can be set/get are defined in
> +``struct rte_event_eth_tx_adapter_runtime_params``.
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> index cce50c3c18..131e11e01d 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> @@ -124,6 +124,8 @@ struct txa_service_data {
> uint16_t dev_count;
> /* Loop count to flush Tx buffers */
> int loop_cnt;
> + /* Loop count threshold to flush Tx buffers */
> + uint16_t flush_threshold;
> /* Per ethernet device structure */
> struct txa_service_ethdev *txa_ethdev;
> /* Statistics */
> @@ -665,13 +667,14 @@ txa_service_func(void *args)
> ret = 0;
> }
>
> - if ((txa->loop_cnt++ & (TXA_FLUSH_THRESHOLD - 1)) == 0) {
> + if (txa->loop_cnt++ == txa->flush_threshold) {
>
> struct txa_service_ethdev *tdi;
> struct txa_service_queue_info *tqi;
> struct rte_eth_dev *dev;
> uint16_t i;
>
> + txa->loop_cnt = 0;
> tdi = txa->txa_ethdev;
> nb_tx = 0;
>
> @@ -769,6 +772,7 @@ txa_service_adapter_create_ext(uint8_t id, struct rte_eventdev *dev,
> txa->service_id = TXA_INVALID_SERVICE_ID;
> rte_spinlock_init(&txa->tx_lock);
> txa_service_data_array[id] = txa;
> + txa->flush_threshold = TXA_FLUSH_THRESHOLD;
>
> return 0;
> }
> @@ -1291,6 +1295,115 @@ rte_event_eth_tx_adapter_stats_reset(uint8_t id)
> return ret;
> }
>
> +int
> +rte_event_eth_tx_adapter_runtime_params_init(
> + struct rte_event_eth_tx_adapter_runtime_params *txa_params)
> +{
> + if (txa_params == NULL)
> + return -EINVAL;
> +
> + memset(txa_params, 0, sizeof(*txa_params));
> + txa_params->max_nb_tx = TXA_MAX_NB_TX;
> + txa_params->flush_threshold = TXA_FLUSH_THRESHOLD;
> +
> + return 0;
> +}
> +
> +static int
> +txa_caps_check(uint8_t id, struct txa_service_data *txa)
> +{
> + uint32_t caps = 0;
> + struct rte_eth_dev *eth_dev = NULL;
> + struct txa_service_ethdev *tdi;
> + int i;
> +
> + if (!txa->dev_count)
> + return -EINVAL;
> +
> + /* The eth_dev used is always the same type.
> + * Hence first valid eth_dev is taken.
> + */
> + for (i = 0; i < txa->dev_count; i++) {
> + tdi = &txa->txa_ethdev[i];
> + if (tdi->nb_queues) {
> + eth_dev = tdi->dev;
> + break;
> + }
> + }
> + if (eth_dev == NULL)
> + return -EINVAL;
> +
> + if (txa_dev_caps_get(id))
> + txa_dev_caps_get(id)(txa_evdev(id), eth_dev, &caps);
> +
> + if (caps & RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT)
> + return -ENOTSUP;
> +
> + return 0;
> +}
> +
> +int
> +rte_event_eth_tx_adapter_runtime_params_set(uint8_t id,
> + struct rte_event_eth_tx_adapter_runtime_params *txa_params)
> +{
> + struct txa_service_data *txa;
> + int ret;
> +
> + if (txa_lookup())
> + return -ENOMEM;
> +
> + TXA_CHECK_OR_ERR_RET(id);
> +
> + if (txa_params == NULL)
> + return -EINVAL;
> +
> + txa = txa_service_id_to_data(id);
> + if (txa == NULL)
> + return -EINVAL;
> +
> + ret = txa_caps_check(id, txa);
> + if (ret)
> + return ret;
> +
> + rte_spinlock_lock(&txa->tx_lock);
> + txa->flush_threshold = txa_params->flush_threshold;
> + txa->max_nb_tx = txa_params->max_nb_tx;
> + rte_spinlock_unlock(&txa->tx_lock);
> +
> + return 0;
> +}
> +
> +int
> +rte_event_eth_tx_adapter_runtime_params_get(uint8_t id,
> + struct rte_event_eth_tx_adapter_runtime_params *txa_params)
> +{
> + struct txa_service_data *txa;
> + int ret;
> +
> + if (txa_lookup())
> + return -ENOMEM;
> +
> + TXA_CHECK_OR_ERR_RET(id);
> +
> + if (txa_params == NULL)
> + return -EINVAL;
> +
> + txa = txa_service_id_to_data(id);
> + if (txa == NULL)
> + return -EINVAL;
> +
> + ret = txa_caps_check(id, txa);
> + if (ret)
> + return ret;
> +
> + rte_spinlock_lock(&txa->tx_lock);
> + txa_params->flush_threshold = txa->flush_threshold;
> + txa_params->max_nb_tx = txa->max_nb_tx;
> + rte_spinlock_unlock(&txa->tx_lock);
> +
> + return 0;
> +}
> +
> int
> rte_event_eth_tx_adapter_stop(uint8_t id)
> {
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.h b/lib/eventdev/rte_event_eth_tx_adapter.h
> index cd539af7ef..9b1ac2055e 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.h
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.h
> @@ -37,6 +37,9 @@
> * - rte_event_eth_tx_adapter_instance_get()
> * - rte_event_eth_tx_adapter_queue_start()
> * - rte_event_eth_tx_adapter_queue_stop()
> + * - rte_event_eth_tx_adapter_runtime_params_get()
> + * - rte_event_eth_tx_adapter_runtime_params_init()
> + * - rte_event_eth_tx_adapter_runtime_params_set()
> *
> * The application creates the adapter using
> * rte_event_eth_tx_adapter_create() or rte_event_eth_tx_adapter_create_ext().
> @@ -103,6 +106,25 @@ struct rte_event_eth_tx_adapter_conf {
> */
> };
>
> +/**
> + * Adapter runtime configuration parameters
> + */
> +struct rte_event_eth_tx_adapter_runtime_params {
> + uint32_t max_nb_tx;
> + /**< The adapter can return early if it has processed at least
> + * max_nb_tx mbufs. This isn't treated as a requirement; batching may
> + * cause the adapter to process more than max_nb_tx mbufs.
> + * This is valid for service based SW adapter only.
express with RTE_EVENT_*CAP_INTERNAL_PORT
> + */
> + uint16_t flush_threshold;
> + /**< the number of service function iteration count to
> + * flush buffered packets.
> + * This is valid for service based SW adapter only.
express with RTE_EVENT_*CAP_INTERNAL_PORT
> + */
> + uint16_t rsvd[29];
> + /**< Reserved fields for future expansion */
> +};
> +
> /**
> * Function type used for adapter configuration callback. The callback is
> * used to fill in members of the struct rte_event_eth_tx_adapter_conf, this
> @@ -516,6 +538,72 @@ __rte_experimental
> int
> rte_event_eth_tx_adapter_queue_stop(uint16_t eth_dev_id, uint16_t tx_queue_id);
>
> +/**
> + * Initialize the adapter runtime configuration parameters with default values
> + *
> + * @param txa_params
> + * A pointer to structure of type struct rte_event_eth_tx_adapter_runtime_params
> + *
> + * @return
> + * - 0: Success
> + * - <0: Error code on failure
> + */
> +__rte_experimental
> +int
> +rte_event_eth_tx_adapter_runtime_params_init(
> + struct rte_event_eth_tx_adapter_runtime_params *txa_params);
> +
> +/**
> + * Set the runtime configuration parameters for adapter.
> + *
> + * In case not all fields are to be updated, the suggested way to use this
> + * api is read the current values using rte_event_eth_tx_adapter_get_params(),
api -> API
Not relevent any more. Use rte_event_eth_tx_adapter_runtime_params_init().
i.e This sentence can be removed.
> + * modify the required parameters and then call
> + * rte_event_eth_tx_adapter_runtime_params_set().
> + *
> + * This API is to be used after adding at least one queue to the adapter
> + * and is supported only for service based adapter.
This paragraph we can removed here as it is not generic API description.
> + *
> + * @param id
> + * Adapter identifier
> + * @param params
> + * A pointer to structure of type struct rte_event_eth_tx_adapter_runtime_params
> + * with configuration parameter values. The reserved fields of this structure
> + * must be initialized to zero and the valid fields need to be set appropriately.
> + * This structure can be initialized using
> + * rte_event_eth_tx_adapter_runtime_params_init() API to default values or
> + * application may reset this structure and update required fields.
> + *
> + * @return
> + * - 0: Success
> + * - <0: Error code on failure
> + */
> +__rte_experimental
> +int
> +rte_event_eth_tx_adapter_runtime_params_set(uint8_t id,
> + struct rte_event_eth_tx_adapter_runtime_params *params);
> +
> +/**
> + * Get the runtime configuration parameters of adapter.
> + *
> + * This API is to be used after adding at least one queue to the adapter
> + * and is supported only for service based adapter.
This paragraph we can removed here as it is not generic API description.
Similar comment to 3/3 patch. Also add chnagelog when sending next version
to know what is changed.
> + *
> + * @param id
> + * Adapter identifier
> + * @param[out] params
> + * A pointer to structure of type struct rte_event_eth_tx_adapter_runtime_params
> + * containing valid Tx adapter parameters when return value is 0.
> + *
> + * @return
> + * - 0: Success
> + * - <0: Error code on failure
> + */
> +__rte_experimental
> +int
> +rte_event_eth_tx_adapter_runtime_params_get(uint8_t id,
> + struct rte_event_eth_tx_adapter_runtime_params *params);
> +
> #ifdef __cplusplus
> }
> #endif
> diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
> index ef9c3b86b2..7b93736dff 100644
> --- a/lib/eventdev/version.map
> +++ b/lib/eventdev/version.map
> @@ -124,6 +124,9 @@ EXPERIMENTAL {
> rte_event_eth_rx_adapter_runtime_params_get;
> rte_event_eth_rx_adapter_runtime_params_init;
> rte_event_eth_rx_adapter_runtime_params_set;
> + rte_event_eth_tx_adapter_runtime_params_get;
> + rte_event_eth_tx_adapter_runtime_params_init;
> + rte_event_eth_tx_adapter_runtime_params_set;
> rte_event_timer_remaining_ticks_get;
> };
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-02-10 14:06 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 16:18 [PATCH 1/3] eventdev/eth_rx: " Naga Harish K S V
2023-01-07 16:18 ` [PATCH 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-01-07 16:18 ` [PATCH 3/3] eventdev/crypto: " Naga Harish K S V
2023-01-18 10:22 ` [PATCH 1/3] eventdev/eth_rx: " Jerin Jacob
2023-01-20 8:58 ` Naga Harish K, S V
2023-01-20 9:32 ` Jerin Jacob
2023-01-20 10:33 ` Naga Harish K, S V
2023-01-23 9:31 ` Jerin Jacob
2023-01-23 18:07 ` Naga Harish K, S V
2023-01-23 18:04 ` [PATCH v2 " Naga Harish K S V
2023-01-23 18:04 ` [PATCH v2 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-01-23 18:04 ` [PATCH v2 3/3] eventdev/crypto: " Naga Harish K S V
2023-01-24 4:29 ` [PATCH v2 1/3] eventdev/eth_rx: " Jerin Jacob
2023-01-24 13:07 ` Naga Harish K, S V
2023-01-25 4:12 ` Jerin Jacob
2023-01-25 9:52 ` Naga Harish K, S V
2023-01-25 10:38 ` Jerin Jacob
2023-01-25 16:32 ` Naga Harish K, S V
2023-01-28 10:53 ` Jerin Jacob
2023-01-28 17:21 ` Stephen Hemminger
2023-01-30 9:56 ` Naga Harish K, S V
2023-01-30 14:43 ` Jerin Jacob
2023-02-02 16:12 ` Naga Harish K, S V
2023-02-03 9:44 ` Jerin Jacob
2023-02-06 6:21 ` Naga Harish K, S V
2023-02-06 16:38 ` Jerin Jacob
2023-02-09 17:00 ` Naga Harish K, S V
2023-02-09 16:57 ` [PATCH v3 " Naga Harish K S V
2023-02-09 16:57 ` [PATCH v3 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-02-09 16:57 ` [PATCH v3 3/3] eventdev/crypto: " Naga Harish K S V
2023-02-10 1:55 ` [PATCH v3 1/3] eventdev/eth_rx: " Naga Harish K S V
2023-02-10 1:55 ` [PATCH v3 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-02-10 1:55 ` [PATCH v3 3/3] eventdev/crypto: " Naga Harish K S V
2023-02-10 4:58 ` [PATCH v4 1/3] eventdev/eth_rx: " Naga Harish K S V
2023-02-10 4:58 ` [PATCH v4 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-02-10 4:58 ` [PATCH v4 3/3] eventdev/crypto: " Naga Harish K S V
2023-02-10 6:30 ` [PATCH v4 1/3] eventdev/eth_rx: " Jerin Jacob
2023-02-10 13:33 ` [PATCH v5 " Naga Harish K S V
2023-02-10 13:33 ` [PATCH v5 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-02-10 13:33 ` [PATCH v5 3/3] eventdev/crypto: " Naga Harish K S V
2023-02-10 13:58 ` [PATCH v5 1/3] eventdev/eth_rx: " Jerin Jacob
2023-02-10 17:42 ` Naga Harish K, S V
2023-02-10 13:46 ` Naga Harish K S V
2023-02-10 13:46 ` [PATCH v5 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-02-10 14:05 ` Jerin Jacob [this message]
2023-02-10 15:01 ` Naga Harish K, S V
2023-02-10 15:24 ` Jerin Jacob
2023-02-10 17:41 ` Naga Harish K, S V
2023-02-10 13:46 ` [PATCH v5 3/3] eventdev/crypto: " Naga Harish K S V
2023-02-10 17:37 ` [PATCH v6 1/3] eventdev/eth_rx: " Naga Harish K S V
2023-02-10 17:37 ` [PATCH v6 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-02-10 17:37 ` [PATCH v6 3/3] eventdev/crypto: " Naga Harish K S V
2023-02-13 5:08 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1NK=yRC8eUvC_dWSt50avkVi4jWNZ0nxpbygaOXYB6UeQ@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
--cc=s.v.naga.harish.k@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).