From: Jerin Jacob <jerinjacobk@gmail.com>
To: Naga Harish K S V <s.v.naga.harish.k@intel.com>
Cc: jerinj@marvell.com, erik.g.carrillo@intel.com,
abhinandan.gujjar@intel.com, dev@dpdk.org,
jay.jayatheerthan@intel.com
Subject: Re: [PATCH v2 1/3] eventdev/eth_rx: add params set/get APIs
Date: Tue, 24 Jan 2023 09:59:34 +0530 [thread overview]
Message-ID: <CALBAE1PS+oCGVUpgA5YsoZa69=b8vVdin3Oi0gnfk3R+8A5TAQ@mail.gmail.com> (raw)
In-Reply-To: <20230123180458.486189-1-s.v.naga.harish.k@intel.com>
On Mon, Jan 23, 2023 at 11:35 PM Naga Harish K S V
<s.v.naga.harish.k@intel.com> wrote:
>
> The adapter configuration parameters defined in the
> ``struct rte_event_eth_rx_adapter_runtime_params`` can be configured
> and retrieved using ``rte_event_eth_rx_adapter_runtime_params_set`` and
> ``rte_event_eth_tx_adapter_runtime_params_get`` respectively.
>
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
> index 461eca566f..2207d6ffc3 100644
> --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
> +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
> @@ -185,6 +185,26 @@ flags for handling received packets, event queue identifier, scheduler type,
> event priority, polling frequency of the receive queue and flow identifier
> in struct ``rte_event_eth_rx_adapter_queue_conf``.
>
> +Set/Get adapter runtime configuration parameters
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +The runtime configuration parameters of adapter can be set/read using
> +``rte_event_eth_rx_adapter_runtime_params_set()`` and
> +``rte_event_eth_rx_adapter_runtime_params_get()`` respectively. The parameters that
> +can be set/read are defined in ``struct rte_event_eth_rx_adapter_runtime_params``.
Good.
> +
> +``rte_event_eth_rx_adapter_create()`` or
> +``rte_event_eth_rx_adapter_create_with_params()`` configures the adapter with
> +default value for maximum packets processed per request to 128.
> +``rte_event_eth_rx_adapter_runtime_params_set()`` function allows to reconfigure
> +maximum number of packets processed by adapter per service request. This is
> +alternative to configuring the maximum packets processed per request by adapter
> +by using ``rte_event_eth_rx_adapter_create_ext()`` with parameter
> +``rte_event_eth_rx_adapter_conf::max_nb_rx``.
This paragraph is not needed IMO. As it is specific to a driver, and
we can keep Doxygen comment only.
> +
> +``rte_event_eth_rx_adapter_runtime_parmas_get()`` function retrieves the configuration
> +parameters that are defined in ``struct rte_event_eth_rx_adapter_runtime_params``.
Good.
> +
> Getting and resetting Adapter queue stats
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
> index 34aa87379e..d8f3e750b7 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -35,6 +35,8 @@
> #define MAX_VECTOR_NS 1E9
> #define MIN_VECTOR_NS 1E5
>
> +#define RXA_NB_RX_WORK_DEFAULT 128
> +
> #define ETH_RX_ADAPTER_SERVICE_NAME_LEN 32
> #define ETH_RX_ADAPTER_MEM_NAME_LEN 32
>
> @@ -1554,7 +1556,7 @@ rxa_default_conf_cb(uint8_t id, uint8_t dev_id,
> }
>
> conf->event_port_id = port_id;
> - conf->max_nb_rx = 128;
> + conf->max_nb_rx = RXA_NB_RX_WORK_DEFAULT;
> if (started)
> ret = rte_event_dev_start(dev_id);
> rx_adapter->default_cb_arg = 1;
> @@ -3436,6 +3438,90 @@ rte_event_eth_rx_adapter_instance_get(uint16_t eth_dev_id,
> return -EINVAL;
> }
> +
> +int
> +rte_event_eth_rx_adapter_runtime_params_set(uint8_t id,
> + struct rte_event_eth_rx_adapter_runtime_params *params)
> +{
> + struct event_eth_rx_adapter *rxa;
> + int ret;
> +
> + if (params == NULL)
> + return -EINVAL;
> +
> + if (rxa_memzone_lookup())
> + return -ENOMEM;
Introduce an adapter callback and move SW adapter related logic under
callback handler.
> +
> + rxa = rxa_id_to_adapter(id);
> + if (rxa == NULL)
> + return -EINVAL;
> +
> + ret = rxa_caps_check(rxa);
> + if (ret)
> + return ret;
> +
> + rte_spinlock_lock(&rxa->rx_lock);
> + rxa->max_nb_rx = params->max_nb_rx;
> + rte_spinlock_unlock(&rxa->rx_lock);
> +
> + return 0;
> +}
> +
> +int
> +rte_event_eth_rx_adapter_runtime_params_get(uint8_t id,
> + struct rte_event_eth_rx_adapter_runtime_params *params)
> +{
> + struct event_eth_rx_adapter *rxa;
> + int ret;
> +
> + if (params == NULL)
> + return -EINVAL;
Introduce an adapter callback and move SW adapter related logic under
callback handler.
> +
> + if (rxa_memzone_lookup())
> + return -ENOMEM;
+
> + rxa = rxa_id_to_adapter(id);
> + if (rxa == NULL)
> + return -EINVAL;
> +
> + ret = rxa_caps_check(rxa);
> + if (ret)
> + return ret;
> +
> + params->max_nb_rx = rxa->max_nb_rx;
> +
> + return 0;
> +}
> +
> +/* RX-adapter telemetry callbacks */
> #define RXA_ADD_DICT(stats, s) rte_tel_data_add_dict_u64(d, #s, stats.s)
>
> static int
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h b/lib/eventdev/rte_event_eth_rx_adapter.h
> index f4652f40e8..214ffd018c 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.h
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.h
> @@ -39,10 +39,21 @@
> * - rte_event_eth_rx_adapter_queue_stats_reset()
> * - rte_event_eth_rx_adapter_event_port_get()
> * - rte_event_eth_rx_adapter_instance_get()
> + * - rte_event_eth_rx_adapter_runtime_params_get()
> + * - rte_event_eth_rx_adapter_runtime_params_set()
> *
> * The application creates an ethernet to event adapter using
> * rte_event_eth_rx_adapter_create_ext() or rte_event_eth_rx_adapter_create()
> * or rte_event_eth_rx_adapter_create_with_params() functions.
> + *
> + * rte_event_eth_rx_adapter_create() or rte_event_eth_adapter_create_with_params()
> + * configures the adapter with default value of maximum packets processed per
> + * iteration to RXA_NB_RX_WORK_DEFAULT(128).
> + * rte_event_eth_rx_adapter_runtime_params_set() allows to re-configure maximum
> + * packets processed per iteration. This is alternative to using
> + * rte_event_eth_rx_adapter_create_ext() with parameter
> + * rte_event_eth_rx_adapter_conf::max_nb_rx
Move this to Doxygen comment against max_nb_rx
> + *
> * The adapter needs to know which ethernet rx queues to poll for mbufs as well
> * as event device parameters such as the event queue identifier, event
> * priority and scheduling type that the adapter should use when constructing
> @@ -299,6 +310,19 @@ struct rte_event_eth_rx_adapter_params {
> /**< flag to indicate that event buffer is separate for each queue */
> };
>
> +/**
> + * Adapter configuration parameters
> + */
> +struct rte_event_eth_rx_adapter_runtime_params {
> + uint32_t max_nb_rx;
> + /**< The adapter can return early if it has processed at least
> + * max_nb_rx mbufs. This isn't treated as a requirement; batching may
> + * cause the adapter to process more than max_nb_rx mbufs.
Also tell it is valid only for INTERNAL PORT capablity is set.
> + */
> + uint32_t rsvd[15];
> + /**< Reserved fields for future use */
Introduce rte_event_eth_rx_adapter_runtime_params_init() to make sure
rsvd is zero.
> +};
> +
> /**
> *
> * Callback function invoked by the SW adapter before it continues
> @@ -377,7 +401,7 @@ int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id,
> * Create a new ethernet Rx event adapter with the specified identifier.
> * This function uses an internal configuration function that creates an event
> * port. This default function reconfigures the event device with an
> - * additional event port and setups up the event port using the port_config
> + * additional event port and setup the event port using the port_config
> * parameter passed into this function. In case the application needs more
> * control in configuration of the service, it should use the
> * rte_event_eth_rx_adapter_create_ext() version.
> @@ -743,6 +767,50 @@ rte_event_eth_rx_adapter_instance_get(uint16_t eth_dev_id,
> uint16_t rx_queue_id,
> uint8_t *rxa_inst_id);
>
next prev parent reply other threads:[~2023-01-24 4:30 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 16:18 [PATCH " Naga Harish K S V
2023-01-07 16:18 ` [PATCH 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-01-07 16:18 ` [PATCH 3/3] eventdev/crypto: " Naga Harish K S V
2023-01-18 10:22 ` [PATCH 1/3] eventdev/eth_rx: " Jerin Jacob
2023-01-20 8:58 ` Naga Harish K, S V
2023-01-20 9:32 ` Jerin Jacob
2023-01-20 10:33 ` Naga Harish K, S V
2023-01-23 9:31 ` Jerin Jacob
2023-01-23 18:07 ` Naga Harish K, S V
2023-01-23 18:04 ` [PATCH v2 " Naga Harish K S V
2023-01-23 18:04 ` [PATCH v2 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-01-23 18:04 ` [PATCH v2 3/3] eventdev/crypto: " Naga Harish K S V
2023-01-24 4:29 ` Jerin Jacob [this message]
2023-01-24 13:07 ` [PATCH v2 1/3] eventdev/eth_rx: " Naga Harish K, S V
2023-01-25 4:12 ` Jerin Jacob
2023-01-25 9:52 ` Naga Harish K, S V
2023-01-25 10:38 ` Jerin Jacob
2023-01-25 16:32 ` Naga Harish K, S V
2023-01-28 10:53 ` Jerin Jacob
2023-01-28 17:21 ` Stephen Hemminger
2023-01-30 9:56 ` Naga Harish K, S V
2023-01-30 14:43 ` Jerin Jacob
2023-02-02 16:12 ` Naga Harish K, S V
2023-02-03 9:44 ` Jerin Jacob
2023-02-06 6:21 ` Naga Harish K, S V
2023-02-06 16:38 ` Jerin Jacob
2023-02-09 17:00 ` Naga Harish K, S V
2023-02-09 16:57 ` [PATCH v3 " Naga Harish K S V
2023-02-09 16:57 ` [PATCH v3 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-02-09 16:57 ` [PATCH v3 3/3] eventdev/crypto: " Naga Harish K S V
2023-02-10 1:55 ` [PATCH v3 1/3] eventdev/eth_rx: " Naga Harish K S V
2023-02-10 1:55 ` [PATCH v3 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-02-10 1:55 ` [PATCH v3 3/3] eventdev/crypto: " Naga Harish K S V
2023-02-10 4:58 ` [PATCH v4 1/3] eventdev/eth_rx: " Naga Harish K S V
2023-02-10 4:58 ` [PATCH v4 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-02-10 4:58 ` [PATCH v4 3/3] eventdev/crypto: " Naga Harish K S V
2023-02-10 6:30 ` [PATCH v4 1/3] eventdev/eth_rx: " Jerin Jacob
2023-02-10 13:33 ` [PATCH v5 " Naga Harish K S V
2023-02-10 13:33 ` [PATCH v5 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-02-10 13:33 ` [PATCH v5 3/3] eventdev/crypto: " Naga Harish K S V
2023-02-10 13:58 ` [PATCH v5 1/3] eventdev/eth_rx: " Jerin Jacob
2023-02-10 17:42 ` Naga Harish K, S V
2023-02-10 13:46 ` Naga Harish K S V
2023-02-10 13:46 ` [PATCH v5 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-02-10 14:05 ` Jerin Jacob
2023-02-10 15:01 ` Naga Harish K, S V
2023-02-10 15:24 ` Jerin Jacob
2023-02-10 17:41 ` Naga Harish K, S V
2023-02-10 13:46 ` [PATCH v5 3/3] eventdev/crypto: " Naga Harish K S V
2023-02-10 17:37 ` [PATCH v6 1/3] eventdev/eth_rx: " Naga Harish K S V
2023-02-10 17:37 ` [PATCH v6 2/3] eventdev/eth_tx: " Naga Harish K S V
2023-02-10 17:37 ` [PATCH v6 3/3] eventdev/crypto: " Naga Harish K S V
2023-02-13 5:08 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1PS+oCGVUpgA5YsoZa69=b8vVdin3Oi0gnfk3R+8A5TAQ@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
--cc=s.v.naga.harish.k@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).