From: Jerin Jacob <jerinjacobk@gmail.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: David Marchand <david.marchand@redhat.com>,
"Lin, Xueqin" <xueqin.lin@intel.com>,
"Peng, ZhihongX" <zhihongx.peng@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to DPDK
Date: Mon, 28 Jun 2021 19:53:12 +0530 [thread overview]
Message-ID: <CALBAE1NyzP2dtULtv-90Mo3KFizXGji7yAES78vy3oYZSE+t+w@mail.gmail.com> (raw)
In-Reply-To: <8af553e7-29e1-b46d-dc68-32efaa17c9c0@intel.com>
On Mon, Jun 28, 2021 at 7:52 PM Burakov, Anatoly
<anatoly.burakov@intel.com> wrote:
>
> On 18-Jun-21 10:04 AM, David Marchand wrote:
> > On Fri, Jun 18, 2021 at 9:49 AM Lin, Xueqin <xueqin.lin@intel.com> wrote:
> >>>> Suggest listing demo code and tool capture information for user to try if
> >>> tool works, also add this part into doc.
> >>>>
> >>>>>
> >>>>> # Also, Please update the release note for this feature.
> >>>> Sure, we can update the release note if code merge.
> >>>
> >>> Probably you can send v1 version next i.e change the RFC status to get
> >>> merged.
> >>
> >> Sure, we will send v1 patch if no obvious objection for that, hope patch could receive some ACKs and could success to merge, thanks.
> >
> > How did you test this work?
> >
> > UNH recently started testing with ASAN and it reveals leaks just in
> > the unit test.
> >
> > Merging these annotations will help catch more issues.
> > But users will hit the current issues that we must fix first.
> >
>
> As far as i can tell, the regular build is not affected by this patch,
> so no issues will be hit until someone actually runs the test. IMO it's
> better to merge it early to catch more issues than to gate the feature
> on the condition that we fix all bugs unrelated to this feature first.
+1
>
> --
> Thanks,
> Anatoly
next prev parent reply other threads:[~2021-06-28 14:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 5:13 [dpdk-dev] [RFC] " zhihongx.peng
2021-06-10 8:32 ` Bruce Richardson
2021-06-11 4:42 ` Lin, Xueqin
2021-06-10 9:12 ` Ananyev, Konstantin
2021-06-11 4:49 ` Lin, Xueqin
2021-06-10 20:03 ` Stephen Hemminger
2021-06-11 6:15 ` Lin, Xueqin
2021-06-15 8:12 ` [dpdk-dev] [RFC v2] " zhihongx.peng
2021-06-15 8:40 ` Jerin Jacob
2021-06-16 9:13 ` Lin, Xueqin
2021-06-16 11:34 ` Jerin Jacob
2021-06-18 7:48 ` Lin, Xueqin
2021-06-18 9:04 ` David Marchand
2021-06-22 3:26 ` Lin, Xueqin
2021-06-28 14:22 ` Burakov, Anatoly
2021-06-28 14:23 ` Jerin Jacob [this message]
2021-06-30 8:15 ` Lin, Xueqin
2021-06-30 8:34 ` David Marchand
2021-07-01 6:48 ` Lin, Xueqin
2021-07-01 7:40 ` David Marchand
2021-07-02 11:05 ` Lin, Xueqin
2021-07-06 20:40 ` David Christensen
2021-07-06 23:12 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1NyzP2dtULtv-90Mo3KFizXGji7yAES78vy3oYZSE+t+w@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stephen@networkplumber.org \
--cc=xueqin.lin@intel.com \
--cc=zhihongx.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).