Re: [dpdk-dev] [PATCH 3/5] net/bnx2x: update to latest FW 7.13.11

[Jerin Jacob <jerinjacobk@gmail.com>]

On Fri, Sep 6, 2019 at 12:56 PM Rasesh Mody <rmody@marvell.com> wrote:
>
> Use latest firmware 7.13.11.
>
> Some of the fixes included with this FW are as following:
>     - Packets from a VF with pvid configured which were sent with a
>       different vlan were transmitted instead of being discarded.
>     - In some multi-function configurations, inter-PF and inter-VF
>       Tx switching is incorrectly enabled.
>     - Wrong assert code in FLR final cleanup in case it is sent not
>       after FLR.
>     - Chip may stall in very rare cases under heavy traffic with FW GRO
>       enabled.
>     - VF malicious notification error fixes.
>     - Default gre tunnel to IPGRE which allows proper RSS for IPGRE
>       packets, L2GRE traffic will reach single queue.
>     - Removes unnecessary internal mem config, latest FW performs this
>       autonomously.
>
> Signed-off-by: Rasesh Mody <rmody@marvell.com>
> ---
>  drivers/net/bnx2x/bnx2x.c          |  36 +---
>  drivers/net/bnx2x/bnx2x.h          |   5 +-
>  drivers/net/bnx2x/ecore_fw_defs.h  | 252 ++++++++++++-----------
>  drivers/net/bnx2x/ecore_hsi.h      |   2 +-
>  drivers/net/bnx2x/ecore_init.h     | 212 +++++++++----------
>  drivers/net/bnx2x/ecore_init_ops.h | 224 ++++++++++----------
>  drivers/net/bnx2x/ecore_mfw_req.h  |  10 +-
>  drivers/net/bnx2x/ecore_sp.c       |  39 ++--
>  drivers/net/bnx2x/ecore_sp.h       | 319 ++++++++++++++++++++++++-----
>  9 files changed, 680 insertions(+), 419 deletions(-)

Please update the release note as well.

> > diff --git a/drivers/net/bnx2x/ecore_sp.h b/drivers/net/bnx2x/ecore_sp.h
> index fce715b6d..11b9f77fb 100644
> --- a/drivers/net/bnx2x/ecore_sp.h
> +++ b/drivers/net/bnx2x/ecore_sp.h
> @@ -135,6 +135,7 @@ typedef rte_spinlock_t ECORE_MUTEX_SPIN;
>  #define SC_ILT(sc)  ((sc)->ilt)
>  #define ILOG2(x)    bnx2x_ilog2(x)
>
> +#if 0

Found dead code.
Don't just copy-paste code from some SDK code.
Please clean the code properly and submit the next version.


>  #define ECORE_ILT_ZALLOC(x, y, size, str)                              \
>         do {                                                            \
>                 x = rte_malloc("", sizeof(struct bnx2x_dma), RTE_CACHE_LINE_SIZE); \
> @@ -150,6 +151,23 @@ typedef rte_spinlock_t ECORE_MUTEX_SPIN;
>                         }                                               \
>                 }                                                       \
>         } while (0)
> +#else