[PATCH] ice: fix build error on 32bit configure

[PATCH] ice: fix build error on 32bit configure

[Yiding Zhou]

Replace 'rte_memcpy' with 'memcpy' like other PMD code to avoid errors when
compiling with GCC-12 on 32-bit configure.

Compiler reports the follow error:

error: array subscript 8 is outside array bounds of "struct rte_mbuf *[32]"
[-Werror=array-bounds]

Fixes: c68a52b8b38c ("net/ice: support vector SSE in Rx")
Cc: stable@dpdk.org

Signed-off-by: Yiding Zhou <yidingx.zhou@intel.com>
---
 drivers/net/ice/ice_rxtx_vec_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ice/ice_rxtx_vec_common.h b/drivers/net/ice/ice_rxtx_vec_common.h
index eec6ea2134..55840cf170 100644
--- a/drivers/net/ice/ice_rxtx_vec_common.h
+++ b/drivers/net/ice/ice_rxtx_vec_common.h
@@ -72,7 +72,7 @@ ice_rx_reassemble_packets(struct ice_rx_queue *rxq, struct rte_mbuf **rx_bufs,
 	/* save the partial packet for next time */
 	rxq->pkt_first_seg = start;
 	rxq->pkt_last_seg = end;
-	rte_memcpy(rx_bufs, pkts, pkt_idx * (sizeof(*pkts)));
+	memcpy(rx_bufs, pkts, pkt_idx * (sizeof(*pkts)));
 	return pkt_idx;
 }
 
-- 
2.34.1

Re: [PATCH] ice: fix build error on 32bit configure

[Luca Boccassi]

On Wed, 5 Jul 2023 at 08:21, Yiding Zhou <yidingx.zhou@intel.com> wrote:
>
> Replace 'rte_memcpy' with 'memcpy' like other PMD code to avoid errors when
> compiling with GCC-12 on 32-bit configure.
>
> Compiler reports the follow error:
>
> error: array subscript 8 is outside array bounds of "struct rte_mbuf *[32]"
> [-Werror=array-bounds]
>
> Fixes: c68a52b8b38c ("net/ice: support vector SSE in Rx")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yiding Zhou <yidingx.zhou@intel.com>
> ---
>  drivers/net/ice/ice_rxtx_vec_common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_rxtx_vec_common.h b/drivers/net/ice/ice_rxtx_vec_common.h
> index eec6ea2134..55840cf170 100644
> --- a/drivers/net/ice/ice_rxtx_vec_common.h
> +++ b/drivers/net/ice/ice_rxtx_vec_common.h
> @@ -72,7 +72,7 @@ ice_rx_reassemble_packets(struct ice_rx_queue *rxq, struct rte_mbuf **rx_bufs,
>         /* save the partial packet for next time */
>         rxq->pkt_first_seg = start;
>         rxq->pkt_last_seg = end;
> -       rte_memcpy(rx_bufs, pkts, pkt_idx * (sizeof(*pkts)));
> +       memcpy(rx_bufs, pkts, pkt_idx * (sizeof(*pkts)));
>         return pkt_idx;
>  }

Tested-by: Luca Boccassi <bluca@debian.org>

RE: [PATCH] ice: fix build error on 32bit configure

[Zhang, Qi Z]

> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org>
> Sent: Thursday, July 6, 2023 3:44 AM
> To: Zhou, YidingX <yidingx.zhou@intel.com>; dev@dpdk.org
> Subject: Re: [PATCH] ice: fix build error on 32bit configure
> 
> On Wed, 5 Jul 2023 at 08:21, Yiding Zhou <yidingx.zhou@intel.com> wrote:
> >
> > Replace 'rte_memcpy' with 'memcpy' like other PMD code to avoid errors
> > when compiling with GCC-12 on 32-bit configure.
> >
> > Compiler reports the follow error:
> >
> > error: array subscript 8 is outside array bounds of "struct rte_mbuf *[32]"
> > [-Werror=array-bounds]
> >
> > Fixes: c68a52b8b38c ("net/ice: support vector SSE in Rx")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yiding Zhou <yidingx.zhou@intel.com>
> > ---
> >  drivers/net/ice/ice_rxtx_vec_common.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ice/ice_rxtx_vec_common.h
> > b/drivers/net/ice/ice_rxtx_vec_common.h
> > index eec6ea2134..55840cf170 100644
> > --- a/drivers/net/ice/ice_rxtx_vec_common.h
> > +++ b/drivers/net/ice/ice_rxtx_vec_common.h
> > @@ -72,7 +72,7 @@ ice_rx_reassemble_packets(struct ice_rx_queue *rxq,
> struct rte_mbuf **rx_bufs,
> >         /* save the partial packet for next time */
> >         rxq->pkt_first_seg = start;
> >         rxq->pkt_last_seg = end;
> > -       rte_memcpy(rx_bufs, pkts, pkt_idx * (sizeof(*pkts)));
> > +       memcpy(rx_bufs, pkts, pkt_idx * (sizeof(*pkts)));
> >         return pkt_idx;
> >  }
> 
> Tested-by: Luca Boccassi <bluca@debian.org>

Applied to dpdk-next-net-intel.

Thanks
Qi