DPDK patches and discussions
 help / color / mirror / Atom feed
From: Takuya ASADA <syuu@cloudius-systems.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCHv2 5/8] add OSv support
Date: Tue, 7 Apr 2015 04:01:40 +0900
Message-ID: <CAPWdggj4_zPL6z_vzFDJzyUQicrw5=_P_=KQMhwUzsT_yAtc3A@mail.gmail.com> (raw)
In-Reply-To: <20150324135252.GA11053@hmsreliant.think-freely.org>

On Tue, Mar 24, 2015 at 10:52 PM, Neil Horman <nhorman@tuxdriver.com> wrote:

> On Sat, Mar 21, 2015 at 12:23:02PM +0900, Takuya ASADA wrote:
> > Adding OSv support.
> > Based on Linux/FreeBSD EAL, but calling OSv kernel APIs to access
> devices, allocate contiguous memory, etc.
> >
> > Signed-off-by: Takuya ASADA <syuu@cloudius-systems.com>
> > ---
> > diff --git a/lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h
> b/lib/librte_eal/osvapp/eal/include/exec-env/rte_interrupts.h
> > similarity index 100%
> > copy from lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h
> > copy to lib/librte_eal/osvapp/eal/include/exec-env/rte_interrupts.h
> > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
> b/lib/librte_eal/osvapp/eal/rte_eal_version.map
> > similarity index 92%
> > copy from lib/librte_eal/bsdapp/eal/rte_eal_version.map
> > copy to lib/librte_eal/osvapp/eal/rte_eal_version.map
> > index 67b6a6c..ebb584a 100644
> > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
> > +++ b/lib/librte_eal/osvapp/eal/rte_eal_version.map
> > @@ -31,24 +31,26 @@ DPDK_2.0 {
> >       rte_eal_get_physmem_layout;
> >       rte_eal_get_physmem_size;
> >       rte_eal_has_hugepages;
> > -     rte_eal_hpet_init;
> >       rte_eal_init;
> >       rte_eal_iopl_init;
> >       rte_eal_lcore_role;
> >       rte_eal_mp_remote_launch;
> >       rte_eal_mp_wait_lcore;
> > +     rte_eal_parse_devargs_str;
> > +     rte_eal_pci_close_one;
> >       rte_eal_pci_dump;
> >       rte_eal_pci_probe;
> > +     rte_eal_pci_probe_one;
> >       rte_eal_pci_register;
> >       rte_eal_pci_unregister;
> >       rte_eal_process_type;
> >       rte_eal_remote_launch;
> >       rte_eal_tailq_lookup;
> >       rte_eal_tailq_register;
> > +     rte_eal_vdev_init;
> > +     rte_eal_vdev_uninit;
> >       rte_eal_wait_lcore;
> >       rte_exit;
> > -     rte_get_hpet_cycles;
> > -     rte_get_hpet_hz;
> >       rte_get_tsc_hz;
> >       rte_hexdump;
> >       rte_intr_callback_register;
> > @@ -86,9 +88,6 @@ DPDK_2.0 {
> >       rte_thread_get_affinity;
> >       rte_thread_set_affinity;
> >       rte_vlog;
> > -     rte_xen_dom0_memory_attach;
> > -     rte_xen_dom0_memory_init;
> > -     test_mp_secondary;
> >
> I understand removing symbols that you don't support, but why are you
> adding the
> vdev, pci and parsing symbols?  I don't see you using them anywhere in your
> code...
>

This was because I copied rte_eal_version.map from linuxapp, but git
format-patch generated diff from bsdapp.
But osvapp don't have these symbols, so I dropped these lines.
Please check v3 patchset which I just posted.


> Neil
>
>

  reply	other threads:[~2015-04-06 19:01 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 21:05 [dpdk-dev] [RFC PATCH 0/7] " Takuya ASADA
2015-03-12 21:05 ` [dpdk-dev] [RFC PATCH 1/7] mk: support compiling C++ code Takuya ASADA
2015-03-12 21:05 ` [dpdk-dev] [RFC PATCH 2/7] eal: Add extern C on eal_hugepages.h Takuya ASADA
2015-03-12 21:05 ` [dpdk-dev] [RFC PATCH 3/7] eal: Add extern C on eal_thread.h Takuya ASADA
2015-03-12 21:05 ` [dpdk-dev] [RFC PATCH 4/7] eal: Add extern C on eal_private.h Takuya ASADA
2015-03-12 21:05 ` [dpdk-dev] [RFC PATCH 5/7] add OSv support Takuya ASADA
2015-03-15 12:01   ` Neil Horman
2015-03-16 20:21     ` Stephen Hemminger
2015-03-16 22:42       ` Neil Horman
2015-03-21  3:23         ` Takuya ASADA
2015-03-12 21:05 ` [dpdk-dev] [RFC PATCH 6/7] virtio: enable MSI-X on OSv Takuya ASADA
2015-03-12 21:05 ` [dpdk-dev] [RFC PATCH 7/7] app/test: support OSv Takuya ASADA
2015-03-13 10:00 ` [dpdk-dev] [RFC PATCH 0/7] add OSv support Bruce Richardson
2015-03-13 19:00   ` Takuya ASADA
2015-03-21  3:25   ` Takuya ASADA
2015-03-13 13:42 ` Neil Horman
2015-03-13 19:39   ` Takuya ASADA
2015-03-21  3:22 ` [dpdk-dev] [RFC PATCHv2 0/8] " Takuya ASADA
2015-03-21  3:22   ` [dpdk-dev] [RFC PATCHv2 1/8] mk: support compiling C++ code Takuya ASADA
2015-03-21  3:22   ` [dpdk-dev] [RFC PATCHv2 2/8] eal: Add extern C on eal_hugepages.h Takuya ASADA
2015-03-21  3:23   ` [dpdk-dev] [RFC PATCHv2 3/8] eal: Add extern C on eal_thread.h Takuya ASADA
2015-03-21  3:23   ` [dpdk-dev] [RFC PATCHv2 4/8] eal: Add extern C on eal_private.h Takuya ASADA
2015-03-21  3:23   ` [dpdk-dev] [RFC PATCHv2 5/8] add OSv support Takuya ASADA
2015-03-24 13:52     ` Neil Horman
2015-04-06 19:01       ` Takuya ASADA [this message]
2015-03-21  3:23   ` [dpdk-dev] [RFC PATCHv2 6/8] virtio: enable MSI-X on OSv Takuya ASADA
2015-03-21  3:23   ` [dpdk-dev] [RFC PATCHv2 7/8] app/test: support OSv Takuya ASADA
2015-03-21  3:23   ` [dpdk-dev] [RFC PATCHv2 8/8] doc: Add Getting Started Guide for OSv Takuya ASADA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPWdggj4_zPL6z_vzFDJzyUQicrw5=_P_=KQMhwUzsT_yAtc3A@mail.gmail.com' \
    --to=syuu@cloudius-systems.com \
    --cc=dev@dpdk.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git