DPDK patches and discussions
 help / color / mirror / Atom feed
From: Marcin Wojtas <mw@semihalf.com>
To: Artur Rojek <ar@semihalf.com>
Cc: Michal Krawczyk <mk@semihalf.com>,
	Guy Tzalik <gtzalik@amazon.com>,
	 Igor Chauskin <igorch@amazon.com>,
	dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/ena/base: fix doorbell evaluation for the LLQ case
Date: Thu, 13 Aug 2020 20:07:25 +0200	[thread overview]
Message-ID: <CAPv3WKdbRo0CQRTDOR9G4ua-Zk17xqu08pyqN51K9sSKFGTnww@mail.gmail.com> (raw)
In-Reply-To: <20200812163729.4933-1-ar@semihalf.com>

Hi,

śr., 12 sie 2020 o 18:37 Artur Rojek <ar@semihalf.com> napisał(a):
>
> From: Michal Krawczyk <mk@semihalf.com>
>
> This patch adds a missing LLQ-related check in the
> ena_com_is_doorbell_needed() routine, which is relevant for the feature
> supported by the next generation HW of the ENA.
>
> Fixes: b2b02edeb0d6 ("net/ena/base: upgrade HAL for new HW features")
> CC: stable@dpdk.org
>
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> [Extracted from a bigger patch]
> Signed-off-by: Artur Rojek <ar@semihalf.com>

Reviewed-by: Marcin Wojtas <mw@semihalf.com>

> ---
>  drivers/net/ena/base/ena_eth_com.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ena/base/ena_eth_com.h b/drivers/net/ena/base/ena_eth_com.h
> index e37b642d4..3d66237b8 100644
> --- a/drivers/net/ena/base/ena_eth_com.h
> +++ b/drivers/net/ena/base/ena_eth_com.h
> @@ -133,7 +133,8 @@ static inline bool ena_com_is_doorbell_needed(struct ena_com_io_sq *io_sq,
>         llq_info = &io_sq->llq_info;
>         num_descs = ena_tx_ctx->num_bufs;
>
> -       if (unlikely(ena_com_meta_desc_changed(io_sq, ena_tx_ctx)))
> +       if (llq_info->disable_meta_caching ||
> +           unlikely(ena_com_meta_desc_changed(io_sq, ena_tx_ctx)))
>                 ++num_descs;
>
>         if (num_descs > llq_info->descs_num_before_header) {
> --
> 2.28.0
>

  reply	other threads:[~2020-08-13 18:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-12 16:37 Artur Rojek
2020-08-13 18:07 ` Marcin Wojtas [this message]
2020-08-18 15:26   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPv3WKdbRo0CQRTDOR9G4ua-Zk17xqu08pyqN51K9sSKFGTnww@mail.gmail.com \
    --to=mw@semihalf.com \
    --cc=ar@semihalf.com \
    --cc=dev@dpdk.org \
    --cc=gtzalik@amazon.com \
    --cc=igorch@amazon.com \
    --cc=mk@semihalf.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).