From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Alexander Kozyrev <akozyrev@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Ori Kam <orika@nvidia.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Matan Azrad <matan@nvidia.com>,
"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: RE: [PATCH 3/6] ethdev: add flow rule insertion by index with pattern
Date: Wed, 25 Sep 2024 15:00:13 +0000 [thread overview]
Message-ID: <CH3PR12MB84609C226EAFF34709070792A4692@CH3PR12MB8460.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20240919004813.3158356-4-akozyrev@nvidia.com>
> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Thursday, September 19, 2024 02:48
> To: dev@dpdk.org
> Cc: Dariusz Sosnowski <dsosnowski@nvidia.com>; Ori Kam
> <orika@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas@monjalon.net>; Matan Azrad <matan@nvidia.com>;
> ferruh.yigit@amd.com; stephen@networkplumber.org
> Subject: [PATCH 3/6] ethdev: add flow rule insertion by index with pattern
>
> Add a new API to enqueue flow rule creation by index with pattern.
> The new template table rules insertion type, index-based insertion with
> pattern, requires a new flow rule creation function with both rule index and
> pattern provided.
> Packets will match on the provided pattern at the provided index.
>
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
[snip]
> +RTE_TRACE_POINT_FP(
> + rte_flow_trace_async_create_by_index,
> + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id,
> + const struct rte_flow_op_attr *op_attr,
> + const struct rte_flow_template_table *template_table,
> + uint32_t rule_index,
> + const struct rte_flow_action *actions,
> + uint8_t actions_template_index,
> + const void *user_data, const struct rte_flow *flow),
> + rte_trace_point_emit_u16(port_id);
> + rte_trace_point_emit_u32(queue_id);
> + rte_trace_point_emit_ptr(op_attr);
> + rte_trace_point_emit_ptr(template_table);
> + rte_trace_point_emit_u32(rule_index);
> + rte_trace_point_emit_ptr(actions);
> + rte_trace_point_emit_u8(actions_template_index);
> + rte_trace_point_emit_ptr(user_data);
> + rte_trace_point_emit_ptr(flow);
> +)
This tracepoint is not used anywhere and is not related to the addition of rte_flow_trace_async_create_by_index_with_pattern.
Maybe this tracepoint should be added in a separate commit?
> +RTE_TRACE_POINT_FP(
> + rte_flow_trace_async_create_by_index_with_pattern,
> + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id,
> + const struct rte_flow_op_attr *op_attr,
> + const struct rte_flow_template_table *template_table,
> + uint32_t rule_index,
> + const struct rte_flow_item *pattern,
> + uint8_t pattern_template_index,
> + const struct rte_flow_action *actions,
> + uint8_t actions_template_index,
> + const void *user_data, const struct rte_flow *flow),
> + rte_trace_point_emit_u16(port_id);
> + rte_trace_point_emit_u32(queue_id);
> + rte_trace_point_emit_ptr(op_attr);
> + rte_trace_point_emit_ptr(template_table);
> + rte_trace_point_emit_u32(rule_index);
> + rte_trace_point_emit_ptr(pattern);
> + rte_trace_point_emit_u8(pattern_template_index);
> + rte_trace_point_emit_ptr(actions);
> + rte_trace_point_emit_u8(actions_template_index);
> + rte_trace_point_emit_ptr(user_data);
> + rte_trace_point_emit_ptr(flow);
> +)
This tracepoint is not used in this commit.
Could you please add the usage?
Best regards,
Dariusz Sosnowski
next prev parent reply other threads:[~2024-09-25 15:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 0:48 [PATCH 0/6] ethdev: jump to table support Alexander Kozyrev
2024-09-19 0:48 ` [PATCH 1/6] ethdev: add insertion by index with pattern Alexander Kozyrev
2024-09-25 15:01 ` Dariusz Sosnowski
2024-09-19 0:48 ` [PATCH 2/6] app/testpmd: add index with pattern insertion type Alexander Kozyrev
2024-09-25 15:01 ` Dariusz Sosnowski
2024-09-19 0:48 ` [PATCH 3/6] ethdev: add flow rule insertion by index with pattern Alexander Kozyrev
2024-09-25 15:00 ` Dariusz Sosnowski [this message]
2024-09-19 0:48 ` [PATCH 4/6] app/testpmd: add insertion by index with pattern option Alexander Kozyrev
2024-09-25 15:01 ` Dariusz Sosnowski
2024-09-19 0:48 ` [PATCH 5/6] ethdev: add jump to table index action Alexander Kozyrev
2024-09-25 15:01 ` Dariusz Sosnowski
2024-09-19 0:48 ` [PATCH 6/6] app/testpmd: " Alexander Kozyrev
2024-09-25 15:02 ` Dariusz Sosnowski
2024-09-25 18:05 ` [PATCH v2 0/7] ethdev: jump to table support Alexander Kozyrev
2024-09-25 18:05 ` [PATCH v2 1/7] ethdev: add insertion by index with pattern Alexander Kozyrev
2024-09-26 8:23 ` Ori Kam
2024-09-25 18:05 ` [PATCH v2 2/7] app/testpmd: add index with pattern insertion type Alexander Kozyrev
2024-09-26 8:24 ` Ori Kam
2024-09-25 18:05 ` [PATCH v2 3/7] ethdev: add flow rule insertion by index with pattern Alexander Kozyrev
2024-09-26 8:26 ` Ori Kam
2024-09-25 18:05 ` [PATCH v2 4/7] app/testpmd: add insertion by index with pattern option Alexander Kozyrev
2024-09-26 8:48 ` Ori Kam
2024-09-25 18:05 ` [PATCH v2 5/7] ethdev: add jump to table index action Alexander Kozyrev
2024-09-26 8:49 ` Ori Kam
2024-09-25 18:05 ` [PATCH v2 6/7] app/testpmd: " Alexander Kozyrev
2024-09-26 8:49 ` Ori Kam
2024-09-25 18:05 ` [PATCH v2 7/7] ethdev: add trace points to flow insertion by index Alexander Kozyrev
2024-09-26 8:50 ` Ori Kam
2024-09-25 19:28 ` [PATCH v2 0/7] ethdev: jump to table support Dariusz Sosnowski
2024-09-27 1:51 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH3PR12MB84609C226EAFF34709070792A4692@CH3PR12MB8460.namprd12.prod.outlook.com \
--to=dsosnowski@nvidia.com \
--cc=akozyrev@nvidia.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).