From: Ankur Dwivedi <adwivedi@marvell.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: RE: [EXT] Re: [PATCH v2 4/5] ethdev: remove internal tracepoints from version map
Date: Mon, 13 Feb 2023 08:14:35 +0000 [thread overview]
Message-ID: <CO3PR18MB5005FB74967777056DCF1AD1DDDD9@CO3PR18MB5005.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8yHYivUUZYdqd0TTpiVKzOWbMk0UPSmWcUrJiZR+-bXyQ@mail.gmail.com>
>-----Original Message-----
>From: David Marchand <david.marchand@redhat.com>
>Sent: Friday, February 10, 2023 7:50 PM
>To: Ankur Dwivedi <adwivedi@marvell.com>
>Cc: dev@dpdk.org; thomas@monjalon.net; ferruh.yigit@amd.com; Jerin
>Jacob Kollanukkaran <jerinj@marvell.com>
>Subject: [EXT] Re: [PATCH v2 4/5] ethdev: remove internal tracepoints from
>version map
>
>External Email
>
>----------------------------------------------------------------------
>On Fri, Feb 10, 2023 at 11:35 AM Ankur Dwivedi <adwivedi@marvell.com>
>wrote:
>>
>> The internal tracepoints are removed from the version.map file.
>>
>> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
>> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
>rte_ethdev_trace.h does not need to be exported.
>
>I suggest the following addition:
>
>diff --git a/lib/ethdev/rte_ethdev_trace.h b/lib/ethdev/ethdev_trace.h
>similarity index 96% rename from lib/ethdev/rte_ethdev_trace.h rename to
>lib/ethdev/ethdev_trace.h index 1491c815c3..3f419fbfa0 100644
>--- a/lib/ethdev/rte_ethdev_trace.h
>+++ b/lib/ethdev/ethdev_trace.h
>@@ -2,8 +2,8 @@
> * Copyright(C) 2020 Marvell International Ltd.
> */
>
>-#ifndef _RTE_ETHDEV_TRACE_H_
>-#define _RTE_ETHDEV_TRACE_H_
>+#ifndef _ETHDEV_TRACE_H_
>+#define _ETHDEV_TRACE_H_
>
> /**
> * @file
>@@ -92,4 +92,4 @@ RTE_TRACE_POINT(
> }
> #endif
>
>-#endif /* _RTE_ETHDEV_TRACE_H_ */
>+#endif /* _ETHDEV_TRACE_H_ */
>diff --git a/lib/ethdev/ethdev_trace_points.c
>b/lib/ethdev/ethdev_trace_points.c
>index 2919409a15..5f08d2dfb6 100644
>--- a/lib/ethdev/ethdev_trace_points.c
>+++ b/lib/ethdev/ethdev_trace_points.c
>@@ -4,7 +4,7 @@
>
> #include <rte_trace_point_register.h>
>
>-#include <rte_ethdev_trace.h>
>+#include <ethdev_trace.h>
>
> RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_configure,
> lib.ethdev.configure)
>diff --git a/lib/ethdev/meson.build b/lib/ethdev/meson.build index
>39250b5da1..9e97f05983 100644
>--- a/lib/ethdev/meson.build
>+++ b/lib/ethdev/meson.build
>@@ -22,7 +22,6 @@ sources = files(
> headers = files(
> 'rte_cman.h',
> 'rte_ethdev.h',
>- 'rte_ethdev_trace.h',
> 'rte_ethdev_trace_fp.h',
> 'rte_dev_info.h',
> 'rte_flow.h',
>diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index
>d25db35f7f..a2d289b7a4 100644
>--- a/lib/ethdev/rte_ethdev.c
>+++ b/lib/ethdev/rte_ethdev.c
>@@ -27,7 +27,7 @@
> #include <rte_ether.h>
> #include <rte_telemetry.h>
>
>-#include "rte_ethdev_trace.h"
>+#include "ethdev_trace.h"
> #include "rte_ethdev.h"
> #include "ethdev_driver.h"
> #include "ethdev_profile.h"
>
>
>--
>David Marchand
I will include the changes in next version. Some of these changes is needed for eventdev lib also. Will include that in eventdev patch (5/5) of this series.
next prev parent reply other threads:[~2023-02-13 8:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 13:30 [PATCH v1 0/5] " Ankur Dwivedi
2023-02-09 13:30 ` [PATCH v1 1/5] mempool: " Ankur Dwivedi
2023-02-09 14:23 ` David Marchand
2023-02-10 5:32 ` [EXT] " Ankur Dwivedi
2023-02-10 5:44 ` Jerin Jacob
2023-02-10 7:00 ` [EXT] " Ankur Dwivedi
2023-02-10 7:06 ` Jerin Jacob
2023-02-10 14:24 ` David Marchand
2023-02-10 15:32 ` Jerin Jacob
2023-02-14 11:37 ` Ankur Dwivedi
2023-02-20 14:18 ` David Marchand
2023-02-09 13:30 ` [PATCH v1 2/5] cryptodev: " Ankur Dwivedi
2023-02-09 13:30 ` [PATCH v1 3/5] eal: " Ankur Dwivedi
2023-02-09 13:30 ` [PATCH v1 4/5] ethdev: " Ankur Dwivedi
2023-02-09 14:13 ` Ferruh Yigit
2023-02-09 13:30 ` [PATCH v1 5/5] eventdev: " Ankur Dwivedi
2023-02-10 10:34 ` [PATCH v2 0/5] " Ankur Dwivedi
2023-02-10 10:34 ` [PATCH v2 1/5] mempool: " Ankur Dwivedi
2023-02-10 10:34 ` [PATCH v2 2/5] cryptodev: " Ankur Dwivedi
2023-02-10 10:34 ` [PATCH v2 3/5] eal: " Ankur Dwivedi
2023-02-10 10:34 ` [PATCH v2 4/5] ethdev: " Ankur Dwivedi
2023-02-10 14:19 ` David Marchand
2023-02-13 8:14 ` Ankur Dwivedi [this message]
2023-02-10 10:34 ` [PATCH v2 5/5] eventdev: " Ankur Dwivedi
2023-02-10 13:08 ` Jerin Jacob
2023-02-15 9:42 ` [PATCH v3 0/5] " Ankur Dwivedi
2023-02-15 9:42 ` [PATCH v3 1/5] mempool: " Ankur Dwivedi
2023-02-15 9:42 ` [PATCH v3 2/5] cryptodev: " Ankur Dwivedi
2023-02-15 9:42 ` [PATCH v3 3/5] eal: " Ankur Dwivedi
2023-02-15 9:42 ` [PATCH v3 4/5] ethdev: " Ankur Dwivedi
2023-02-15 9:42 ` [PATCH v3 5/5] eventdev: " Ankur Dwivedi
2023-02-20 14:39 ` [PATCH v3 0/5] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO3PR18MB5005FB74967777056DCF1AD1DDDD9@CO3PR18MB5005.namprd18.prod.outlook.com \
--to=adwivedi@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jerinj@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).