[dpdk-dev v1] crypto/ipsec_mb: fix of qp NULL check

[dpdk-dev v1] crypto/ipsec_mb: fix of qp NULL check

[Kai Ji]

This patch fix the NULL pointer check when dereference qp and ring
lookup.

Coverity issue: 381625
Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework")
Cc: roy.fan.zhang@intel.com

Signed-off-by: Kai Ji <kai.ji@intel.com>
---
 drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
index bf18d692bd..7bb3e4d46c 100644
--- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
+++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
@@ -141,12 +141,13 @@ ipsec_mb_qp_release(struct rte_cryptodev *dev, uint16_t qp_id)
 	struct ipsec_mb_qp *qp = dev->data->queue_pairs[qp_id];
 	struct rte_ring *r = NULL;
 
-	if (qp != NULL)
+	if (!qp)
 		return 0;
 
 	if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
 		r = rte_ring_lookup(qp->name);
-		rte_ring_free(r);
+		if (r)
+			rte_ring_free(r);
 
 #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM
 		if (qp->mb_mgr)
-- 
2.17.1

RE: [dpdk-dev v1] crypto/ipsec_mb: fix of qp NULL check

[Power, Ciara]

> -----Original Message-----
> From: Ji, Kai <kai.ji@intel.com>
> Sent: Tuesday 1 November 2022 14:07
> To: dev@dpdk.org
> Cc: gakhil@marvell.com; Ji, Kai <kai.ji@intel.com>; roy.fan.zhang@intel.com;
> De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Ray Kinsella
> <mdr@ashroe.eu>; Power, Ciara <ciara.power@intel.com>
> Subject: [dpdk-dev v1] crypto/ipsec_mb: fix of qp NULL check
> 
> This patch fix the NULL pointer check when dereference qp and ring lookup.
> 
> Coverity issue: 381625
> Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework")
> Cc: roy.fan.zhang@intel.com
> 
> Signed-off-by: Kai Ji <kai.ji@intel.com>
> ---
>  drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Acked-by: Ciara Power <ciara.power@intel.com>

RE: [dpdk-dev v1] crypto/ipsec_mb: fix of qp NULL check

[Akhil Goyal]

> > Subject: [dpdk-dev v1] crypto/ipsec_mb: fix of qp NULL check
> >
> > This patch fix the NULL pointer check when dereference qp and ring lookup.
> >
> > Coverity issue: 381625
> > Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework")
> > Cc: roy.fan.zhang@intel.com
> >
> > Signed-off-by: Kai Ji <kai.ji@intel.com>
> > ---
> >  drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Acked-by: Ciara Power <ciara.power@intel.com>

Cc: stable@dpdk.org

You should use devtools/check-git-log.sh

Applied to dpdk-next-crypto
Thanks.