From: "Jiang, Cheng1" <cheng1.jiang@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Fu, Patrick" <patrick.fu@intel.com>
Subject: Re: [dpdk-dev] [PATCH 20.11] raw/ioat: added a flag to control copying handle parameters
Date: Tue, 14 Jul 2020 10:45:40 +0000 [thread overview]
Message-ID: <CY4PR11MB1639B1F6D8C45B06DBCC23E2DC610@CY4PR11MB1639.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200713132820.GI694@bricha3-MOBL.ger.corp.intel.com>
Hi Bruce,
Thank you very much for these comments which really make sense for me. I will correct these problems in the next version.
Thanks again.
Cheng
> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Monday, July 13, 2020 9:28 PM
> To: Jiang, Cheng1 <cheng1.jiang@intel.com>
> Cc: dev@dpdk.org; Fu, Patrick <patrick.fu@intel.com>
> Subject: Re: [PATCH 20.11] raw/ioat: added a flag to control copying handle
> parameters
>
> On Mon, Jul 13, 2020 at 07:15:19AM +0000, Cheng Jiang wrote:
> > Added a flag which controls whether rte_ioat_enqueue_copy and
> > rte_ioat_completed_copies function should process handle parameters to
> > improve the performance when handle parameters are not necessary to
> > use. This is targeting
> > 20.11 release.
> >
> > Signed-off-by: Cheng Jiang <Cheng1.jiang@intel.com>
> > ---
> > drivers/raw/ioat/ioat_rawdev.c | 1 +
> > drivers/raw/ioat/rte_ioat_rawdev.h | 14 +++++++++++---
> > 2 files changed, 12 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/raw/ioat/ioat_rawdev.c
> > b/drivers/raw/ioat/ioat_rawdev.c index 87fd088aa..5bf030785 100644
> > --- a/drivers/raw/ioat/ioat_rawdev.c
> > +++ b/drivers/raw/ioat/ioat_rawdev.c
> > @@ -57,6 +57,7 @@ ioat_dev_configure(const struct rte_rawdev *dev,
> rte_rawdev_obj_t config)
> > return -EINVAL;
> >
> > ioat->ring_size = params->ring_size;
> > + ioat->hdls_enable = params->hdls_enable;
> > if (ioat->desc_ring != NULL) {
> > rte_memzone_free(ioat->desc_mz);
> > ioat->desc_ring = NULL;
> > diff --git a/drivers/raw/ioat/rte_ioat_rawdev.h
> > b/drivers/raw/ioat/rte_ioat_rawdev.h
> > index f765a6557..daca04dd3 100644
> > --- a/drivers/raw/ioat/rte_ioat_rawdev.h
> > +++ b/drivers/raw/ioat/rte_ioat_rawdev.h
> > @@ -35,6 +35,7 @@
> > */
> > struct rte_ioat_rawdev_config {
> > unsigned short ring_size;
> > + bool hdls_enable;
> > };
> >
> You need a doxygen comment on the new structure member (and add to
> existing one). While it's fairly clear what ring_size parameter should do, the
> hdls_enable one needs a proper explanation.
>
> I also think you might want to investigate changing it to "hdls_disable"
> so that the default zero-value is the current behaviour. Requiring it to be set
> as 1 means that existing code will likely recompile but fail to work.
> For example, the ioat_rawdev_autotest fails on completion checks now.
next prev parent reply other threads:[~2020-07-14 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 7:15 Cheng Jiang
2020-07-13 9:31 ` Bruce Richardson
2020-07-13 9:55 ` Bruce Richardson
2020-07-13 9:59 ` Bruce Richardson
2020-07-13 13:28 ` Bruce Richardson
2020-07-14 10:45 ` Jiang, Cheng1 [this message]
2020-07-15 2:16 ` [dpdk-dev] [PATCH 20.11 v2] raw/ioat: add " Cheng Jiang
2020-07-17 12:49 ` Bruce Richardson
2020-07-21 10:15 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB1639B1F6D8C45B06DBCC23E2DC610@CY4PR11MB1639.namprd11.prod.outlook.com \
--to=cheng1.jiang@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=patrick.fu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).