From: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH] cryptodev: remove crypto list end enumerators
Date: Fri, 11 Sep 2020 05:14:40 +0000 [thread overview]
Message-ID: <CY4PR11MB1830408F2F439278A256093F9F240@CY4PR11MB1830.namprd11.prod.outlook.com> (raw)
In-Reply-To: <VI1PR04MB3168361A8E5D1F920F99412CE6270@VI1PR04MB3168.eurprd04.prod.outlook.com>
HI Akhil,
> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: czwartek, 10 września 2020 20:57
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>
> Subject: RE: [PATCH] cryptodev: remove crypto list end enumerators
>
> Hi Arek,
>
> > This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END,
> > RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent
> some
> > problems that may arise when adding new crypto algorithms.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
>
> There is a deprecation notice to remove these enums.
> You should remove that.
> Please have a single series for removal of all LIST END including the Asym crypto.
Reason that I have removed LIST_ENDs separately from symmetric and asymmetric is that asymmetric
API Is experimental so it did not need notice, but if really needed I can combine it into one patch in v2.
>
> And I can see that these **LIST_END are getting used in some of the crypto
> PMDs.
> Please remove all those references and cc changes to the respective PMD
> maintainer.
I have informed "off the list" maintainers of PMDs that are using LIST_ENDS about this patch, so they should be sending patches soon, but if needed I can do it too in v2.
>
> Regards,
> Akhil
next prev parent reply other threads:[~2020-09-11 5:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 15:01 Arek Kusztal
2020-09-02 15:11 ` Trahe, Fiona
2020-09-10 18:57 ` Akhil Goyal
2020-09-11 5:14 ` Kusztal, ArkadiuszX [this message]
2020-09-11 6:10 ` Akhil Goyal
2020-09-11 6:13 ` Kusztal, ArkadiuszX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB1830408F2F439278A256093F9F240@CY4PR11MB1830.namprd11.prod.outlook.com \
--to=arkadiuszx.kusztal@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).