DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH] cryptodev: remove crypto list end enumerators
Date: Fri, 11 Sep 2020 06:10:02 +0000
Message-ID: <VI1PR04MB3168549036B494EEE19644EFE6240@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CY4PR11MB1830408F2F439278A256093F9F240@CY4PR11MB1830.namprd11.prod.outlook.com>

Hi Arek,
> 
> HI Akhil,
> 
> > > This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END,
> > > RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent
> > some
> > > problems that may arise when adding new crypto algorithms.
> > >
> > > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > > ---
> >
> > There is a deprecation notice to remove these enums.
> > You should remove that.
> > Please have a single series for removal of all LIST END including the Asym
> crypto.
> 
> Reason that I have removed LIST_ENDs separately from symmetric and
> asymmetric is that asymmetric
> API Is experimental so it did not need notice, but if really needed I can combine
> it into one patch in v2.
> 
I was talking about a series of patches. Different patches in a series.

> >
> > And I can see that these **LIST_END are getting used in some of the crypto
> > PMDs.
> > Please remove all those references and cc changes to the respective PMD
> > maintainer.
> 
> I have informed "off the list" maintainers of PMDs that are using LIST_ENDS
> about this patch, so they should be sending patches soon, but if needed I can do
> it too in v2.
> 
You can add them in your v2 and cc maintainers.


  reply	other threads:[~2020-09-11  6:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-02 15:01 Arek Kusztal
2020-09-02 15:11 ` Trahe, Fiona
2020-09-10 18:57 ` Akhil Goyal
2020-09-11  5:14   ` Kusztal, ArkadiuszX
2020-09-11  6:10     ` Akhil Goyal [this message]
2020-09-11  6:13       ` Kusztal, ArkadiuszX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB3168549036B494EEE19644EFE6240@VI1PR04MB3168.eurprd04.prod.outlook.com \
    --to=akhil.goyal@nxp.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git