Re: [dpdk-dev] [RFC v3 2/8] app/testpmd: add GENEVE option item support

[Shiri Kuzin <shirik@nvidia.com>]

> -----Original Message-----
> From: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Sent: Thursday, January 14, 2021 10:09 PM
> To: Shiri Kuzin <shirik@nvidia.com>
> Cc: dpdk-dev <dev@dpdk.org>; Slava Ovsiienko <viacheslavo@nvidia.com>;
> NBU-Contact-Adrien Mazarguil <adrien.mazarguil@6wind.com>; Raslan
> Darawsheh <rasland@nvidia.com>
> Subject: Re: [dpdk-dev] [RFC v3 2/8] app/testpmd: add GENEVE option item
> support
> 
> On Wed, Dec 16, 2020 at 5:03 AM Shiri Kuzin <shirik@nvidia.com> wrote:
> >
> > From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> >
> > The patch adds the GENEVE option rte flow item support to
> > command line interpreter. The flow command with GENEVE
> > option items looks like:
> >
> >   flow create 0 ingress pattern eth / ipv4 / udp / geneve vni is 100 /
> >        geneve-opt class is 99 length is 1 type is 0 data is 0x669988 /
> >        end actions drop / end
> >
> > The option length should be specified in 32-bit words, this
> > value specifies the length of the data pattern/mask arrays (should be
> > multiplied by sizeof(uint32_t) to be expressed in bytes. If match
> > on the length itself is not needed the mask should be set to zero, in
> > this case length is used to specify the pattern/mask array lengths only.
> >
> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > ---
> :::::[snip]:::::
> > +- ``geneve-opt``: match GENEVE header option.
> > +
> > +  - ``class {unsigned}``: GENEVE option class.
> > +  - ``type {unsigned}``: GENEVE option type.
> > +  - ``length {unsigned}``: GENEVE option length in 32-bit words.
> > +  - ``data {hex string}``: GENEVE option data, the legnt is defined by
> 
> s/legnt/length
> 
> >
> > +    ``length`` field
> > +
> >  - ``vxlan-gpe``: match VXLAN-GPE header.
> >
> >    - ``vni {unsigned}``: VXLAN-GPE identifier.
> > --
> > 1.8.3.1
> >

Thank you for the comment.
I will fix this and send updated version.