DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Gavin Hu <Gavin.Hu@arm.com>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] event/octeontx2: remove WFE from dualslot dequeue
Date: Sat, 15 Feb 2020 09:43:08 +0000	[thread overview]
Message-ID: <CY4PR1801MB1863E39D7137FE7652D70AF5DE140@CY4PR1801MB1863.namprd18.prod.outlook.com> (raw)
In-Reply-To: <VI1PR08MB53766D61F56295837E4D661D8F140@VI1PR08MB5376.eurprd08.prod.outlook.com>

Hi Gavin,

>Hi Pavan,
>
>> -----Original Message-----
>> From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
>> Sent: Friday, February 14, 2020 2:45 PM
>> To: jerinj@marvell.com; Pavan Nikhilesh
><pbhagavatula@marvell.com>
>> Cc: Gavin Hu <Gavin.Hu@arm.com>; dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] event/octeontx2: remove WFE from
>dualslot
>> dequeue
>>
>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>
>> Each workslot is always bound to a specific lcore there is no multi-core
>> contention to cause cache trashing as a result it is safe to remove the
>> WFE. Also, in dual workslot dequeue work will mostlikely be available
>on
>> the pair workslot making WFE impractical.
>
>Does SSO still signal EVENTI to exit from WFE?  Then the core ignore it?

All transactions on SSO bus take the core out of WFE.

>Can this be disabled as WFE is removed?

This can't be disabled.

>
>>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>> ---
>>
>> Also, this in-turn reduces the branch misses
>>
>> Before:
>> 	0
>>
>arm_spe_0/ts_enable=1,pct_enable=1,pa_enable=1,branch_filter=1,jit
>ter=1,
>> min_latency=0/
>> 	0 dummy:u
>> 	0 llc-miss
>> 	0 tlb-miss
>> 	853 branch-miss
>> 	0 remote-access
>> 	0 l1d-miss
>>
>> After:
>> 	0
>>
>arm_spe_0/ts_enable=1,pct_enable=1,pa_enable=1,branch_filter=1,jit
>ter=1,
>> min_latency=0/
>> 	0 dummy:u
>> 	0 llc-miss
>> 	0 tlb-miss
>> 	250 branch-miss
>> 	0 remote-access
>> 	0 l1d-miss
>>
>> WFE Data:
>>
>> 0x4C40 - WFI_WFE_WAIT_CYCLES - Number of cycles waiting at a WFI
>or
>> WFE instruction.
>>
>> - WFE Cycles before the patch for Dual workslot
>> #perf stat -C 20 -e r4C40 sleep 1
>> Performance counter stats for 'CPU(s) 20':
>>
>>                264      r4C40
>>        1.002494168 seconds time elapsed
>>
>> - WFE Cycles for single workslot
>> #perf stat -C 20 -e r4C40 sleep 1
>> Performance counter stats for 'CPU(s) 20':
>>
>>        908,778,351      r4C40
>>        1.002598253 seconds time elapsed
>>
>>  drivers/event/octeontx2/otx2_worker_dual.h | 6 +-----
>>  1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/drivers/event/octeontx2/otx2_worker_dual.h
>> b/drivers/event/octeontx2/otx2_worker_dual.h
>> index 5134e3d52..c88420eb4 100644
>> --- a/drivers/event/octeontx2/otx2_worker_dual.h
>> +++ b/drivers/event/octeontx2/otx2_worker_dual.h
>> @@ -29,11 +29,7 @@ otx2_ssogws_dual_get_work(struct
>> otx2_ssogws_state *ws,
>>  		rte_prefetch_non_temporal(lookup_mem);
>>  #ifdef RTE_ARCH_ARM64
>>  	asm volatile(
>> -			"        ldr %[tag], [%[tag_loc]]    \n"
>> -			"        ldr %[wqp], [%[wqp_loc]]    \n"
>> -			"        tbz %[tag], 63, done%=      \n"
>> -			"        sevl                        \n"
>> -			"rty%=:  wfe                         \n"
>> +			"rty%=:	                             \n"
>>  			"        ldr %[tag], [%[tag_loc]]    \n"
>>  			"        ldr %[wqp], [%[wqp_loc]]    \n"
>>  			"        tbnz %[tag], 63, rty%=      \n"
>> --
>> 2.17.1


  reply	other threads:[~2020-02-15  9:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  6:45 pbhagavatula
2020-02-15  5:56 ` Gavin Hu
2020-02-15  9:43   ` Pavan Nikhilesh Bhagavatula [this message]
2020-02-15 12:23     ` Gavin Hu
2020-02-15 13:51       ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR1801MB1863E39D7137FE7652D70AF5DE140@CY4PR1801MB1863.namprd18.prod.outlook.com \
    --to=pbhagavatula@marvell.com \
    --cc=Gavin.Hu@arm.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).