DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] Build failure on Ubuntu 14.04
@ 2014-07-05 15:27 Wiles, Roger Keith
  2014-07-05 15:28 ` Wiles, Roger Keith
  2014-07-11  8:43 ` Masaru Oki
  0 siblings, 2 replies; 13+ messages in thread
From: Wiles, Roger Keith @ 2014-07-05 15:27 UTC (permalink / raw)
  To: <dev@dpdk.org>

Hi All,

I got a build failure on :

[10:20][keithw@keithw-W2600CR:umf(dev)]$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 14.04 LTS
Release:        14.04
Codename:       trusty

Looks like the skb_set_hash() function changed from:

static inline void
skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
{
    skb->rxhash = hash;
}

To:

static inline void
skb_set_hash(struct sk_buff *skb, __u32 hash, enum pkt_hash_types type)
{
    skb->l4_rxhash = (type == PKT_HASH_TYPE_L4);
    skb->rxhash = hash;
}

Compile line: 'make install T=x86_64-native-linuxapp-gcc'
...
  CC [M]  /home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o>
In file included from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0>,
                 from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31>,
                 from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31>,
                 from /home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:>
/home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:> error: conflicting types for ‘skb_set_hash’
 skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
 ^
In file included from /usr/src/linux-headers-3.13.0-30-generic/include/linux/if_ether.h:23:0,
                 from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39>,
                 from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31>,
                 from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31>,
                 from /home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:>
/usr/src/linux-headers-3.13.0-30-generic/include/linux/skbuff.h:740:1: note: previous definition of ‘skb_set_hash’ was here
 skb_set_hash(struct sk_buff *skb, __u32 hash, enum pkt_hash_types type)
 ^
make[10]: *** [/home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o]<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o]> Error 1
make[9]: *** [_module_/home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]> Error 2
make[8]: *** [sub-make] Error 2
make[7]: *** [rte_kni.ko] Error 2
make[6]: *** [kni] Error 2
make[5]: *** [linuxapp] Error 2
make[4]: *** [librte_eal] Error 2
make[3]: *** [lib] Error 2
make[2]: *** [all] Error 2
make[1]: *** [x86_64-native-linuxapp-gcc_install] Error 2
make: *** [install] Error 2

Please verify this is correct.

Thanks
++Keith

Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] Build failure on Ubuntu 14.04
  2014-07-05 15:27 [dpdk-dev] Build failure on Ubuntu 14.04 Wiles, Roger Keith
@ 2014-07-05 15:28 ` Wiles, Roger Keith
  2014-07-05 15:50   ` Wiles, Roger Keith
  2014-07-11  8:43 ` Masaru Oki
  1 sibling, 1 reply; 13+ messages in thread
From: Wiles, Roger Keith @ 2014-07-05 15:28 UTC (permalink / raw)
  To: <dev@dpdk.org>

Forgot the uname -a:

Linux keithw-W2600CR 3.13.0-30-generic #54-Ubuntu SMP Mon Jun 9 22:45:01 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

On Jul 5, 2014, at 10:27 AM, Wiles, Roger Keith <keith.wiles@windriver.com<mailto:keith.wiles@windriver.com>> wrote:

Hi All,

I got a build failure on :

[10:20][keithw@keithw-W2600CR:umf(dev)]$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 14.04 LTS
Release:        14.04
Codename:       trusty

Looks like the skb_set_hash() function changed from:

static inline void
skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
{
   skb->rxhash = hash;
}

To:

static inline void
skb_set_hash(struct sk_buff *skb, __u32 hash, enum pkt_hash_types type)
{
   skb->l4_rxhash = (type == PKT_HASH_TYPE_L4);
   skb->rxhash = hash;
}

Compile line: 'make install T=x86_64-native-linuxapp-gcc'
...
 CC [M]  /home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o>
In file included from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0>,
                from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31>,
                from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31>,
                from /home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:>
/home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:> error: conflicting types for ‘skb_set_hash’
skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
^
In file included from /usr/src/linux-headers-3.13.0-30-generic/include/linux/if_ether.h:23:0,
                from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39>,
                from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31>,
                from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31>,
                from /home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:>
/usr/src/linux-headers-3.13.0-30-generic/include/linux/skbuff.h:740:1: note: previous definition of ‘skb_set_hash’ was here
skb_set_hash(struct sk_buff *skb, __u32 hash, enum pkt_hash_types type)
^
make[10]: *** [/home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o]<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o]><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o]> Error 1
make[9]: *** [_module_/home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]> Error 2
make[8]: *** [sub-make] Error 2
make[7]: *** [rte_kni.ko] Error 2
make[6]: *** [kni] Error 2
make[5]: *** [linuxapp] Error 2
make[4]: *** [librte_eal] Error 2
make[3]: *** [lib] Error 2
make[2]: *** [all] Error 2
make[1]: *** [x86_64-native-linuxapp-gcc_install] Error 2
make: *** [install] Error 2

Please verify this is correct.

Thanks
++Keith

Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] Build failure on Ubuntu 14.04
  2014-07-05 15:28 ` Wiles, Roger Keith
@ 2014-07-05 15:50   ` Wiles, Roger Keith
  2014-07-07  8:13     ` Cao, Waterman
  0 siblings, 1 reply; 13+ messages in thread
From: Wiles, Roger Keith @ 2014-07-05 15:50 UTC (permalink / raw)
  To: <dev@dpdk.org>

Made sure I was up to date with Ubuntu patches, but still had the same problem.

I modified the kcompat.h file to allow the compile to continue, not sure this is a fix per say.

dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h> around line 3853

##### Changed the next line from (3,14,0) to (3,13,0)
#if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,13,0) )
#if (!(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,0)))
#ifdef NETIF_F_RXHASH
#define PKT_HASH_TYPE_L3 0
static inline void
skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
{
    skb->rxhash = hash;
}
#endif /* NETIF_F_RXHASH */
#endif /* < RHEL7 */
#endif /* < 3.14.0 */

Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

On Jul 5, 2014, at 10:28 AM, Wiles, Roger Keith <keith.wiles@windriver.com<mailto:keith.wiles@windriver.com>> wrote:

Forgot the uname -a:

Linux keithw-W2600CR 3.13.0-30-generic #54-Ubuntu SMP Mon Jun 9 22:45:01 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

On Jul 5, 2014, at 10:27 AM, Wiles, Roger Keith <keith.wiles@windriver.com<mailto:keith.wiles@windriver.com><mailto:keith.wiles@windriver.com>> wrote:

Hi All,

I got a build failure on :

[10:20][keithw@keithw-W2600CR:umf(dev)]$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 14.04 LTS
Release:        14.04
Codename:       trusty

Looks like the skb_set_hash() function changed from:

static inline void
skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
{
  skb->rxhash = hash;
}

To:

static inline void
skb_set_hash(struct sk_buff *skb, __u32 hash, enum pkt_hash_types type)
{
  skb->l4_rxhash = (type == PKT_HASH_TYPE_L4);
  skb->rxhash = hash;
}

Compile line: 'make install T=x86_64-native-linuxapp-gcc'
...
CC [M]  /home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o>
In file included from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0>,
               from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31>,
               from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31>,
               from /home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:>
/home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:> error: conflicting types for ‘skb_set_hash’
skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
^
In file included from /usr/src/linux-headers-3.13.0-30-generic/include/linux/if_ether.h:23:0,
               from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39>,
               from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31>,
               from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31>,
               from /home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:>
/usr/src/linux-headers-3.13.0-30-generic/include/linux/skbuff.h:740:1: note: previous definition of ‘skb_set_hash’ was here
skb_set_hash(struct sk_buff *skb, __u32 hash, enum pkt_hash_types type)
^
make[10]: *** [/home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o]<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o]><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o]><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o]> Error 1
make[9]: *** [_module_/home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]> Error 2
make[8]: *** [sub-make] Error 2
make[7]: *** [rte_kni.ko] Error 2
make[6]: *** [kni] Error 2
make[5]: *** [linuxapp] Error 2
make[4]: *** [librte_eal] Error 2
make[3]: *** [lib] Error 2
make[2]: *** [all] Error 2
make[1]: *** [x86_64-native-linuxapp-gcc_install] Error 2
make: *** [install] Error 2

Please verify this is correct.

Thanks
++Keith

Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] Build failure on Ubuntu 14.04
  2014-07-05 15:50   ` Wiles, Roger Keith
@ 2014-07-07  8:13     ` Cao, Waterman
  2014-07-07  8:39       ` De Lara Guarch, Pablo
  2014-07-11  8:00       ` Choi, Sy Jong
  0 siblings, 2 replies; 13+ messages in thread
From: Cao, Waterman @ 2014-07-07  8:13 UTC (permalink / raw)
  To: Wiles, Roger Keith (Wind River), <dev@dpdk.org>

Hi Keith,

we built the newest dpdk code on my machine, it seems OK,
please see UB14.04 info in my computer. 
System:	Ubuntu14.04
Kernel: 	3.13.0-24 X86_64
Compiler: 	GCC 4.8.2 x86_64

Can you let me know which kernel version you use?
Thanks
Waterman 

----Original Message-----
>From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wiles, Roger Keith
>Sent: Saturday, July 5, 2014 11:50 PM
>To: <dev@dpdk.org>
>Subject: Re: [dpdk-dev] Build failure on Ubuntu 14.04
>
>Made sure I was up to date with Ubuntu patches, but still had the same problem.
>
>I modified the kcompat.h file to allow the compile to continue, not sure this is a fix per say.
>
>dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h> around line 3853
>
>##### Changed the next line from (3,14,0) to (3,13,0) #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,13,0) ) #if (!(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,0))) #ifdef NETIF_F_RXHASH #define PKT_HASH_TYPE_L3 0 static inline void skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) {
>    skb->rxhash = hash;
>}
>#endif /* NETI
F_F_RXHASH */
>#endif /* < RHEL7 */
>#endif /* < 3.14.0 */
>
>Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533
>
>[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>
>
>On Jul 5, 2014, at 10:28 AM, Wiles, Roger Keith <keith.wiles@windriver.com<mailto:keith.wiles@windriver.com>> wrote:
>
>Forgot the uname -a:
>
>Linux keithw-W2600CR 3.13.0-30-generic #54-Ubuntu SMP Mon Jun 9 22:45:01 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
>
>Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533
>
>[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>
>
>On Jul 5, 2014, at 10:27 AM, Wiles, Roger Keith <keith.wiles@windriver.com<mailto:keith.wiles@windriver.com><mailto:keith.wiles@windriver.com>> wrote:
>
>Hi All,
>
>I got a build failure on :
>
>[10:20][keithw@keithw-W2600CR:umf(dev)]$ lsb_release -a No LSB modules are available.
>Distributor ID: Ubuntu
>Description:    Ubuntu 14.04 LTS
>Release:        14.04
>Codename:       trusty
>
>Looks like the skb_set_hash() function changed from:
>
>static inline void
>skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) {
>  skb->rxhash = hash;
>}
>
>To:
>
>static inline void
>skb_set_hash(struct sk_buff *skb, __u32 hash, enum pkt_hash_types type) {
>  skb->l4_rxhash = (type == PKT_HASH_TYPE_L4);
>  skb->rxhash = hash;
>}
>
>Compile line: 'make install T=x86_64-native-linuxapp-gcc'
>...
>CC [M]  /home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o>
>In file included from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0>,
>               from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31>,
>               from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31>,
>               from /home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:>
>/home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:> error: conflicting types for a€?skb_set_hasha€? skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) ^ In file included from /usr/src/linux-headers-3.13.0-30-generic/include/linux/if_ether.h:23:0,
>               from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39>,
>               from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31>,
>               from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31>,
>               from /home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:>
>/usr/src/linux-headers-3.13.0-30-generic/include/linux/skbuff.h:740:1: note: previous definition of a€?skb_set_hasha€? was here skb_set_hash(struct sk_buff *skb, __u32 hash, enum pkt_hash_types type) ^
>make[10]: *** [/home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o]<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o]><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o]><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o]> Error 1
>make[9]: *** [_module_/home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]<http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]> Error 2
>make[8]: *** [sub-make] Error 2
>make[7]: *** [rte_kni.ko] Error 2
>make[6]: *** [kni] Error 2
>make[5]: *** [linuxapp] Error 2
>make[4]: *** [librte_eal] Error 2
>make[3]: *** [lib] Error 2
>make[2]: *** [all] Error 2
>make[1]: *** [x86_64-native-linuxapp-gcc_install] Error 2
>make: *** [install] Error 2
>
>Please verify this is correct.
>
>Thanks
>++Keith
>
>Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533
>
>[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] Build failure on Ubuntu 14.04
  2014-07-07  8:13     ` Cao, Waterman
@ 2014-07-07  8:39       ` De Lara Guarch, Pablo
  2014-07-07 14:41         ` Wiles, Roger Keith
  2014-07-11  8:00       ` Choi, Sy Jong
  1 sibling, 1 reply; 13+ messages in thread
From: De Lara Guarch, Pablo @ 2014-07-07  8:39 UTC (permalink / raw)
  To: Cao, Waterman, Wiles, Roger Keith (Wind River), <dev@dpdk.org>

> 
> Hi Keith,
> 
> we built the newest dpdk code on my machine, it seems OK,
> please see UB14.04 info in my computer.
> System:	Ubuntu14.04
> Kernel: 	3.13.0-24 X86_64
> Compiler: 	GCC 4.8.2 x86_64
> 
> Can you let me know which kernel version you use?

Apparently, it is this one: 3.13.0-30-generic, from uname -a

> Thanks
> Waterman

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] Build failure on Ubuntu 14.04
  2014-07-07  8:39       ` De Lara Guarch, Pablo
@ 2014-07-07 14:41         ` Wiles, Roger Keith
  2014-07-07 14:59           ` Wiles, Roger Keith
  2014-07-08  2:12           ` Cao, Waterman
  0 siblings, 2 replies; 13+ messages in thread
From: Wiles, Roger Keith @ 2014-07-07 14:41 UTC (permalink / raw)
  To: DE LARA GUARCH, PABLO; +Cc: <dev@dpdk.org>

Someone compiling on CentOS kernel 3.13.7 needed the original code. Looks like some other type of ifdef change needs to be done to the kcompat.h file to allow it to compile on Ubuntu 14.04 with kernel 3.13.0-30.

Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

On Jul 7, 2014, at 3:39 AM, De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com<mailto:pablo.de.lara.guarch@intel.com>> wrote:


Hi Keith,

we built the newest dpdk code on my machine, it seems OK,
please see UB14.04 info in my computer.
System:       Ubuntu14.04
Kernel:       3.13.0-24 X86_64
Compiler:     GCC 4.8.2 x86_64

Can you let me know which kernel version you use?

Apparently, it is this one: 3.13.0-30-generic, from uname -a

Thanks
Waterman

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] Build failure on Ubuntu 14.04
  2014-07-07 14:41         ` Wiles, Roger Keith
@ 2014-07-07 14:59           ` Wiles, Roger Keith
  2014-07-07 15:24             ` Wiles, Roger Keith
  2014-07-08  2:12           ` Cao, Waterman
  1 sibling, 1 reply; 13+ messages in thread
From: Wiles, Roger Keith @ 2014-07-07 14:59 UTC (permalink / raw)
  To: DE LARA GUARCH, PABLO; +Cc: <dev@dpdk.org>

The guy using CentOS stated if he changed the code to compare with KERNEL_VERSION(3,13,8) it works.

Also the compiler is older on CentOS gcc 4.4.7 and has a problem with the:
"--param max-inline-insns-single=100" issue in librte_eal/linuxapp/igb_uio/Makefile

Giving the error:
"error: inlining failed in call to 'kzalloc.clone.0': --param max-inline-insns-single limit reached" when compiling igb_uio.o

He suggested increasing the value to 1000, but he got that suggestion from stack overflow site.

I do not use CentOS and can not verify the issues or fix.

Thanks
++Keith

Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

On Jul 7, 2014, at 9:41 AM, Wiles, Roger Keith <keith.wiles@windriver.com<mailto:keith.wiles@windriver.com>> wrote:

Someone compiling on CentOS kernel 3.13.7 needed the original code. Looks like some other type of ifdef change needs to be done to the kcompat.h file to allow it to compile on Ubuntu 14.04 with kernel 3.13.0-30.

Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

On Jul 7, 2014, at 3:39 AM, De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com<mailto:pablo.de.lara.guarch@intel.com><mailto:pablo.de.lara.guarch@intel.com>> wrote:


Hi Keith,

we built the newest dpdk code on my machine, it seems OK,
please see UB14.04 info in my computer.
System:       Ubuntu14.04
Kernel:       3.13.0-24 X86_64
Compiler:     GCC 4.8.2 x86_64

Can you let me know which kernel version you use?

Apparently, it is this one: 3.13.0-30-generic, from uname -a

Thanks
Waterman

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] Build failure on Ubuntu 14.04
  2014-07-07 14:59           ` Wiles, Roger Keith
@ 2014-07-07 15:24             ` Wiles, Roger Keith
  2014-07-16 16:48               ` Murugesan, AnbarasanX
  0 siblings, 1 reply; 13+ messages in thread
From: Wiles, Roger Keith @ 2014-07-07 15:24 UTC (permalink / raw)
  To: DE LARA GUARCH, PABLO; +Cc: <dev@dpdk.org>


BTW, he changed the value from 100 to 400 and that fixed his compile problem on CentOS.

Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

On Jul 7, 2014, at 9:59 AM, Wiles, Roger Keith <keith.wiles@windriver.com<mailto:keith.wiles@windriver.com>> wrote:

The guy using CentOS stated if he changed the code to compare with KERNEL_VERSION(3,13,8) it works.

Also the compiler is older on CentOS gcc 4.4.7 and has a problem with the:
"--param max-inline-insns-single=100" issue in librte_eal/linuxapp/igb_uio/Makefile

Giving the error:
"error: inlining failed in call to 'kzalloc.clone.0': --param max-inline-insns-single limit reached" when compiling igb_uio.o

He suggested increasing the value to 1000, but he got that suggestion from stack overflow site.

I do not use CentOS and can not verify the issues or fix.

Thanks
++Keith

Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

On Jul 7, 2014, at 9:41 AM, Wiles, Roger Keith <keith.wiles@windriver.com<mailto:keith.wiles@windriver.com><mailto:keith.wiles@windriver.com>> wrote:

Someone compiling on CentOS kernel 3.13.7 needed the original code. Looks like some other type of ifdef change needs to be done to the kcompat.h file to allow it to compile on Ubuntu 14.04 with kernel 3.13.0-30.

Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

On Jul 7, 2014, at 3:39 AM, De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com<mailto:pablo.de.lara.guarch@intel.com><mailto:pablo.de.lara.guarch@intel.com><mailto:pablo.de.lara.guarch@intel.com>> wrote:


Hi Keith,

we built the newest dpdk code on my machine, it seems OK,
please see UB14.04 info in my computer.
System:       Ubuntu14.04
Kernel:       3.13.0-24 X86_64
Compiler:     GCC 4.8.2 x86_64

Can you let me know which kernel version you use?

Apparently, it is this one: 3.13.0-30-generic, from uname -a

Thanks
Waterman

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] Build failure on Ubuntu 14.04
  2014-07-07 14:41         ` Wiles, Roger Keith
  2014-07-07 14:59           ` Wiles, Roger Keith
@ 2014-07-08  2:12           ` Cao, Waterman
  2014-07-08 14:35             ` Wiles, Roger Keith
  1 sibling, 1 reply; 13+ messages in thread
From: Cao, Waterman @ 2014-07-08  2:12 UTC (permalink / raw)
  To: Wiles, Roger Keith (Wind River), De Lara Guarch, Pablo
  Cc: <dev@dpdk.org>

Thanks Keith.
we will try to enable CentOS in our daily build test.
But I has a little concern about Ubuntu 14.
We enabled latest UB14 with kernel 3.13.0-24 at this may.
It seems that UB LTS will upgrade Linux kernel to 3.13.0-30.
But we don't know when it upgrade, and it will cost a lot of effort to upgrade environment.
Can we indicate specific version for Ubuntu 14.04?
Btw, we met the same issue in RedHat 7.0 Beta version.

Waterman

From: Wiles, Roger Keith [mailto:keith.wiles@windriver.com]
Sent: Monday, July 7, 2014 10:42 PM
To: De Lara Guarch, Pablo
Cc: Cao, Waterman; <dev@dpdk.org>
Subject: Re: [dpdk-dev] Build failure on Ubuntu 14.04

Someone compiling on CentOS kernel 3.13.7 needed the original code. Looks like some other type of ifdef change needs to be done to the kcompat.h file to allow it to compile on Ubuntu 14.04 with kernel 3.13.0-30.

Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

On Jul 7, 2014, at 3:39 AM, De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com<mailto:pablo.de.lara.guarch@intel.com>> wrote:



Hi Keith,

we built the newest dpdk code on my machine, it seems OK,
please see UB14.04 info in my computer.
System:       Ubuntu14.04
Kernel:       3.13.0-24 X86_64
Compiler:     GCC 4.8.2 x86_64

Can you let me know which kernel version you use?

Apparently, it is this one: 3.13.0-30-generic, from uname -a


Thanks
Waterman

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] Build failure on Ubuntu 14.04
  2014-07-08  2:12           ` Cao, Waterman
@ 2014-07-08 14:35             ` Wiles, Roger Keith
  0 siblings, 0 replies; 13+ messages in thread
From: Wiles, Roger Keith @ 2014-07-08 14:35 UTC (permalink / raw)
  To: CAO, SHUI; +Cc: <dev@dpdk.org>

Here is the release information I have, if you want more let me know.

$sudo apt-get update
$sudo apt-get upgrade

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 14.04 LTS
Release:        14.04
Codename:       trusty

$ uname -a
Linux keithw-W2600CR 3.13.0-30-generic #55-Ubuntu SMP Fri Jul 4 21:40:53 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

$ gcc --version
gcc (Ubuntu 4.8.2-19ubuntu1) 4.8.2
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

On Jul 7, 2014, at 9:12 PM, Cao, Waterman <waterman.cao@intel.com<mailto:waterman.cao@intel.com>> wrote:

Thanks Keith.
we will try to enable CentOS in our daily build test.
But I has a little concern about Ubuntu 14.
We enabled latest UB14 with kernel 3.13.0-24 at this may.
It seems that UB LTS will upgrade Linux kernel to 3.13.0-30.
But we don’t know when it upgrade, and it will cost a lot of effort to upgrade environment.
Can we indicate specific version for Ubuntu 14.04?
Btw, we met the same issue in RedHat 7.0 Beta version.

Waterman

From: Wiles, Roger Keith [mailto:keith.wiles@windriver.com]
Sent: Monday, July 7, 2014 10:42 PM
To: De Lara Guarch, Pablo
Cc: Cao, Waterman; <dev@dpdk.org<mailto:dev@dpdk.org>>
Subject: Re: [dpdk-dev] Build failure on Ubuntu 14.04

Someone compiling on CentOS kernel 3.13.7 needed the original code. Looks like some other type of ifdef change needs to be done to the kcompat.h file to allow it to compile on Ubuntu 14.04 with kernel 3.13.0-30.

Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

On Jul 7, 2014, at 3:39 AM, De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com<mailto:pablo.de.lara.guarch@intel.com>> wrote:



Hi Keith,

we built the newest dpdk code on my machine, it seems OK,
please see UB14.04 info in my computer.
System:       Ubuntu14.04
Kernel:       3.13.0-24 X86_64
Compiler:     GCC 4.8.2 x86_64

Can you let me know which kernel version you use?

Apparently, it is this one: 3.13.0-30-generic, from uname -a


Thanks
Waterman

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] Build failure on Ubuntu 14.04
  2014-07-07  8:13     ` Cao, Waterman
  2014-07-07  8:39       ` De Lara Guarch, Pablo
@ 2014-07-11  8:00       ` Choi, Sy Jong
  1 sibling, 0 replies; 13+ messages in thread
From: Choi, Sy Jong @ 2014-07-11  8:00 UTC (permalink / raw)
  To: Cao, Waterman, Wiles, Roger Keith (Wind River), <dev@dpdk.org>

Hi Waterman

I'm seeing the same problem, here is my Ubuntu version, I'm using ubunto desktop.
Linux schoi5-desktop 3.13.0-30-generic #55-Ubuntu SMP Fri Jul 4 21:40:53 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux


Regards,
Choi, Sy Jong
Platform Application Engineer


-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Cao, Waterman
Sent: Monday, July 07, 2014 4:13 PM
To: Wiles, Roger Keith (Wind River); <dev@dpdk.org>
Subject: Re: [dpdk-dev] Build failure on Ubuntu 14.04

Hi Keith,

we built the newest dpdk code on my machine, it seems OK, please see UB14.04 info in my computer. 
System:	Ubuntu14.04
Kernel: 	3.13.0-24 X86_64
Compiler: 	GCC 4.8.2 x86_64

Can you let me know which kernel version you use?
Thanks
Waterman 

----Original Message-----
>From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wiles, Roger Keith
>Sent: Saturday, July 5, 2014 11:50 PM
>To: <dev@dpdk.org>
>Subject: Re: [dpdk-dev] Build failure on Ubuntu 14.04
>
>Made sure I was up to date with Ubuntu patches, but still had the same problem.
>
>I modified the kcompat.h file to allow the compile to continue, not sure this is a fix per say.
>
>dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h<http://dpdk.
>org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h> around line 3853
>
>##### Changed the next line from (3,14,0) to (3,13,0) #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,13,0) ) #if (!(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,0))) #ifdef NETIF_F_RXHASH #define PKT_HASH_TYPE_L3 0 static inline void skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) {
>    skb->rxhash = hash;
>}
>#endif /* NETI
F_F_RXHASH */
>#endif /* < RHEL7 */
>#endif /* < 3.14.0 */
>
>Keith Wiles, Principal Technologist with CTO office, Wind River mobile 
>972-213-5533
>
>[Powering 30 Years of 
>Innovation]<http://www.windriver.com/announces/wr30/>
>
>On Jul 5, 2014, at 10:28 AM, Wiles, Roger Keith <keith.wiles@windriver.com<mailto:keith.wiles@windriver.com>> wrote:
>
>Forgot the uname -a:
>
>Linux keithw-W2600CR 3.13.0-30-generic #54-Ubuntu SMP Mon Jun 9 
>22:45:01 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
>
>Keith Wiles, Principal Technologist with CTO office, Wind River mobile 
>972-213-5533
>
>[Powering 30 Years of 
>Innovation]<http://www.windriver.com/announces/wr30/>
>
>On Jul 5, 2014, at 10:27 AM, Wiles, Roger Keith <keith.wiles@windriver.com<mailto:keith.wiles@windriver.com><mailto:keith.wiles@windriver.com>> wrote:
>
>Hi All,
>
>I got a build failure on :
>
>[10:20][keithw@keithw-W2600CR:umf(dev)]$ lsb_release -a No LSB modules are available.
>Distributor ID: Ubuntu
>Description:    Ubuntu 14.04 LTS
>Release:        14.04
>Codename:       trusty
>
>Looks like the skb_set_hash() function changed from:
>
>static inline void
>skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) 
>{
>  skb->rxhash = hash;
>}
>
>To:
>
>static inline void
>skb_set_hash(struct sk_buff *skb, __u32 hash, enum pkt_hash_types type) 
>{
>  skb->l4_rxhash = (type == PKT_HASH_TYPE_L4);
>  skb->rxhash = hash;
>}
>
>Compile line: 'make install T=x86_64-native-linuxapp-gcc'
>...
>CC [M]  
>/home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/li
>b/librte_eal/linuxapp/kni/e1000_82575.o<http://dpdk.org/x86_64-native-l
>inuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o><http://dpd
>k.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e100
>0_82575.o><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_
>eal/linuxapp/kni/e1000_82575.o> In file included from 
>/home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0>,
>               from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31>,
>               from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31>,
>               from 
>/home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/li
>b/librte_eal/linuxapp/kni/e1000_82575.c:38:<http://dpdk.org/x86_64-nati
>ve-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:><ht
>tp://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/
>kni/e1000_82575.c:38:><http://dpdk.org/x86_64-native-linuxapp-gcc/build
>/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:>
>/home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:> error: conflicting types for a€?skb_set_hasha€? skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) ^ In file included from /usr/src/linux-headers-3.13.0-30-generic/include/linux/if_ether.h:23:0,
>               from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39>,
>               from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31>,
>               from /home/keithw/projects/dpdk/dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31<http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31><http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31>,
>               from 
>/home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/li
>b/librte_eal/linuxapp/kni/e1000_82575.c:38:<http://dpdk.org/x86_64-nati
>ve-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:><ht
>tp://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/
>kni/e1000_82575.c:38:><http://dpdk.org/x86_64-native-linuxapp-gcc/build
>/lib/librte_eal/linuxapp/kni/e1000_82575.c:38:>
>/usr/src/linux-headers-3.13.0-30-generic/include/linux/skbuff.h:740:1: 
>note: previous definition of a€?skb_set_hasha€? was here 
>skb_set_hash(struct sk_buff *skb, __u32 hash, enum pkt_hash_types type) 
>^
>make[10]: *** 
>[/home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc/build/l
>ib/librte_eal/linuxapp/kni/e1000_82575.o]<http://dpdk.org/x86_64-native
>-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o]><http://
>dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e
>1000_82575.o]><http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/lib
>rte_eal/linuxapp/kni/e1000_82575.o]> Error 1
>make[9]: *** 
>[_module_/home/keithw/projects/dpdk/dpdk.org/x86_64-native-linuxapp-gcc
>/build/lib/librte_eal/linuxapp/kni]<http://dpdk.org/x86_64-native-linux
>app-gcc/build/lib/librte_eal/linuxapp/kni]><http://dpdk.org/x86_64-nati
>ve-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]><http://dpdk.org/x86
>_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]> Error 2
>make[8]: *** [sub-make] Error 2
>make[7]: *** [rte_kni.ko] Error 2
>make[6]: *** [kni] Error 2
>make[5]: *** [linuxapp] Error 2
>make[4]: *** [librte_eal] Error 2
>make[3]: *** [lib] Error 2
>make[2]: *** [all] Error 2
>make[1]: *** [x86_64-native-linuxapp-gcc_install] Error 2
>make: *** [install] Error 2
>
>Please verify this is correct.
>
>Thanks
>++Keith
>
>Keith Wiles, Principal Technologist with CTO office, Wind River mobile 
>972-213-5533
>
>[Powering 30 Years of 
>Innovation]<http://www.windriver.com/announces/wr30/>
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] Build failure on Ubuntu 14.04
  2014-07-05 15:27 [dpdk-dev] Build failure on Ubuntu 14.04 Wiles, Roger Keith
  2014-07-05 15:28 ` Wiles, Roger Keith
@ 2014-07-11  8:43 ` Masaru Oki
  1 sibling, 0 replies; 13+ messages in thread
From: Masaru Oki @ 2014-07-11  8:43 UTC (permalink / raw)
  To: Wiles, Roger Keith; +Cc: <dev@dpdk.org>

Hi,

I tried another workaround and works fine:
It similar to other kcompat function, add __kc_ prefix to function
definition
and #define skb_set_hash(a,b,c) __kc_skb_set_hash(a,b,c).

Thanks,



2014-07-06 0:27 GMT+09:00 Wiles, Roger Keith <keith.wiles@windriver.com>:

> Hi All,
>
> I got a build failure on :
>
> [10:20][keithw@keithw-W2600CR:umf(dev)]$ lsb_release -a
> No LSB modules are available.
> Distributor ID: Ubuntu
> Description:    Ubuntu 14.04 LTS
> Release:        14.04
> Codename:       trusty
>
> Looks like the skb_set_hash() function changed from:
>
> static inline void
> skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
> {
>     skb->rxhash = hash;
> }
>
> To:
>
> static inline void
> skb_set_hash(struct sk_buff *skb, __u32 hash, enum pkt_hash_types type)
> {
>     skb->l4_rxhash = (type == PKT_HASH_TYPE_L4);
>     skb->rxhash = hash;
> }
>
> Compile line: 'make install T=x86_64-native-linuxapp-gcc'
> ...
>   CC [M]  /home/keithw/projects/dpdk/
> dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o
> <
> http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o
> >
> In file included from /home/keithw/projects/dpdk/
> dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0<
> http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41:0
> >,
>                  from /home/keithw/projects/dpdk/
> dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31<
> http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31>,
>                  from /home/keithw/projects/dpdk/
> dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31<
> http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31>,
>                  from /home/keithw/projects/dpdk/
> dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38
> :<
> http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38
> :>
> /home/keithw/projects/dpdk/
> dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:<
> http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3853:1:>
> error: conflicting types for ‘skb_set_hash’
>  skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
>  ^
> In file included from
> /usr/src/linux-headers-3.13.0-30-generic/include/linux/if_ether.h:23:0,
>                  from /home/keithw/projects/dpdk/
> dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39<
> http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39>,
>                  from /home/keithw/projects/dpdk/
> dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31<
> http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31>,
>                  from /home/keithw/projects/dpdk/
> dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31<
> http://dpdk.org/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31>,
>                  from /home/keithw/projects/dpdk/
> dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38
> :<
> http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.c:38
> :>
> /usr/src/linux-headers-3.13.0-30-generic/include/linux/skbuff.h:740:1:
> note: previous definition of ‘skb_set_hash’ was here
>  skb_set_hash(struct sk_buff *skb, __u32 hash, enum pkt_hash_types type)
>  ^
> make[10]: *** [/home/keithw/projects/dpdk/
> dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o
> ]<
> http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_82575.o]>
> Error 1
> make[9]: *** [_module_/home/keithw/projects/dpdk/
> dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]<
> http://dpdk.org/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni]>
> Error 2
> make[8]: *** [sub-make] Error 2
> make[7]: *** [rte_kni.ko] Error 2
> make[6]: *** [kni] Error 2
> make[5]: *** [linuxapp] Error 2
> make[4]: *** [librte_eal] Error 2
> make[3]: *** [lib] Error 2
> make[2]: *** [all] Error 2
> make[1]: *** [x86_64-native-linuxapp-gcc_install] Error 2
> make: *** [install] Error 2
>
> Please verify this is correct.
>
> Thanks
> ++Keith
>
> Keith Wiles, Principal Technologist with CTO office, Wind River
> mobile 972-213-5533
>
> [Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/
> >
>
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] Build failure on Ubuntu 14.04
  2014-07-07 15:24             ` Wiles, Roger Keith
@ 2014-07-16 16:48               ` Murugesan, AnbarasanX
  0 siblings, 0 replies; 13+ messages in thread
From: Murugesan, AnbarasanX @ 2014-07-16 16:48 UTC (permalink / raw)
  To: Wiles, Roger Keith (Wind River), De Lara Guarch, Pablo
  Cc: <dev@dpdk.org>

Keith,

I've observed same problem on our platforms. I'm using compiled kernel 3.14.11 on top of CentOS 6.5.

After modifying the value from 100 to 400 in Makefile for max-inline-insns-single parameter, I am able to compile DPDK 1.7.0 successfully.

--anbu-

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wiles, Roger Keith
Sent: Monday, July 07, 2014 8:24 AM
To: De Lara Guarch, Pablo
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] Build failure on Ubuntu 14.04


BTW, he changed the value from 100 to 400 and that fixed his compile problem on CentOS.

Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

On Jul 7, 2014, at 9:59 AM, Wiles, Roger Keith <keith.wiles@windriver.com<mailto:keith.wiles@windriver.com>> wrote:

The guy using CentOS stated if he changed the code to compare with KERNEL_VERSION(3,13,8) it works.

Also the compiler is older on CentOS gcc 4.4.7 and has a problem with the:
"--param max-inline-insns-single=100" issue in librte_eal/linuxapp/igb_uio/Makefile

Giving the error:
"error: inlining failed in call to 'kzalloc.clone.0': --param max-inline-insns-single limit reached" when compiling igb_uio.o

He suggested increasing the value to 1000, but he got that suggestion from stack overflow site.

I do not use CentOS and can not verify the issues or fix.

Thanks
++Keith

Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

On Jul 7, 2014, at 9:41 AM, Wiles, Roger Keith <keith.wiles@windriver.com<mailto:keith.wiles@windriver.com><mailto:keith.wiles@windriver.com>> wrote:

Someone compiling on CentOS kernel 3.13.7 needed the original code. Looks like some other type of ifdef change needs to be done to the kcompat.h file to allow it to compile on Ubuntu 14.04 with kernel 3.13.0-30.

Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533

[Powering 30 Years of Innovation]<http://www.windriver.com/announces/wr30/>

On Jul 7, 2014, at 3:39 AM, De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com<mailto:pablo.de.lara.guarch@intel.com><mailto:pablo.de.lara.guarch@intel.com><mailto:pablo.de.lara.guarch@intel.com>> wrote:


Hi Keith,

we built the newest dpdk code on my machine, it seems OK, please see UB14.04 info in my computer.
System:       Ubuntu14.04
Kernel:       3.13.0-24 X86_64
Compiler:     GCC 4.8.2 x86_64

Can you let me know which kernel version you use?

Apparently, it is this one: 3.13.0-30-generic, from uname -a

Thanks
Waterman

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2014-07-16 16:48 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-05 15:27 [dpdk-dev] Build failure on Ubuntu 14.04 Wiles, Roger Keith
2014-07-05 15:28 ` Wiles, Roger Keith
2014-07-05 15:50   ` Wiles, Roger Keith
2014-07-07  8:13     ` Cao, Waterman
2014-07-07  8:39       ` De Lara Guarch, Pablo
2014-07-07 14:41         ` Wiles, Roger Keith
2014-07-07 14:59           ` Wiles, Roger Keith
2014-07-07 15:24             ` Wiles, Roger Keith
2014-07-16 16:48               ` Murugesan, AnbarasanX
2014-07-08  2:12           ` Cao, Waterman
2014-07-08 14:35             ` Wiles, Roger Keith
2014-07-11  8:00       ` Choi, Sy Jong
2014-07-11  8:43 ` Masaru Oki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).