From: "Wang, Yipeng1" <yipeng1.wang@intel.com> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, Thomas Monjalon <thomas@monjalon.net>, "Richardson, Bruce" <bruce.richardson@intel.com> Cc: "stable@dpdk.org" <stable@dpdk.org>, "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>, nd <nd@arm.com> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/4] hash: add local cache for TSX region Date: Tue, 13 Nov 2018 17:24:55 +0000 Message-ID: <D2C4A16CA39F7F4E8E384D204491D7A6615164B5@ORSMSX105.amr.corp.intel.com> (raw) In-Reply-To: <AM6PR08MB3672C5623918F5A5582FD95D98C20@AM6PR08MB3672.eurprd08.prod.outlook.com> >-----Original Message----- >From: Honnappa Nagarahalli [mailto:Honnappa.Nagarahalli@arm.com] >Sent: Tuesday, November 13, 2018 9:17 AM >To: Thomas Monjalon <thomas@monjalon.net>; Richardson, Bruce <bruce.richardson@intel.com>; Wang, Yipeng1 ><yipeng1.wang@intel.com> >Cc: stable@dpdk.org; dev@dpdk.org; nd <nd@arm.com>; nd <nd@arm.com> >Subject: RE: [dpdk-stable] [dpdk-dev] [PATCH v2 2/4] hash: add local cache for TSX region >> > > /* Check extra flags field to check extra options. */ >> > > - if (params->extra_flag & >> > > RTE_HASH_EXTRA_FLAGS_TRANS_MEM_SUPPORT) >> > > + if (params->extra_flag & >> > > RTE_HASH_EXTRA_FLAGS_TRANS_MEM_SUPPORT) { >> > > + use_local_cache = 1; >> > Do you see the issue even in the case of single writer? Enabling this flag >> creates local caches on all the data plane cores. This increases the memory >> usage for the single writer use case. Then there is 'writers on the control >> plane' use case, the requirement on hash_add rate is comparatively lower >> when compared to 'writers on the data plane'. The writers also are not pinned >> to any core as well. In this use case, I am not sure how much having a local >> cache matters. >> > >> > Enabling this flag effectively changes the free slot allocation from a ring to a >> stack data structure. Does it indicate that for single writer use case with TSX, >> the free slot (global) data structure should be a stack (rather than a ring)? >> >> Is it blocking this patchset from entering in 18.11? >> If I understand well, there are some fixes for 18.11. [Wang, Yipeng] Hi Thomas, please go ahead merge the other commits without this one since Honnapa's concern. I will talk with Honnappa separately on a better way to do this. Thanks! >> >I am fine with the other fixes in this patchset
next prev parent reply other threads:[~2018-11-13 17:24 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-05 17:39 [dpdk-dev] [PATCH 0/4] fixes for rte_hash with TSX Bruce Richardson 2018-11-05 17:39 ` [dpdk-dev] [PATCH 1/4] hash: fix TSX aborts with newer gcc Bruce Richardson 2018-11-05 17:39 ` [dpdk-dev] [PATCH 2/4] hash: add local cache for TSX region Bruce Richardson 2018-11-09 15:59 ` Bruce Richardson 2018-11-05 17:39 ` [dpdk-dev] [PATCH 3/4] eal/x86: reduce contention when retrying TSX Bruce Richardson 2018-11-05 17:39 ` [dpdk-dev] [PATCH 4/4] test/test: improve output for hash read-write test Bruce Richardson 2018-11-12 10:47 ` [dpdk-dev] [PATCH v2 0/4] fixes for rte_hash with TSX Bruce Richardson 2018-11-12 10:47 ` [dpdk-dev] [PATCH v2 1/4] hash: fix TSX aborts with newer gcc Bruce Richardson 2018-11-12 10:47 ` [dpdk-dev] [PATCH v2 2/4] hash: add local cache for TSX region Bruce Richardson 2018-11-12 18:34 ` Honnappa Nagarahalli 2018-11-13 16:40 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 2018-11-13 17:16 ` Honnappa Nagarahalli 2018-11-13 17:24 ` Wang, Yipeng1 [this message] 2018-11-13 17:48 ` Bruce Richardson 2018-11-12 10:47 ` [dpdk-dev] [PATCH v2 3/4] eal/x86: reduce contention when retrying TSX Bruce Richardson 2018-11-12 10:47 ` [dpdk-dev] [PATCH v2 4/4] test/test: improve output for hash read-write test Bruce Richardson 2018-11-14 0:06 ` [dpdk-dev] [PATCH v2 0/4] fixes for rte_hash with TSX Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=D2C4A16CA39F7F4E8E384D204491D7A6615164B5@ORSMSX105.amr.corp.intel.com \ --to=yipeng1.wang@intel.com \ --cc=Honnappa.Nagarahalli@arm.com \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=nd@arm.com \ --cc=stable@dpdk.org \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git