[dpdk-dev] Pktgen-DPDK build errors on ppc64le

[dpdk-dev] Pktgen-DPDK build errors on ppc64le

[Rahul Lakkireddy]

Hi All,

We are seeing Pktgen-DPDK not building on ppc64le with latest dpdk git
repo.

Below build errors are seen:
-------------------------
[pktgen-dpdk]# make
== lib
== common
  CC l2p.o
In file included from /root/pktgen-dpdk/lib/common/l2p.c:88:0:
/root/pktgen-dpdk/lib/common/l2p.h: In function ‘pg_raw_dump_l2p’:
/root/pktgen-dpdk/lib/common/l2p.h:103:2: error: comparison is always true due to limited range of data type [-Werror=type-limits]
  for (i = 0; i  < RTE_MAX_LCORE; i++)
  ^
/root/pktgen-dpdk/lib/common/l2p.h:109:2: error: comparison is always true due to limited range of data type [-Werror=type-limits]
  for (j = 0; j < RTE_MAX_LCORE; j++) {
  ^
/root/pktgen-dpdk/lib/common/l2p.h: In function ‘pg_dump_l2p’:
/root/pktgen-dpdk/lib/common/l2p.h:486:2: error: comparison is always true due to limited range of data type [-Werror=type-limits]
  for (lid = 0; lid < RTE_MAX_LCORE; lid++) {
  ^
/root/pktgen-dpdk/lib/common/l2p.c: In function ‘pg_port_matrix_dump’:
/root/pktgen-dpdk/lib/common/l2p.c:477:3: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
   cnt.rxtx = get_map(l2p, pid, RTE_MAX_LCORE);
   ^
/root/pktgen-dpdk/lib/common/l2p.c:488:3: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
   cnt.rxtx = get_map(l2p, pid, RTE_MAX_LCORE);
   ^
cc1: all warnings being treated as errors
make[3]: *** [l2p.o] Error 1
make[2]: *** [all] Error 2
make[1]: *** [common] Error 2
make: *** [lib] Error 2
-------------------------

By changing CONFIG_RTE_MAX_LCORE to 128 in defconfig_ppc_64-power8-linuxapp-gcc
file, Pktgen-DPDK then builds fine.

Thanks,
Rahul

Re: [dpdk-dev] Pktgen-DPDK build errors on ppc64le

[Wiles, Keith]

> On Feb 28, 2017, at 2:48 AM, Rahul Lakkireddy <rahul.lakkireddy@chelsio.com> wrote:
> 
> Hi All,
> 
> We are seeing Pktgen-DPDK not building on ppc64le with latest dpdk git
> repo.

Yes, it looks like Pktgen needs to change to account for 256 cores. It is using uint8_t and needs to change to uint16_t variables. I can only suggest you can change the sizes in the places the compiler gives an error. I will try to get Pktgen updated to fix this issue in the next release.

> 
> Below build errors are seen:
> -------------------------
> [pktgen-dpdk]# make
> == lib
> == common
>  CC l2p.o
> In file included from /root/pktgen-dpdk/lib/common/l2p.c:88:0:
> /root/pktgen-dpdk/lib/common/l2p.h: In function ‘pg_raw_dump_l2p’:
> /root/pktgen-dpdk/lib/common/l2p.h:103:2: error: comparison is always true due to limited range of data type [-Werror=type-limits]
>  for (i = 0; i  < RTE_MAX_LCORE; i++)
>  ^
> /root/pktgen-dpdk/lib/common/l2p.h:109:2: error: comparison is always true due to limited range of data type [-Werror=type-limits]
>  for (j = 0; j < RTE_MAX_LCORE; j++) {
>  ^
> /root/pktgen-dpdk/lib/common/l2p.h: In function ‘pg_dump_l2p’:
> /root/pktgen-dpdk/lib/common/l2p.h:486:2: error: comparison is always true due to limited range of data type [-Werror=type-limits]
>  for (lid = 0; lid < RTE_MAX_LCORE; lid++) {
>  ^
> /root/pktgen-dpdk/lib/common/l2p.c: In function ‘pg_port_matrix_dump’:
> /root/pktgen-dpdk/lib/common/l2p.c:477:3: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
>   cnt.rxtx = get_map(l2p, pid, RTE_MAX_LCORE);
>   ^
> /root/pktgen-dpdk/lib/common/l2p.c:488:3: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
>   cnt.rxtx = get_map(l2p, pid, RTE_MAX_LCORE);
>   ^
> cc1: all warnings being treated as errors
> make[3]: *** [l2p.o] Error 1
> make[2]: *** [all] Error 2
> make[1]: *** [common] Error 2
> make: *** [lib] Error 2
> -------------------------
> 
> By changing CONFIG_RTE_MAX_LCORE to 128 in defconfig_ppc_64-power8-linuxapp-gcc
> file, Pktgen-DPDK then builds fine.
> 
> Thanks,
> Rahul

Regards,
Keith