From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>
Cc: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>, Phil Yang <Phil.Yang@arm.com>,
"techboard@dpdk.org" <techboard@dpdk.org>, nd <nd@arm.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] Using C11 atomic semantic
Date: Mon, 20 Jul 2020 19:36:13 +0000 [thread overview]
Message-ID: <DB6PR0802MB22168E50E2ADBB3054F15543987B0@DB6PR0802MB2216.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <3186466.fdGK1iNSLM@thomas>
<snip>
>
> 20/07/2020 17:44, Honnappa Nagarahalli:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > >
> > > In the techboard of April 22, it has been decided to block patches
> > > using rte_atomicNN_xx and rte_smp_*mb APIs, starting DPDK 20.08.
> > > Meeting minutes:
> > > http://mails.dpdk.org/archives/dev/2020-April/165143.html
> > > Deprecation notice:
> > > http://doc.dpdk.org/guides/rel_notes/deprecation.html
> > >
> > > Some doc has been submitted to help understanding how to manage
> atomics:
> > > http://doc
> .dpdk.org/guides/prog_guide/writing_efficient_code.html#locks-and-
> > > atomic-operations
> > >
> > > Unfortunately the tool to check new code was merged last week:
> > > http://git.dpdk.org/dpdk/commit/?id=f1602b4a86
> > >
> > > As a consequence, I propose to apply the "reject rule" starting DPDK 20.11.
> >
> > As far as I know no patch with rte_atomic has gone in 20.08 so far. Are there
> any patches in RC2/RC3 that need rte_atomic APIs?
>
> Yes we have the case of an additional call added in 20.08-rc2 in mlx5 (not yet
> converted to C11 atomics).
There is one patch that Phil had put together [1] for mlx5.
Since this is a unconverted module, suggest allowing for 20.08 instead of removing the 'reject rule' patch.
[1] https://patches.dpdk.org/patch/72007/
>
> > > Can we make this rule better advertised with an announce message?
> >
> > Do you mean an email on dpdk-announce mailing list?
>
> Yes
>
> > > Are the current technical explanations enough?
> >
> > The documentation patch you referenced above covers most common cases
> people will encounter. Even the rte_ring/rte_stack algorithms work on the
> same principles.
> >
> > > If not, it would be wonderful to have a blog post explaining the
> > > details, as part of an announce.
> >
> > This is in the works. The plan is to send it to you soon and get it out along
> with the release.
>
> Great
>
prev parent reply other threads:[~2020-07-20 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 15:34 Thomas Monjalon
2020-07-20 15:44 ` Honnappa Nagarahalli
2020-07-20 16:39 ` Thomas Monjalon
2020-07-20 19:36 ` Honnappa Nagarahalli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0802MB22168E50E2ADBB3054F15543987B0@DB6PR0802MB2216.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Phil.Yang@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nd@arm.com \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).