From: Shahaf Shuler <shahafs@mellanox.com>
To: Ophir Munk <ophirmu@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Adrien Mazarguil" <adrien.mazarguil@6wind.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Olga Shern <olgas@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx4: fix CRC stripping capability report
Date: Wed, 9 May 2018 11:13:28 +0000 [thread overview]
Message-ID: <DB7PR05MB44262D2DE42FDC6E46FD3AAEC3990@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1525782363-426-1-git-send-email-ophirmu@mellanox.com>
Tuesday, May 8, 2018 3:26 PM, Ophir Munk:
> Subject: [PATCH v2] net/mlx4: fix CRC stripping capability report
>
> There are two capabilities related to CRC stripping:
> 1. mlx4 HW capability to perform CRC stripping on a received packet.
> This capability is built in mlx4 HW. It should be returned by the API call
> mlx4_get_rx_queue_offloads().
> 2. mlx4 driver capability to enable/disable HW CRC stripping. This capability is
> dependent on the driver version.
> Before this commit the second capability was falsely returned by the
> mentioned API. This commit fixes it by returning the first capability.
>
> mlx4 HW performs CRC stripping by default and this capability is always
> reported as "true".
> The ability to enable/disable CRC stripping is supported since this commit and
> requires OFED version 4.3-1.5.0.0 or rdma-core version v18.
> CRC stripping will be done by default regardless of its configuration when
> working with OFED or rdma-core versions earlier than those previously
> specified or before this commit.
>
> Fixes: de1df14e6e6ec ("net/mlx4: support CRC strip toggling")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
Applied to next-net-mlx, thanks.
prev parent reply other threads:[~2018-05-09 11:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 12:25 [dpdk-dev] [PATCH v1] " Ophir Munk
2018-05-03 5:47 ` [dpdk-dev] [dpdk-stable] " Shahaf Shuler
2018-05-08 12:26 ` [dpdk-dev] [PATCH v2] " Ophir Munk
2018-05-09 11:13 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB44262D2DE42FDC6E46FD3AAEC3990@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).