* [dpdk-dev] [PATCH] net/mlx5: fix calculation of Tx TSO inline room size
@ 2018-05-08 18:48 Yongseok Koh
2018-05-09 10:06 ` [dpdk-dev] [dpdk-stable] " Shahaf Shuler
0 siblings, 1 reply; 2+ messages in thread
From: Yongseok Koh @ 2018-05-08 18:48 UTC (permalink / raw)
To: adrien.mazarguil, nelio.laranjeiro; +Cc: dev, Yongseok Koh, stable
rdma-core doesn't add up max_tso_header size to max_inline_data size. The
library takes bigger value between the two.
Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core")
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
---
drivers/net/mlx5/mlx5_txq.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
index 44358744d..12fcdda34 100644
--- a/drivers/net/mlx5/mlx5_txq.c
+++ b/drivers/net/mlx5/mlx5_txq.c
@@ -725,18 +725,6 @@ txq_set_params(struct mlx5_txq_ctrl *txq_ctrl)
inline_max_packet_sz) +
(RTE_CACHE_LINE_SIZE - 1)) /
RTE_CACHE_LINE_SIZE) * RTE_CACHE_LINE_SIZE;
- } else if (tso) {
- int inline_diff = txq_ctrl->txq.max_inline -
- max_tso_inline;
-
- /*
- * Adjust inline value as Verbs aggregates
- * tso_inline and txq_inline fields.
- */
- txq_ctrl->max_inline_data = inline_diff > 0 ?
- inline_diff *
- RTE_CACHE_LINE_SIZE :
- 0;
} else {
txq_ctrl->max_inline_data =
txq_ctrl->txq.max_inline * RTE_CACHE_LINE_SIZE;
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix calculation of Tx TSO inline room size
2018-05-08 18:48 [dpdk-dev] [PATCH] net/mlx5: fix calculation of Tx TSO inline room size Yongseok Koh
@ 2018-05-09 10:06 ` Shahaf Shuler
0 siblings, 0 replies; 2+ messages in thread
From: Shahaf Shuler @ 2018-05-09 10:06 UTC (permalink / raw)
To: Yongseok Koh, Adrien Mazarguil, Nélio Laranjeiro
Cc: dev, Yongseok Koh, stable
Tuesday, May 8, 2018 9:48 PM, Yongseok Koh:
> Subject: [dpdk-stable] [PATCH] net/mlx5: fix calculation of Tx TSO inline room
> size
>
> rdma-core doesn't add up max_tso_header size to max_inline_data size. The
> library takes bigger value between the two.
>
> Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-09 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-08 18:48 [dpdk-dev] [PATCH] net/mlx5: fix calculation of Tx TSO inline room size Yongseok Koh
2018-05-09 10:06 ` [dpdk-dev] [dpdk-stable] " Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).