DPDK patches and discussions
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	Sameh Gobriel <sameh.gobriel@intel.com>,
	Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
	 Yipeng Wang <yipeng1.wang@intel.com>,
	Stephen Hemminger <stephen@networkplumber.org>, nd <nd@arm.com>,
	nd <nd@arm.com>
Subject: RE: [PATCH 1/2] hash: replace zero length array with flex array
Date: Wed, 24 Jan 2024 22:57:43 +0000	[thread overview]
Message-ID: <DBAPR08MB5814D21A6080FB868D109069987B2@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <1706134657-17446-2-git-send-email-roretzla@linux.microsoft.com>



> -----Original Message-----
> From: Tyler Retzlaff <roretzla@linux.microsoft.com>
> Sent: Wednesday, January 24, 2024 4:18 PM
> To: dev@dpdk.org
> Cc: Bruce Richardson <bruce.richardson@intel.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Sameh Gobriel
> <sameh.gobriel@intel.com>; Vladimir Medvedkin
> <vladimir.medvedkin@intel.com>; Yipeng Wang <yipeng1.wang@intel.com>;
> Stephen Hemminger <stephen@networkplumber.org>; Tyler Retzlaff
> <roretzla@linux.microsoft.com>
> Subject: [PATCH 1/2] hash: replace zero length array with flex array
> 
> Zero length arrays are GNU extension. Replace with standard flex array.
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> ---
>  lib/hash/rte_thash.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c index e8de071..1982051
> 100644
> --- a/lib/hash/rte_thash.c
> +++ b/lib/hash/rte_thash.c
> @@ -80,7 +80,7 @@ struct rte_thash_subtuple_helper {
>  	uint32_t	tuple_offset;	/** < Offset in bits of the subtuple */
>  	uint32_t	tuple_len;	/** < Length in bits of the subtuple */
>  	uint32_t	lsb_msk;	/** < (1 << reta_sz_log) - 1 */
> -	__extension__ uint32_t	compl_table[0] __rte_cache_aligned;
> +	uint32_t	compl_table[] __rte_cache_aligned;
>  	/** < Complementary table */
>  };
> 
> @@ -93,7 +93,7 @@ struct rte_thash_ctx {
>  	uint32_t	flags;
>  	uint64_t	*matrices;
>  	/**< matrices used with rte_thash_gfni implementation */
> -	uint8_t		hash_key[0];
> +	uint8_t		hash_key[];
>  };
> 
>  int
> --
> 1.8.3.1


  reply	other threads:[~2024-01-24 22:57 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24 22:17 [PATCH 0/2] more replacement of zero length array Tyler Retzlaff
2024-01-24 22:17 ` [PATCH 1/2] hash: replace zero length array with flex array Tyler Retzlaff
2024-01-24 22:57   ` Honnappa Nagarahalli [this message]
2024-01-25  7:16   ` Morten Brørup
2024-01-24 22:17 ` [PATCH 2/2] rcu: " Tyler Retzlaff
2024-01-24 22:57   ` Honnappa Nagarahalli
2024-01-25  7:14   ` Morten Brørup
2024-01-25 12:57 ` [PATCH 0/2] more replacement of zero length array fengchengwen
2024-02-12 22:36 ` [PATCH v2 0/4] " Tyler Retzlaff
2024-02-12 22:36   ` [PATCH v2 1/4] hash: replace zero length array with flex array Tyler Retzlaff
2024-02-12 22:36   ` [PATCH v2 2/4] rcu: " Tyler Retzlaff
2024-02-12 22:36   ` [PATCH v2 3/4] fib: " Tyler Retzlaff
2024-02-12 22:36   ` [PATCH v2 4/4] pipeline: " Tyler Retzlaff
2024-02-12 22:57   ` [PATCH v2 0/4] more replacement of zero length array Stephen Hemminger
2024-02-13  8:31     ` Morten Brørup
2024-02-13 13:14   ` David Marchand
2024-02-13 19:20     ` Tyler Retzlaff
2024-02-14  7:36       ` David Marchand
2024-02-16 10:14         ` David Marchand
2024-02-16 20:46           ` Tyler Retzlaff
2024-02-18 12:31           ` Dodji Seketeli
2024-02-27 23:56 ` [PATCH v3 0/6] " Tyler Retzlaff
2024-02-27 23:56   ` [PATCH v3 1/6] hash: replace zero length array with flex array Tyler Retzlaff
2024-02-27 23:56   ` [PATCH v3 2/6] rcu: " Tyler Retzlaff
2024-02-27 23:56   ` [PATCH v3 3/6] fib: " Tyler Retzlaff
2024-02-27 23:56   ` [PATCH v3 4/6] pipeline: " Tyler Retzlaff
2024-02-27 23:56   ` [PATCH v3 5/6] lpm: " Tyler Retzlaff
2024-02-28  7:26     ` Morten Brørup
2024-02-27 23:56   ` [PATCH v3 6/6] table: " Tyler Retzlaff
2024-02-28  7:27     ` Morten Brørup
2024-02-29 22:58 ` [PATCH v4 0/6] more replacement of zero length array Tyler Retzlaff
2024-02-29 22:58   ` [PATCH v4 1/6] hash: replace zero length array with flex array Tyler Retzlaff
2024-02-29 22:58   ` [PATCH v4 2/6] rcu: " Tyler Retzlaff
2024-02-29 22:58   ` [PATCH v4 3/6] fib: " Tyler Retzlaff
2024-02-29 22:58   ` [PATCH v4 4/6] pipeline: " Tyler Retzlaff
2024-02-29 22:58   ` [PATCH v4 5/6] lpm: " Tyler Retzlaff
2024-03-01  8:12     ` Morten Brørup
2024-02-29 22:58   ` [PATCH v4 6/6] table: " Tyler Retzlaff
2024-03-01  8:13     ` Morten Brørup
2024-03-06 19:39   ` [PATCH v4 0/6] more replacement of zero length array Tyler Retzlaff
2024-03-06 20:13 ` [PATCH v5 " Tyler Retzlaff
2024-03-06 20:13   ` [PATCH v5 1/6] hash: replace zero length array with flex array Tyler Retzlaff
2024-03-06 20:52     ` Medvedkin, Vladimir
2024-03-06 20:13   ` [PATCH v5 2/6] rcu: " Tyler Retzlaff
2024-03-06 20:13   ` [PATCH v5 3/6] fib: " Tyler Retzlaff
2024-03-06 20:53     ` Medvedkin, Vladimir
2024-03-06 20:13   ` [PATCH v5 4/6] pipeline: " Tyler Retzlaff
2024-03-06 20:13   ` [PATCH v5 5/6] lpm: " Tyler Retzlaff
2024-03-06 20:53     ` Medvedkin, Vladimir
2024-03-06 20:13   ` [PATCH v5 6/6] table: " Tyler Retzlaff
2024-06-11 15:15   ` [PATCH v5 0/6] more replacement of zero length array David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBAPR08MB5814D21A6080FB868D109069987B2@DBAPR08MB5814.eurprd08.prod.outlook.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=nd@arm.com \
    --cc=roretzla@linux.microsoft.com \
    --cc=sameh.gobriel@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=vladimir.medvedkin@intel.com \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).