From: Tal Shnaiderman <talshn@nvidia.com>
To: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Asaf Penso <asafp@nvidia.com>,
"declan.doherty@intel.com" <declan.doherty@intel.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Eilon Greenstein <eilong@nvidia.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH v3 5/5] crypto/mlx5: support on Windows
Date: Sun, 31 Oct 2021 14:06:12 +0000 [thread overview]
Message-ID: <DM4PR12MB5389F0CF29B418B05208D9DCA4899@DM4PR12MB5389.namprd12.prod.outlook.com> (raw)
In-Reply-To: <DM4PR12MB5389846E531D15C3EE2B018AA4859@DM4PR12MB5389.namprd12.prod.outlook.com>
> Subject: RE: [EXT] [PATCH v3 5/5] crypto/mlx5: support on Windows
>
> > Subject: RE: [EXT] [PATCH v3 5/5] crypto/mlx5: support on Windows
> >
> > External email: Use caution opening links or attachments
> >
> >
> > > Add support for mlx5 crypto pmd on Windows OS.
> > > Add changes to release note and pmd guide.
> > >
> > > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > > Acked-by: Matan Azrad <matan@nvidia.com>
> > > ---
> > > doc/guides/cryptodevs/mlx5.rst | 15 ++++++++++++---
> > > doc/guides/rel_notes/release_21_11.rst | 1 +
> > > drivers/common/mlx5/version.map | 2 +-
> > > drivers/common/mlx5/windows/mlx5_common_os.c | 2 +-
> > > drivers/crypto/mlx5/meson.build | 4 ++--
> > > 5 files changed, 17 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/doc/guides/cryptodevs/mlx5.rst
> > > b/doc/guides/cryptodevs/mlx5.rst index 68bfdf3a83..7338c0c493 100644
> > > --- a/doc/guides/cryptodevs/mlx5.rst
> > > +++ b/doc/guides/cryptodevs/mlx5.rst
> > > @@ -39,12 +39,12 @@ or to access the hardware components directly.
> > > There are different levels of objects and bypassing abilities.
> > > To get the best performances:
> > >
> > > -- Verbs is a complete high-level generic API.
> > > -- Direct Verbs is a device-specific API.
> > > +- Verbs is a complete high-level generic API (Linux only).
> > > +- Direct Verbs is a device-specific API (Linux only).
> > > - DevX allows to access firmware objects.
> > >
> > > Enabling ``librte_crypto_mlx5`` causes DPDK applications -to be
> > > linked against libibverbs.
> > > +to be linked against libibverbs on Linux OS.
> > >
> > > In order to move the device to crypto operational mode, credential
> > > and KEK (Key Encrypting Key) should be set as the first step.
> > > @@ -155,8 +155,17 @@ Limitations
> > > Prerequisites
> > > -------------
> > >
> > > +Linux Prerequisites
> > > +~~~~~~~~~~~~~~~~~~~
> > > +
> > > - Mellanox OFED version: **5.3**
> > > see :doc:`../../nics/mlx5` guide for more Mellanox OFED details.
> > >
> > > - Compilation can be done also with rdma-core v15+.
> > > see :doc:`../../nics/mlx5` guide for more rdma-core details.
> > > +
> > > +Windows Prerequisites
> > > +~~~~~~~~~~~~~~~~~~~~~
> > > +
> > > +- Mellanox WINOF-2 version: **2.60** or higher.
> > > + see :doc:`../../nics/mlx5` guide for more Mellanox WINOF-2 details.
> >
> > I do not see a way to cross compile this driver with MinGW. How are we
> > expected to Test compilation for such cases? Do we need to build it
> > over Windows? I personally don't Think it is a good idea.
> >
> > Others please suggest.
>
> Yes, this driver can be built only using clang on Windows, net/mlx5 behaves
> the same way.
>
> DPDK CI has a compilation test for Windows [1], it will fail if a patch is
> introduced that caused compilation to fail on Windows.
>
> [1] https://lab.dpdk.org/results/dashboard/patchsets/19686/
Any other comments? If not, can this series be merged?
next prev parent reply other threads:[~2021-10-31 14:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 9:41 [dpdk-dev] [PATCH v2 0/6] Support MLX5 crypto driver " Tal Shnaiderman
2021-10-17 9:41 ` [dpdk-dev] [PATCH v2 1/6] common/mlx5: add DV enums to Windows defs file Tal Shnaiderman
2021-10-25 8:46 ` [dpdk-dev] [PATCH v3 0/5] Support MLX5 crypto driver on Windows Tal Shnaiderman
2021-10-25 8:46 ` [dpdk-dev] [PATCH v3 1/5] common/mlx5: add DV enums to Windows defs file Tal Shnaiderman
2021-10-25 8:46 ` [dpdk-dev] [PATCH v3 2/5] crypto/mlx5: modify unix pthread code Tal Shnaiderman
2021-10-25 8:46 ` [dpdk-dev] [PATCH v3 3/5] crypto/mlx5: fix size of UMR WQE Tal Shnaiderman
2021-10-25 8:46 ` [dpdk-dev] [PATCH v3 4/5] build: check Windows support per driver Tal Shnaiderman
2021-10-25 8:46 ` [dpdk-dev] [PATCH v3 5/5] crypto/mlx5: support on Windows Tal Shnaiderman
2021-10-27 12:04 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-10-27 13:33 ` Tal Shnaiderman
2021-10-31 14:06 ` Tal Shnaiderman [this message]
2021-10-31 19:08 ` Akhil Goyal
2021-10-17 9:41 ` [dpdk-dev] [PATCH v2 2/6] crypto/mlx5: replace UNIX functions with EAL functions Tal Shnaiderman
2021-10-17 9:41 ` [dpdk-dev] [PATCH v2 3/6] crypto/mlx5: use OS agnostic functions for UMEM operations Tal Shnaiderman
2021-10-17 9:41 ` [dpdk-dev] [PATCH v2 4/6] crypto/mlx5: fix size of UMR WQE Tal Shnaiderman
2021-10-17 9:41 ` [dpdk-dev] [PATCH v2 5/6] build: check Windows support per driver Tal Shnaiderman
2021-10-17 9:41 ` [dpdk-dev] [PATCH v2 5/6] build: have Windows support checked " Tal Shnaiderman
2021-10-17 9:41 ` [dpdk-dev] [PATCH v2 6/6] crypto/mlx5: support on Windows Tal Shnaiderman
2021-10-17 10:13 ` [dpdk-dev] [PATCH v2 0/6] Support MLX5 crypto driver " Matan Azrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5389F0CF29B418B05208D9DCA4899@DM4PR12MB5389.namprd12.prod.outlook.com \
--to=talshn@nvidia.com \
--cc=asafp@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=eilong@nvidia.com \
--cc=ferruh.yigit@intel.com \
--cc=gakhil@marvell.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).