From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop
Date: Tue, 27 Apr 2021 01:51:00 +0000 [thread overview]
Message-ID: <DM5PR11MB17871E84400A33835D37F53C8C419@DM5PR11MB1787.namprd11.prod.outlook.com> (raw)
In-Reply-To: <0e87d690425949c3839a1ac48dc0406b@intel.com>
> > +use_sse = true;
> > +if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 ||
> > + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) &&
> > + rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256)
> > +use_avx2 = true;
>
>
> Not sure if the right path will be selected when avx512 is not true,
> (CC_AVX512_SUPPORT is disable) while check_ret is
> IAVF_VECTOR_OFFLOAD_PATH?
>
> Currently we have
>
> if (!use_sse && !use_avx2 && !use_avx512) goto normal;
>
> Should we also add below check?
>
> if (!use_avx512 && check_ret == IAVF_VECTOR_OFFLOAD_PATH)
> goto normal;
Not necessary. As explained in the commit log, AVX2 and SSE support the offload features. The purpose of this patch is to let AVX2 be chosen when offload needed and AVX512 disable.
next prev parent reply other threads:[~2021-04-27 1:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 5:29 Wenzhuo Lu
2021-04-26 9:04 ` Zhang, Qi Z
2021-04-27 1:51 ` Lu, Wenzhuo [this message]
2021-04-27 2:57 ` Zhang, Qi Z
2021-04-27 5:09 ` Lu, Wenzhuo
2021-04-28 11:32 ` Ferruh Yigit
2021-04-28 12:06 ` Zhang, Qi Z
2021-04-27 5:19 ` Zhang, Qi Z
2021-04-28 11:32 ` Ferruh Yigit
2021-04-29 1:08 ` Lu, Wenzhuo
2021-04-29 1:33 ` Wenzhuo Lu
2021-04-29 3:20 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR11MB17871E84400A33835D37F53C8C419@DM5PR11MB1787.namprd11.prod.outlook.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).